Plume/Plume
9
18
Çatalla 24
Kod Konular 177 Değişiklik İstekleri 8 Sürüm 8 Wiki Aktivite

proxy support #829

Elle birleştirildi
KitaitiMakoto 2021-01-13 14:20:37 +00:00 dr-bonez/Plume:feature/proxy içindeki 2 işlemeyi main ile birleştirdi
Sohbet 6 İşleme 2 Değiştirilen Dosyalar 63 +23944 -21671
dr-bonez 2020-10-13 20:24:32 +00:00 yorum yaptı
Katılımcı
Bağlantıyı Kopyala

Adds support for using a proxy for federation.
Motivation is for being able to support homeservers running as Tor hidden services.

Threading config information into plume-common is the only reason this pr isn't very low impact.

Adds support for using a proxy for federation. Motivation is for being able to support homeservers running as Tor hidden services. Threading config information into plume-common is the only reason this pr isn't very low impact.
KitaitiMakoto 2020-12-06 17:38:04 +00:00 yorum yaptı
Sahibi
Bağlantıyı Kopyala

Thank you for pull request and sorry for late reply. But we have less time to review, now. Can you wait for a while, please? Thanks.

Thank you for pull request and sorry for late reply. But we have less time to review, now. Can you wait for a while, please? Thanks.
KitaitiMakoto 2021-01-02 16:50:37 +00:00 yorum yaptı
Sahibi
Bağlantıyı Kopyala

Sorry for very late reply.

What need proxy config is only ClientBuilder. How about to use CONFIG.proxy() directly in plume-common/src/activity_pub/mod.rs?

Sorry for very late reply. What need proxy config is only `ClientBuilder`. How about to use `CONFIG.proxy()` directly in `plume-common/src/activity_pub/mod.rs`?
dr-bonez 2021-01-11 20:24:33 +00:00 yorum yaptı
Yazar
Katılımcı
Bağlantıyı Kopyala

I can't. CONFIG comes from plume-models, which has plume-common as a dependency. Pretty sure you can't have 2 crates that depend on each other.

I can't. CONFIG comes from plume-models, which has plume-common as a dependency. Pretty sure you can't have 2 crates that depend on each other.
dr-bonez 2021-01-11 20:34:33 +00:00 yorum yaptı
Yazar
Katılımcı
Bağlantıyı Kopyala

rebased

rebased
KitaitiMakoto 2021-01-13 14:16:23 +00:00 bu değişiklikleri onayladı
KitaitiMakoto 2021-01-13 14:18:12 +00:00 yorum yaptı
Sahibi
Bağlantıyı Kopyala

Okay, I will merge. Thank you for your work!

Okay, I will merge. Thank you for your work!
KitaitiMakoto 2021-01-13 14:19:50 +00:00 yorum yaptı
Sahibi
Bağlantıyı Kopyala

Okay, I will merge. Thank you for your work!

Okay, I will merge. Thank you for your work!
KitaitiMakoto ec8c17482d işlemesi, main dalına elle birleştirildi 2021-01-13 14:20:37 +00:00
Bu konuşmaya katılmak için oturum aç.
Gözden Geçirenler
Değerlendirici yok
KitaitiMakoto
Etiketler
Etiketleri temizle   
A: API

Related to the REST API

  
A: Backend

Code running on the server

  
A: Federation

Stuff related to Federation

  
A: Front-End

Related to the front-end

  
A: I18N

Translations, and related code

  
A: Meta

More about project management or code than the project itself

  
A: Security

   
Build

The building, or installation process of Plume

  
C: Bug

Something isn't working

  
C: Discussion

We need to talk

  
C: Enhancement

New feature or request

  
C: Feature

This is a new feature

  
Compatibility

Compatibility with different browsers, readers and OS

  
Dependency

Related to an external package that Plume uses

  
Design

UI/UX related issues and PRs

  
Documentation

   
Good first issue

Good for newcomers

  
Help welcome

Extra attention is needed

  
Mobile

Issues affecting only mobile UX

  
Rendering

How elements're rendered out for the end user

  
S: Blocked

Something else needs to be fixed first

  
S: Duplicate

This issue or pull request already exists

  
S: Incomplete

This PR is not complete yet

  
S: Instance specific

Issues concern a limited number of instances

  
S: Invalid

This doesn't seem right

  
S: Needs Voting/Discussion

Need to be discussed by the community (on Loomio)

  
S: Ready for review

This PR is ready to be reviewed

  
Suggestion

Proposed ideas worth considering

  
S: Voted on Loomio

This is issue has been created after a vote on Loomio

  
S: Wontfix

This will not be worked on

Etiket Yok
A: API
A: Backend
A: Federation
A: Front-End
A: I18N
A: Meta
A: Security
Build
C: Bug
C: Discussion
C: Enhancement
C: Feature
Compatibility
Dependency
Design
Documentation
Good first issue
Help welcome
Mobile
Rendering
S: Blocked
S: Duplicate
S: Incomplete
S: Instance specific
S: Invalid
S: Needs Voting/Discussion
S: Ready for review
Suggestion
S: Voted on Loomio
S: Wontfix
Kilometre Taşı
Kilometre Taşlarını Temizle
Öge yok
Kilometre Taşı Yok
Projeler
Projeleri temizle
Öge yok
Proje yok
Atananlar
Atamaları Temizle
Atanan Kişi Yok
2 Katılımcı
Bildirimler
Bitiş Tarihi
Bitiş tarihi geçersiz veya aralık dışında. Lütfen 'yyyy-aa-gg' biçimini kullanın.

Bitiş tarihi atanmadı.

Bağımlılıklar

Bağımlılık yok.

Referans: Plume/Plume#829
Herhangi bir açıklama sağlanmadı.
"dr-bonez/Plume:feature/proxy" Dalını Sil

Bir dalı silmek kalıcıdır. Her ne kadar silinen dal tamamen kaldırılana kadar çok kısa bir süre yaşamını sürdürse de, çoğu durumda bu işlem GERİ ALINAMAZ. Devam edilsin mi?