Plume
/
Plume
6
10
Форк 9
Код Проблеми 135 Запити на злиття 11 Релізи 5 Вікі Активність
Мітки Етап
Новий запит на злиття

#829 proxy support

Злито
KitaitiMakoto злито 2 комітів з dr-bonez/Plume:feature/proxy до main 4 дні тому
Обговорення 6 Коміти 2 Змінені файли 63
dr-bonez прокоментував(ла) 3 місяці тому

Adds support for using a proxy for federation.
Motivation is for being able to support homeservers running as Tor hidden services.

Threading config information into plume-common is the only reason this pr isn’t very low impact.

Adds support for using a proxy for federation. Motivation is for being able to support homeservers running as Tor hidden services. Threading config information into plume-common is the only reason this pr isn't very low impact.
KitaitiMakoto прокоментував(ла) 1 місяць тому
Власник

Thank you for pull request and sorry for late reply. But we have less time to review, now. Can you wait for a while, please? Thanks.

Thank you for pull request and sorry for late reply. But we have less time to review, now. Can you wait for a while, please? Thanks.
KitaitiMakoto прокоментував(ла) 2 тижднів тому
Власник

Sorry for very late reply.

What need proxy config is only ClientBuilder. How about to use CONFIG.proxy() directly in plume-common/src/activity_pub/mod.rs?

Sorry for very late reply. What need proxy config is only `ClientBuilder`. How about to use `CONFIG.proxy()` directly in `plume-common/src/activity_pub/mod.rs`?
dr-bonez прокоментував(ла) 6 дні тому
Автор

I can’t. CONFIG comes from plume-models, which has plume-common as a dependency. Pretty sure you can’t have 2 crates that depend on each other.

I can't. CONFIG comes from plume-models, which has plume-common as a dependency. Pretty sure you can't have 2 crates that depend on each other.
dr-bonez прокоментував(ла) 6 дні тому
Автор

rebased

rebased
KitaitiMakoto зміни затверджено 4 дні тому
KitaitiMakoto прокоментував(ла) 4 дні тому
Власник

Okay, I will merge. Thank you for your work!

Okay, I will merge. Thank you for your work!
KitaitiMakoto прокоментував(ла) 4 дні тому
Власник

Okay, I will merge. Thank you for your work!

Okay, I will merge. Thank you for your work!
KitaitiMakoto merged commit ec8c17482d into main 4 дні тому

Рецензенти

KitaitiMakoto зміни затверджено 4 дні тому
Запит на злиття був влитиий як ec8c17482d.
Підпишіться щоб приєднатися до обговорення.
Рецензенти
Request review
No reviewers
 KitaitiMakoto
Мітки
Apply labels
Очистити мітки
A: API
Related to the REST API A: Backend
Code running on the server A: Federation
Stuff related to Federation A: Front-End
Related to the front-end A: I18N
Translations, and related code A: Meta
More about project management or code than the project itself A: Security Build
The building, or installation process of Plume C: Bug
Something isn't working C: Discussion
We need to talk C: Enhancement
New feature or request C: Feature
This is a new feature Compatibility
Compatibility with different browsers, readers and OS Dependency
Related to an external package that Plume uses Design
UI/UX related issues and PRs Documentation Good first issue
Good for newcomers Help welcome
Extra attention is needed Mobile
Issues affecting only mobile UX Rendering
How elements're rendered out for the end user S: Blocked
Something else needs to be fixed first S: Duplicate
This issue or pull request already exists S: Incomplete
This PR is not complete yet S: Instance specific
Issues concern a limited number of instances S: Invalid
This doesn't seem right S: Needs Voting/Discussion
Need to be discussed by the community (on Loomio) S: Ready for review
This PR is ready to be reviewed Suggestion
Proposed ideas worth considering S: Voted on Loomio
This is issue has been created after a vote on Loomio S: Wontfix
This will not be worked on
Без мітки
A: API
A: Backend
A: Federation
A: Front-End
A: I18N
A: Meta
A: Security
Build
C: Bug
C: Discussion
C: Enhancement
C: Feature
Compatibility
Dependency
Design
Documentation
Good first issue
Help welcome
Mobile
Rendering
S: Blocked
S: Duplicate
S: Incomplete
S: Instance specific
S: Invalid
S: Needs Voting/Discussion
S: Ready for review
Suggestion
S: Voted on Loomio
S: Wontfix
Етап
Set milestone
Очистити етап
No items
Етап відсутній
Виконавеці
Assign users
Прибрати виконавеців
Немає виконавеця
2 учасників
Сповіщення
Дата завершення

Термін виконання не встановлений.

Залежності

Цей запит на злиття в даний час не має залежностей.

Писати Попередній перегляд
Завантаження…
Відмінити
Зберегти
Тут ще немає жодного змісту.
Видалити гілку 'dr-bonez/Plume:feature/proxy'

Видалення гілки НЕЗВОРОТНЕ. Дію не можна скасувати. Продовжити?

Ні
Так