proxy support #829

Ручне злиття
KitaitiMakoto об'єднав 2 комітів з dr-bonez/Plume:feature/proxy в main 2021-01-13 14:20:37 +00:00
dr-bonez прокоментував(ла) 2020-10-13 20:24:32 +00:00
Дописувач

Adds support for using a proxy for federation.
Motivation is for being able to support homeservers running as Tor hidden services.

Threading config information into plume-common is the only reason this pr isn't very low impact.

Adds support for using a proxy for federation. Motivation is for being able to support homeservers running as Tor hidden services. Threading config information into plume-common is the only reason this pr isn't very low impact.
KitaitiMakoto прокоментував(ла) 2020-12-06 17:38:04 +00:00
Власник

Thank you for pull request and sorry for late reply. But we have less time to review, now. Can you wait for a while, please? Thanks.

Thank you for pull request and sorry for late reply. But we have less time to review, now. Can you wait for a while, please? Thanks.
KitaitiMakoto прокоментував(ла) 2021-01-02 16:50:37 +00:00
Власник

Sorry for very late reply.

What need proxy config is only ClientBuilder. How about to use CONFIG.proxy() directly in plume-common/src/activity_pub/mod.rs?

Sorry for very late reply. What need proxy config is only `ClientBuilder`. How about to use `CONFIG.proxy()` directly in `plume-common/src/activity_pub/mod.rs`?
dr-bonez прокоментував(ла) 2021-01-11 20:24:33 +00:00
Автор
Дописувач

I can't. CONFIG comes from plume-models, which has plume-common as a dependency. Pretty sure you can't have 2 crates that depend on each other.

I can't. CONFIG comes from plume-models, which has plume-common as a dependency. Pretty sure you can't have 2 crates that depend on each other.
dr-bonez прокоментував(ла) 2021-01-11 20:34:33 +00:00
Автор
Дописувач

rebased

rebased
KitaitiMakoto зміни затверджено 2021-01-13 14:16:23 +00:00
KitaitiMakoto прокоментував(ла) 2021-01-13 14:18:12 +00:00
Власник

Okay, I will merge. Thank you for your work!

Okay, I will merge. Thank you for your work!
KitaitiMakoto прокоментував(ла) 2021-01-13 14:19:50 +00:00
Власник

Okay, I will merge. Thank you for your work!

Okay, I will merge. Thank you for your work!
KitaitiMakoto вручну об'єднав коміт ec8c17482d в main 2021-01-13 14:20:37 +00:00
Підпишіться щоб приєднатися до обговорення.
Немає рецензентів
Етап відсутній
Проєкт відсутній
Немає виконавців
2 учасників
Сповіщення
Дата завершення
Термін дії недійсний або знаходиться за межами допустимого діапазону. Будь ласка, використовуйте формат «рррр-мм-дд».

Термін виконання не встановлено.

Залежності

Залежностей не встановлено.

Reference: Plume/Plume#829
Немає опису.