Adds support for using a proxy for federation.
Motivation is for being able to support homeservers running as Tor hidden services.
Threading config information into plume-common is the only reason this pr isn’t very low impact.
Adds support for using a proxy for federation.
Motivation is for being able to support homeservers running as Tor hidden services.
Threading config information into plume-common is the only reason this pr isn't very low impact.
What need proxy config is only ClientBuilder. How about to use CONFIG.proxy() directly in plume-common/src/activity_pub/mod.rs?
Sorry for very late reply.
What need proxy config is only `ClientBuilder`. How about to use `CONFIG.proxy()` directly in `plume-common/src/activity_pub/mod.rs`?
KitaitiMakoto
Adds support for using a proxy for federation.
Motivation is for being able to support homeservers running as Tor hidden services.
Threading config information into plume-common is the only reason this pr isn’t very low impact.
Thank you for pull request and sorry for late reply. But we have less time to review, now. Can you wait for a while, please? Thanks.
Sorry for very late reply.
What need proxy config is only
ClientBuilder. How about to useCONFIG.proxy()directly inplume-common/src/activity_pub/mod.rs?I can’t. CONFIG comes from plume-models, which has plume-common as a dependency. Pretty sure you can’t have 2 crates that depend on each other.
rebased
Okay, I will merge. Thank you for your work!
Okay, I will merge. Thank you for your work!
评审人
ec8c17482d被合并。