Keep tags as-is #832

Manually merged

KitaitiMakoto обедини 1 ревизии от KitaitiMakoto/Plume:keep-tag във main

KitaitiMakoto коментира

Притежател

This fixes issue #825 on GitHub.

This fixes [issue #825 on GitHub](https://github.com/Plume-org/Plume/issues/825).

kiwii approved these changes

kiwii left a comment

Притежател

I wonder if heck is still needed in our dependencies? Maybe to generate blog identifiers from their title? Otherwise LGTM 👍

I wonder if `heck` is still needed in our dependencies? Maybe to generate blog identifiers from their title? Otherwise LGTM 👍

kiwii коментира

Притежател

Also fixes #721 and one item of #348

KitaitiMakoto коментира

Участник

Притежател

Current patch doesn't fix #721 because it doesn't touch slug matters. heck is required for slug. Slug requires more consideration if we want to use only ASCII characters in URI.

👍 1

KitaitiMakoto коментира

Участник

Притежател

Will merge this pull request. About cases in slug, keep discussing at #721.

KitaitiMakoto посочи тази задача от ревизия

Merge pull request 'Keep tags as-is' (#832) from KitaitiMakoto/Plume:keep-tag into main Reviewed-on: https://git.joinplu.me/Plume/Plume/pulls/832 Reviewed-by: kiwii <kiwii@noreply@joinplu.me>

KitaitiMakoto merged commit 3c666080a9 into main manually преди 3 години

KitaitiMakoto deleted branch keep-tag

Reviewers

kiwii approved these changes

The pull request has been manually merged as 3c666080a9.

Впишете се за да се присъедините към разговора.

No reviewers

Няма етап

Няма изпълнители

2 участника

Известия

Due Date

Крайният срок е невалиден или извън обхват. Моля използвайте форматът 'гггг-мм-дд'.

No due date set.

Зависимости

No dependencies set.

Зареждане…

Все още няма съдържание.

Етикети Етапи

Keep tags as-is #832

Reviewers