Keep tags as-is #832

Manually merged
KitaitiMakoto merged 1 commits from KitaitiMakoto/Plume:keep-tag into main 3 years ago
Owner

This fixes issue #825 on GitHub.

This fixes [issue #825 on GitHub](https://github.com/Plume-org/Plume/issues/825).
kiwii approved these changes 3 years ago
kiwii left a comment
Owner

I wonder if heck is still needed in our dependencies? Maybe to generate blog identifiers from their title? Otherwise LGTM 👍

I wonder if `heck` is still needed in our dependencies? Maybe to generate blog identifiers from their title? Otherwise LGTM 👍
kiwii commented 3 years ago
Owner

Also fixes #721 and one item of #348

Also fixes #721 and one item of #348
Poster
Owner

Current patch doesn't fix #721 because it doesn't touch slug matters. heck is required for slug. Slug requires more consideration if we want to use only ASCII characters in URI.

Current patch doesn't fix #721 because it doesn't touch slug matters. heck is required for slug. Slug requires more consideration if we want to use only ASCII characters in URI.
Poster
Owner

Will merge this pull request. About cases in slug, keep discussing at #721.

Will merge this pull request. About cases in slug, keep discussing at #721.
KitaitiMakoto merged commit 3c666080a9 into main manually 3 years ago
KitaitiMakoto deleted branch keep-tag 3 years ago

Reviewers

kiwii approved these changes 3 years ago
The pull request has been manually merged as 3c666080a9.
Sign in to join this conversation.
No reviewers
No Milestone
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Plume/Plume#832
Loading…
There is no content yet.