Draw side line for blockquote on start #933

Merged
trinity-1686a merged 2 commits from ahangarha/Plume:ahangarha-patch-1-blockquote-line into main 2 weeks ago

By this change, the line beside blockquote would appear at start. It means if the text is in LTR language, it appears on left and if it is in RTL, the line appears on right.

By this change, the line beside blockquote would appear at start. It means if the text is in LTR language, it appears on left and if it is in RTL, the line appears on right.

I tried the patch and it seems to do nothing for me.
Plume generated html looks like this:

<blockquote dir="auto">
	<p dir="auto">
		سلام 
	</p>
</blockquote>

Removing the dir="auto" from the <p> makes it works as intended, so there will be need for further changes for this to work, probably in pulldown-cmark.
Shall I merge this anyway?

I tried the patch and it seems to do nothing for me. Plume generated html looks like this: ```html <blockquote dir="auto"> <p dir="auto"> سلام </p> </blockquote> ``` Removing the `dir="auto"` from the `<p>` makes it works as intended, so there will be need for further changes for this to work, probably in pulldown-cmark. Shall I merge this anyway?
Poster

Since dir="auto" was added in the forked repo, then that can be improved. It seems removing dir=auto from blockquote can help. Can you confirm this?

Since `dir="auto"` was added in the forked repo, then that can be improved. It seems removing `dir=auto` from `blockquote` can help. Can you confirm this?
trinity-1686a added 1 commit 2 weeks ago

I believe I've made the required changes on the pulldown-cmark side. I'm too busy to test right now, but I'll try to come back soon

I believe I've made the required changes on the pulldown-cmark side. I'm too busy to test right now, but I'll try to come back soon
trinity-1686a approved these changes 2 weeks ago
trinity-1686a merged commit d7d6d5f644 into main 2 weeks ago
ahangarha deleted branch ahangarha-patch-1-blockquote-line 2 weeks ago

Reviewers

trinity-1686a approved these changes 2 weeks ago
The pull request has been merged as d7d6d5f644.
Sign in to join this conversation.
No reviewers
No Milestone
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

Loading…
There is no content yet.