Fix RTL problem in post card #956

Merged

KitaitiMakoto merged 3 commits from :main into main

mskf1383 commented

#950

https://git.joinplu.me/Plume/Plume/issues/950

mskf1383 added 2 commits

9dac97045b Update 'templates/partials/post_card.rs.html'

afd66ce7cb Update 'assets/themes/default/_global.scss'

KitaitiMakoto commented

Owner

Thank you!

But, according to MDN's compatibility table, browsers other than Firefox don't support inline-end for float. Can you use portable property? Changes for appearance are accepted.

Thank you! But, according to [MDN's compatibility table](https://developer.mozilla.org/en-US/docs/Web/CSS/float), browsers other than Firefox don't support `inline-end` for `float`. Can you use portable property? Changes for appearance are accepted.

mskf1383 added 1 commit

7b110179a9 Update 'assets/themes/default/_global.scss'

mskf1383 commented

Poster

I made some changes:

.card h3 {
    flex-grow: 1;
    margin: 0;
    font-family: "Vazir","Playfair Display",serif;
    font-size: 1.75em;
    font-weight: normal;
    line-height: 1.75;
    display: inline-block;
    position: absolute; /* New */
}
.card .controls {
    float: inline-end; /* removed */
    text-align: end /* New */
}

It's compatible with all browsers, except IE: https://developer.mozilla.org/en-US/docs/Web/CSS/text-align

I made some changes: ```css .card h3 { flex-grow: 1; margin: 0; font-family: "Vazir","Playfair Display",serif; font-size: 1.75em; font-weight: normal; line-height: 1.75; display: inline-block; position: absolute; /* New */ } .card .controls { float: inline-end; /* removed */ text-align: end /* New */ } ``` It's compatible with all browsers, except IE: https://developer.mozilla.org/en-US/docs/Web/CSS/text-align

KitaitiMakoto approved these changes

KitaitiMakoto left a comment

Owner

Seems good! Thank you.

KitaitiMakoto referenced this issue from a commit

Merge pull request 'Fix RTL problem in post card' (#956) from mskf1383/Plume:main into main

KitaitiMakoto merged commit 82ebdc023c into main 2 years ago

KitaitiMakoto referenced this pull request

RTL problem in post card #950

mskf1383 referenced this pull request

Fix problem of PL #956 #962

mskf1383 referenced this pull request

Fix problem of PL #956 #963

Reviewers

KitaitiMakoto approved these changes

The pull request has been merged as 82ebdc023c.

No reviewers

No Milestone

No Assignees

2 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Loading…

There is no content yet.

Labels Milestones

Fix RTL problem in post card #956

Reviewers