Update config docs #19

Merged
elegaanz merged 2 commits from plume/documentation:logo into master 5 years ago
elegaanz commented 5 years ago (Migrated from github.com)

cc @fdb-hiroshima

Fixes #17

cc @fdb-hiroshima Fixes #17
trinity-1686a approved these changes 5 years ago
trinity-1686a left a comment
Owner

PLUME_LOGO_{size} can actually be any positive integer, not only the few sizes you mentioned, I don't know how much of a difference it makes but I just want to mention it 🤷‍♀️

PLUME_LOGO_{size} can actually be any positive integer, not only the few sizes you mentioned, I don't know how much of a difference it makes but I just want to mention it :woman_shrugging:
elegaanz commented 5 years ago (Migrated from github.com)

I listed these sizes because they are the one that are expected in the WebManifest. But maybe they are used in difference places too, I don't remember?

I listed these sizes because they are the one that are expected in the WebManifest. But maybe they are used in difference places too, I don't remember?
Owner

No they don't but I don't know anything about how WebManifest work. I just made so by default it output the same as before, and it have meaningful values when only PLUME_LOGO is filled 😬

No they don't but I don't know anything about how WebManifest work. I just made so by default it output the same as before, and it have meaningful values when only PLUME_LOGO is filled :grimacing:

Reviewers

trinity-1686a approved these changes 5 years ago
The pull request has been merged as edd3bead5e.
You can also view command line instructions.

Step 1:

From your project repository, check out a new branch and test the changes.
git checkout -b logo master
git pull origin logo

Step 2:

Merge the changes and update on Forgejo.
git checkout master
git merge --no-ff logo
git push origin master
Sign in to join this conversation.
Loading…
There is no content yet.