Add Windows OS to install docs
#83
Merged
iamdoubz
merged 5 commits from plume/documentation:iad_windows into dev 4 years ago
No reviewers
No Label
bug
dependencies
duplicate
enhancement
good first issue
help wanted
invalid
question
wontfix
No Milestone
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: plume/documentation#83
Loading…
Reference in New Issue
There is no content yet.
Delete Branch 'plume/documentation:iad_windows'
Deleting a branch is permanent. It CANNOT be undone. Continue?
Also made some tiny adjustments to existing docs as I went into every file anyway.
Globally it looks good! I couldn't test, since I don't own a Windows PC, but I trust you.
@ -17,3 +17,3 @@Here is a sample of what you should put inside.Here is a sample of what you should put inside for **GNU/Linux** and **Mac OS X** systems.```bashSorry, but this may be confusing as most people will probably install Plume on a Linux server, where this path will be invalid. Maybe add another example with a Linux path, and explain which path is for which OS?
Isn't it with
plmthat the migrations are run? (dieselshould work too, but it means one more command to install)I'm not sure we want to add that, this was meant to be a "minimal" config example IMO. There is a link for all the options just under, for people who want deep customization.
@ -4,3 +4,3 @@First, make sure your computer is aware of the latest availabel versions of installableFirst, make sure your computer is aware of the latest available versions of installablepackages. This command, and the other on this page, may require super-user rights, soThanks for that!
Rephrasing to avoid "I" would be better IMO.
Maybe say it is the recommended option for Windows or something?
I don't know if you tested this option, but I'm not sure it will actually work, since Plume was designed with the assumption that it was running on its own domain.
In 0.3, I had lots of problems doing
plmversesdiesel. I can try building again but usingplmthis time.Fair enough. I agree, but wanted to make sure.
@ -17,3 +17,3 @@Here is a sample of what you should put inside.Here is a sample of what you should put inside for **GNU/Linux** and **Mac OS X** systems.```bashAgreed. I will update.
I did think about this when I did my initial writing up. I will add a comment above the line instead of inline.
Alright. That is why I put experimental as it is very difficult to implement, and probably wouldn't work anyway. I'll just remove it for now.
Yes, diesel VS plm was a mess in 0.3, but it should be fine with 0.4
we could open it as feature request.
it's probably somewhat related (orthogonal) to https://github.com/Plume-org/Plume/issues/94
I’ve thought about this to. I think if you use a subdirectory variable in .env that accepts null and folder names. This sets a variable to all css and js (to be added) and adds correct path to css and js from web on server start. It is similar to adding a meta tag to the html something like
<meta name=“suburl” content=“/plume” />This is how Gitea does it... not that it means anything.
Made changes per @AnaGelez and @igalic to add Windows install docs.
Just a small comment about paths, otherwise it looks good! Thank you.
UNIX paths uses
/not\.This remark is useless, since both use
/.Excellent thank you.
I compiled for Postgres as well. Should I add it to this pull, or make another?
sure, go ahead
Fixed.
Removed.
Added.
I think we're done here? (For now)
i would've assumed that the rust path library normalises the input
I thought that as well, but if you do not change them, it will throw error when you go to start plume.
Perfect! Thank you!
Reviewers
1423e02ce4.Step 1:
From your project repository, check out a new branch and test the changes.Step 2:
Merge the changes and update on Forgejo.