Plume/documentation
6
2
Fork 11
Code Issues 5 Pull requests 3 Releases Wiki Activity

Add Windows OS to install docs #83

Merged
iamdoubz merged 5 commits from plume/documentation:iad_windows into dev 2020-02-04 07:07:54 +00:00
Conversation 4 Commits 5 Files changed 12 +156 -9
iamdoubz commented 2020-01-24 20:22:35 +00:00 (Migrated from github.com)
Copy link

Also made some tiny adjustments to existing docs as I went into every file anyway.

Also made some tiny adjustments to existing docs as I went into every file anyway.
elegaanz (Migrated from github.com) reviewed 2020-01-25 11:36:00 +00:00
elegaanz (Migrated from github.com) left a comment
Copy link

Globally it looks good! I couldn't test, since I don't own a Windows PC, but I trust you.

Globally it looks good! I couldn't test, since I don't own a Windows PC, but I trust you.
source/installation/config.html.md
@ -17,3 +17,3 @@
Here is a sample of what you should put inside.
Here is a sample of what you should put inside for **GNU/Linux** and **Mac OS X** systems.
```bash
elegaanz (Migrated from github.com) commented 2020-01-25 11:29:12 +00:00
Copy link

Sorry, but this may be confusing as most people will probably install Plume on a Linux server, where this path will be invalid. Maybe add another example with a Linux path, and explain which path is for which OS?

Sorry, but this may be confusing as most people will probably install Plume on a Linux server, where this path will be invalid. Maybe add another example with a Linux path, and explain which path is for which OS?
source/installation/config.html.md
elegaanz (Migrated from github.com) commented 2020-01-25 11:26:33 +00:00
Copy link

Isn't it with plm that the migrations are run? (diesel should work too, but it means one more command to install)

Isn't it with `plm` that the migrations are run? (`diesel` should work too, but it means one more command to install)
elegaanz (Migrated from github.com) commented 2020-01-25 11:27:40 +00:00
Copy link

I'm not sure we want to add that, this was meant to be a "minimal" config example IMO. There is a link for all the options just under, for people who want deep customization.

I'm not sure we want to add that, this was meant to be a "minimal" config example IMO. There is a link for all the options just under, for people who want deep customization.
source/installation/deps/deb.html.md
@ -4,3 +4,3 @@
First, make sure your computer is aware of the latest availabel versions of installable
First, make sure your computer is aware of the latest available versions of installable
packages. This command, and the other on this page, may require super-user rights, so
elegaanz (Migrated from github.com) commented 2020-01-25 11:29:42 +00:00
Copy link

Thanks for that!

Thanks for that!
source/installation/deps/windows.html.md
elegaanz (Migrated from github.com) commented 2020-01-25 11:31:35 +00:00
Copy link

Rephrasing to avoid "I" would be better IMO.

Rephrasing to avoid "I" would be better IMO.
source/installation/init.html.md
elegaanz (Migrated from github.com) commented 2020-01-25 11:32:22 +00:00
Copy link

Maybe say it is the recommended option for Windows or something?

Maybe say it is the recommended option for Windows or something?
source/installation/proxy/iis.html.md
elegaanz (Migrated from github.com) commented 2020-01-25 11:34:18 +00:00
Copy link

I don't know if you tested this option, but I'm not sure it will actually work, since Plume was designed with the assumption that it was running on its own domain.

I don't know if you tested this option, but I'm not sure it will actually work, since Plume was designed with the assumption that it was running on its own domain.
iamdoubz (Migrated from github.com) reviewed 2020-01-31 20:03:52 +00:00
source/installation/config.html.md
iamdoubz (Migrated from github.com) commented 2020-01-31 20:03:52 +00:00
Copy link

In 0.3, I had lots of problems doing plm verses diesel. I can try building again but using plm this time.

In 0.3, I had lots of problems doing `plm` verses `diesel`. I can try building again but using `plm` this time.
iamdoubz (Migrated from github.com) reviewed 2020-01-31 20:04:12 +00:00
source/installation/config.html.md
iamdoubz (Migrated from github.com) commented 2020-01-31 20:04:12 +00:00
Copy link

Fair enough. I agree, but wanted to make sure.

Fair enough. I agree, but wanted to make sure.
iamdoubz (Migrated from github.com) reviewed 2020-01-31 20:05:34 +00:00
source/installation/config.html.md
@ -17,3 +17,3 @@
Here is a sample of what you should put inside.
Here is a sample of what you should put inside for **GNU/Linux** and **Mac OS X** systems.
```bash
iamdoubz (Migrated from github.com) commented 2020-01-31 20:05:34 +00:00
Copy link

Agreed. I will update.

Agreed. I will update.
iamdoubz (Migrated from github.com) reviewed 2020-01-31 20:07:20 +00:00
source/installation/deps/windows.html.md
iamdoubz (Migrated from github.com) commented 2020-01-31 20:07:20 +00:00
Copy link

I did think about this when I did my initial writing up. I will add a comment above the line instead of inline.

I did think about this when I did my initial writing up. I will add a comment above the line instead of inline.
iamdoubz (Migrated from github.com) reviewed 2020-01-31 20:46:42 +00:00
source/installation/proxy/iis.html.md
iamdoubz (Migrated from github.com) commented 2020-01-31 20:46:42 +00:00
Copy link

Alright. That is why I put experimental as it is very difficult to implement, and probably wouldn't work anyway. I'll just remove it for now.

Alright. That is why I put experimental as it is very difficult to implement, and probably wouldn't work anyway. I'll just remove it for now.
elegaanz (Migrated from github.com) reviewed 2020-02-02 10:53:33 +00:00
source/installation/config.html.md
elegaanz (Migrated from github.com) commented 2020-02-02 10:53:32 +00:00
Copy link

Yes, diesel VS plm was a mess in 0.3, but it should be fine with 0.4

Yes, diesel VS plm was a mess in 0.3, but it should be fine with 0.4
igalic (Migrated from github.com) reviewed 2020-02-02 14:33:34 +00:00
source/installation/proxy/iis.html.md
igalic (Migrated from github.com) commented 2020-02-02 14:33:34 +00:00
Copy link

we could open it as feature request.
it's probably somewhat related (orthogonal) to https://github.com/Plume-org/Plume/issues/94

we could open it as feature request. it's probably somewhat related (orthogonal) to https://github.com/Plume-org/Plume/issues/94
iamdoubz (Migrated from github.com) reviewed 2020-02-02 15:04:19 +00:00
source/installation/proxy/iis.html.md
iamdoubz (Migrated from github.com) commented 2020-02-02 15:04:19 +00:00
Copy link

I’ve thought about this to. I think if you use a subdirectory variable in .env that accepts null and folder names. This sets a variable to all css and js (to be added) and adds correct path to css and js from web on server start. It is similar to adding a meta tag to the html something like <meta name=“suburl” content=“/plume” />

This is how Gitea does it... not that it means anything.

I’ve thought about this to. I think if you use a subdirectory variable in .env that accepts null and folder names. This sets a variable to all css and js (to be added) and adds correct path to css and js from web on server start. It is similar to adding a meta tag to the html something like `<meta name=“suburl” content=“/plume” />` This is how Gitea does it... not that it means anything.
iamdoubz commented 2020-02-02 15:37:26 +00:00 (Migrated from github.com)
Copy link

Made changes per @AnaGelez and @igalic to add Windows install docs.

Made changes per @AnaGelez and @igalic to add Windows install docs.
elegaanz (Migrated from github.com) reviewed 2020-02-03 08:53:51 +00:00
elegaanz (Migrated from github.com) left a comment
Copy link

Just a small comment about paths, otherwise it looks good! Thank you.

Just a small comment about paths, otherwise it looks good! Thank you.
source/installation/config.html.md
elegaanz (Migrated from github.com) commented 2020-02-03 08:52:21 +00:00
Copy link

UNIX paths uses / not \.

UNIX paths uses `/` not `\`.
source/installation/config.html.md
elegaanz (Migrated from github.com) commented 2020-02-03 08:52:50 +00:00
Copy link

This remark is useless, since both use /.

This remark is useless, since both use `/`.
iamdoubz (Migrated from github.com) reviewed 2020-02-03 12:41:58 +00:00
source/installation/config.html.md
iamdoubz (Migrated from github.com) commented 2020-02-03 12:41:58 +00:00
Copy link

Excellent thank you.

Excellent thank you.
iamdoubz commented 2020-02-03 12:43:36 +00:00 (Migrated from github.com)
Copy link

I compiled for Postgres as well. Should I add it to this pull, or make another?

I compiled for Postgres as well. Should I add it to this pull, or make another?
igalic commented 2020-02-03 12:54:38 +00:00 (Migrated from github.com)
Copy link

Should I add it to this pull, or make another?

sure, go ahead

> Should I add it to this pull, or make another? sure, go ahead
iamdoubz (Migrated from github.com) reviewed 2020-02-03 15:38:32 +00:00
source/installation/config.html.md
iamdoubz (Migrated from github.com) commented 2020-02-03 15:38:32 +00:00
Copy link

Fixed.

Fixed.
iamdoubz (Migrated from github.com) reviewed 2020-02-03 15:38:40 +00:00
source/installation/config.html.md
iamdoubz (Migrated from github.com) commented 2020-02-03 15:38:39 +00:00
Copy link

Removed.

Removed.
iamdoubz commented 2020-02-03 15:39:11 +00:00 (Migrated from github.com)
Copy link

Should I add it to this pull, or make another?

sure, go ahead

Added.

I think we're done here? (For now)

> > Should I add it to this pull, or make another? > > sure, go ahead Added. I think we're done here? (For now)
igalic (Migrated from github.com) reviewed 2020-02-03 20:43:59 +00:00
source/installation/config.html.md
igalic (Migrated from github.com) commented 2020-02-03 20:42:33 +00:00
Copy link

i would've assumed that the rust path library normalises the input

i would've assumed that the rust path library normalises the input
iamdoubz (Migrated from github.com) reviewed 2020-02-03 21:20:48 +00:00
source/installation/config.html.md
iamdoubz (Migrated from github.com) commented 2020-02-03 21:20:48 +00:00
Copy link

I thought that as well, but if you do not change them, it will throw error when you go to start plume.

I thought that as well, but if you do not change them, it will throw error when you go to start plume.
elegaanz (Migrated from github.com) approved these changes 2020-02-04 07:07:44 +00:00
elegaanz (Migrated from github.com) left a comment
Copy link

Perfect! Thank you!

Perfect! Thank you!
kiwii referenced this pull request from a commit 2020-07-24 18:05:20 +00:00
Add Windows OS to install docs (#83)
Sign in to join this conversation.
Reviewers
No reviewers
elegaanz
Labels
Clear labels   
bug

Something isn't working

  
dependencies

Pull requests that update a dependency file

  
duplicate

This issue or pull request already exists

  
enhancement

New feature or request

  
good first issue

Good for newcomers

  
help wanted

Extra attention is needed

  
invalid

This doesn't seem right

  
question

Further information is requested

  
wontfix

This will not be worked on

No labels
bug
dependencies
duplicate
enhancement
good first issue
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: plume/documentation#83
No description provided.
Delete branch "plume/documentation:iad_windows"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?