Plume/rocket_i18n
5
0
Fork 0
Code Issues 2 Pull requests Releases Wiki Activity

Upgrade actix, gettext #19

Merged
asonix merged 2 commits from plume/rocket_i18n:asonix/rev-actix into master 2019-09-01 19:19:17 +00:00
Conversation 9 Commits 2 Files changed 4 +38 -47
asonix commented 2019-09-01 18:06:15 +00:00 (Migrated from github.com)
Copy link

Bump actix to 1.0, and gettext to 0.4

Bump actix to 1.0, and gettext to 0.4
elegaanz commented 2019-09-01 19:11:35 +00:00 (Migrated from github.com)
Copy link

Does it make actix the default too?

Does it make actix the default too?
asonix commented 2019-09-01 19:17:22 +00:00 (Migrated from github.com)
Copy link

Yeah it does. I figured it wouldnt be a huge issue if y'all are switching to actix, but it does make the name of the crate, rocket_i18n, a bit confusing

Yeah it does. I figured it wouldnt be a huge issue if y'all are switching to actix, but it does make the name of the crate, rocket_i18n, a bit confusing
elegaanz commented 2019-09-01 19:19:13 +00:00 (Migrated from github.com)
Copy link

I will see if I can rename it to something like web-i18n. Anyway, thanks for the PR!

I will see if I can rename it to something like web-i18n. Anyway, thanks for the PR!
trinity-1686a commented 2019-09-01 19:19:18 +00:00
Owner
Copy link

if framework support is changed, version should probably be bumped to 0.5.0 to mark a breaking change

if framework support is changed, version should probably be bumped to 0.5.0 to mark a breaking change
👍 1
elegaanz commented 2019-09-01 19:19:41 +00:00 (Migrated from github.com)
Copy link

Renaming it should do the job too, right?

Renaming it should do the job too, right?
trinity-1686a commented 2019-09-01 19:20:10 +00:00
Owner
Copy link

I have no idea of how crates io support renaming. Wouldn't it effectively create a totally different crate?

I have no idea of how crates io support renaming. Wouldn't it effectively create a totally different crate?
elegaanz commented 2019-09-01 19:21:26 +00:00 (Migrated from github.com)
Copy link

Probably, yes. But we can probably yank all the other versions of rocket-i18n after that, I and tell people to use web-i18n instead?

Probably, yes. But we can probably yank all the other versions of rocket-i18n after that, I and tell people to use web-i18n instead?
igalic commented 2019-09-02 19:10:56 +00:00 (Migrated from github.com)
Copy link

i'd publish a new crate, and deprecate the old…
(if there was such a process)

Before renaming / republishing it as web-i18n, we should maybe hit up the warp folks that we have a thing that's cool and they want to use add support for their framework too

i'd publish a new crate, and deprecate the old… (if there was such a process) ******* Before renaming / republishing it as `web-i18n`, we should maybe hit up the [warp](https://github.com/seanmonstar/warp) folks that we have a thing that's cool and they want to use add support for their framework too
elegaanz commented 2019-09-02 19:56:48 +00:00 (Migrated from github.com)
Copy link

And tide too… and gotham… and…

(more seriously, feel free to do so, but I won't add support for warp myself)

And tide too… and gotham… and… (more seriously, feel free to do so, but I won't add support for warp myself)
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug

Something isn't working

  
duplicate

This issue or pull request already exists

  
enhancement

New feature or request

  
good first issue

Good for newcomers

  
help wanted

Extra attention is needed

  
invalid

This doesn't seem right

  
question

Further information is requested

  
wontfix

This will not be worked on

No labels
bug
duplicate
enhancement
good first issue
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: plume/rocket_i18n#19
No description provided.
Delete branch "plume/rocket_i18n:asonix/rev-actix"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?