Upgrade actix, gettext #19

Merged
asonix merged 2 commits from plume/rocket_i18n:asonix/rev-actix into master 3 years ago
asonix commented 3 years ago (Migrated from github.com)
Owner

Bump actix to 1.0, and gettext to 0.4

Bump actix to 1.0, and gettext to 0.4
elegaanz commented 3 years ago (Migrated from github.com)
Owner

Does it make actix the default too?

Does it make actix the default too?
asonix commented 3 years ago (Migrated from github.com)
Poster
Owner

Yeah it does. I figured it wouldnt be a huge issue if y'all are switching to actix, but it does make the name of the crate, rocket_i18n, a bit confusing

Yeah it does. I figured it wouldnt be a huge issue if y'all are switching to actix, but it does make the name of the crate, rocket_i18n, a bit confusing
elegaanz commented 3 years ago (Migrated from github.com)
Owner

I will see if I can rename it to something like web-i18n. Anyway, thanks for the PR!

I will see if I can rename it to something like web-i18n. Anyway, thanks for the PR!

if framework support is changed, version should probably be bumped to 0.5.0 to mark a breaking change

if framework support is changed, version should probably be bumped to 0.5.0 to mark a breaking change
elegaanz commented 3 years ago (Migrated from github.com)
Owner

Renaming it should do the job too, right?

Renaming it should do the job too, right?

I have no idea of how crates io support renaming. Wouldn't it effectively create a totally different crate?

I have no idea of how crates io support renaming. Wouldn't it effectively create a totally different crate?
elegaanz commented 3 years ago (Migrated from github.com)
Owner

Probably, yes. But we can probably yank all the other versions of rocket-i18n after that, I and tell people to use web-i18n instead?

Probably, yes. But we can probably yank all the other versions of rocket-i18n after that, I and tell people to use web-i18n instead?
igalic commented 3 years ago (Migrated from github.com)
Owner

i'd publish a new crate, and deprecate the old…
(if there was such a process)


Before renaming / republishing it as web-i18n, we should maybe hit up the warp folks that we have a thing that's cool and they want to use add support for their framework too

i'd publish a new crate, and deprecate the old… (if there was such a process) ******* Before renaming / republishing it as `web-i18n`, we should maybe hit up the [warp](https://github.com/seanmonstar/warp) folks that we have a thing that's cool and they want to use add support for their framework too
elegaanz commented 3 years ago (Migrated from github.com)
Owner

And tide too… and gotham… and…

(more seriously, feel free to do so, but I won't add support for warp myself)

And tide too… and gotham… and… (more seriously, feel free to do so, but I won't add support for warp myself)
The pull request has been merged as 3eca920593.
Sign in to join this conversation.
No reviewers
No Milestone
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

Loading…
There is no content yet.