Update deps + asyncify fetching #9

Merged
elegaanz merged 1 commits from plume/webfinger:update-deps into main 4 years ago
elegaanz commented 4 years ago (Migrated from github.com)

Fixes #8

Fixes #8
codecov[bot] commented 4 years ago (Migrated from github.com)

Codecov Report

Merging #9 into main will increase coverage by 0.43%.
The diff coverage is 76.92%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main       #9      +/-   ##
==========================================
+ Coverage   90.13%   90.56%   +0.43%     
==========================================
  Files           2        2              
  Lines         152      159       +7     
==========================================
+ Hits          137      144       +7     
  Misses         15       15
Impacted Files Coverage Δ
src/tests.rs 94.31% <100%> (+1.37%) ⬆️
src/lib.rs 85.91% <57.14%> (-0.66%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ecb8a18...cdaab95. Read the comment docs.

# [Codecov](https://codecov.io/gh/Plume-org/webfinger/pull/9?src=pr&el=h1) Report > Merging [#9](https://codecov.io/gh/Plume-org/webfinger/pull/9?src=pr&el=desc) into [main](https://codecov.io/gh/Plume-org/webfinger/commit/ecb8a183bf4d45d99e074e76a0b0568734106a2c?src=pr&el=desc) will **increase** coverage by `0.43%`. > The diff coverage is `76.92%`. [![Impacted file tree graph](https://codecov.io/gh/Plume-org/webfinger/pull/9/graphs/tree.svg?width=650&token=9gTr9Sg00C&height=150&src=pr)](https://codecov.io/gh/Plume-org/webfinger/pull/9?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## main #9 +/- ## ========================================== + Coverage 90.13% 90.56% +0.43% ========================================== Files 2 2 Lines 152 159 +7 ========================================== + Hits 137 144 +7 Misses 15 15 ``` | [Impacted Files](https://codecov.io/gh/Plume-org/webfinger/pull/9?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [src/tests.rs](https://codecov.io/gh/Plume-org/webfinger/pull/9/diff?src=pr&el=tree#diff-c3JjL3Rlc3RzLnJz) | `94.31% <100%> (+1.37%)` | :arrow_up: | | [src/lib.rs](https://codecov.io/gh/Plume-org/webfinger/pull/9/diff?src=pr&el=tree#diff-c3JjL2xpYi5ycw==) | `85.91% <57.14%> (-0.66%)` | :arrow_down: | ------ [Continue to review full report at Codecov](https://codecov.io/gh/Plume-org/webfinger/pull/9?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/Plume-org/webfinger/pull/9?src=pr&el=footer). Last update [ecb8a18...cdaab95](https://codecov.io/gh/Plume-org/webfinger/pull/9?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
igalic commented 4 years ago (Migrated from github.com)

testing now, so far,

meena@76ix ~/s/a/plume (go/async) [101]> cargo update --package webfinger
    Updating crates.io index
    Updating git repository `https://github.com/Plume-org/webfinger`
    Removing bytes v0.4.12
    Removing cookie v0.12.0
    Removing cookie_store v0.7.0
    Removing crossbeam-deque v0.7.2
    Removing crossbeam-epoch v0.8.0
    Removing crossbeam-queue v0.1.2
    Removing crossbeam-utils v0.7.0
    Removing h2 v0.1.26
    Removing http v0.1.21
    Removing http-body v0.1.0
    Removing hyper v0.12.35
    Removing hyper-tls v0.3.2
    Removing publicsuffix v1.5.4
    Removing reqwest v0.9.24
    Removing serde_urlencoded v0.5.5
    Removing string v0.2.1
    Removing tokio v0.1.22
    Removing tokio-buf v0.1.1
    Removing tokio-current-thread v0.1.6
    Removing tokio-executor v0.1.9
    Removing tokio-io v0.1.12
    Removing tokio-reactor v0.1.11
    Removing tokio-sync v0.1.7
    Removing tokio-tcp v0.1.3
    Removing tokio-threadpool v0.1.17
    Removing tokio-timer v0.2.12
    Removing try_from v0.3.2
    Removing want v0.2.0
      Adding webfinger v0.5.0 (https://github.com/Plume-org/webfinger?rev=update-deps#cdaab95e)
    Removing webfinger v0.5.0
meena@76ix ~/s/a/plume (go/async)>

it looks extremely worth it 😁

testing now, so far, ``` meena@76ix ~/s/a/plume (go/async) [101]> cargo update --package webfinger Updating crates.io index Updating git repository `https://github.com/Plume-org/webfinger` Removing bytes v0.4.12 Removing cookie v0.12.0 Removing cookie_store v0.7.0 Removing crossbeam-deque v0.7.2 Removing crossbeam-epoch v0.8.0 Removing crossbeam-queue v0.1.2 Removing crossbeam-utils v0.7.0 Removing h2 v0.1.26 Removing http v0.1.21 Removing http-body v0.1.0 Removing hyper v0.12.35 Removing hyper-tls v0.3.2 Removing publicsuffix v1.5.4 Removing reqwest v0.9.24 Removing serde_urlencoded v0.5.5 Removing string v0.2.1 Removing tokio v0.1.22 Removing tokio-buf v0.1.1 Removing tokio-current-thread v0.1.6 Removing tokio-executor v0.1.9 Removing tokio-io v0.1.12 Removing tokio-reactor v0.1.11 Removing tokio-sync v0.1.7 Removing tokio-tcp v0.1.3 Removing tokio-threadpool v0.1.17 Removing tokio-timer v0.2.12 Removing try_from v0.3.2 Removing want v0.2.0 Adding webfinger v0.5.0 (https://github.com/Plume-org/webfinger?rev=update-deps#cdaab95e) Removing webfinger v0.5.0 meena@76ix ~/s/a/plume (go/async)> ``` it looks extremely worth it :grin:
igalic commented 4 years ago (Migrated from github.com)

should we merge this as a basis for making Webfinger (optionally?) async itself?

should we merge this as a basis for making Webfinger (optionally?) async itself?
igalic (Migrated from github.com) approved these changes 4 years ago
igalic (Migrated from github.com) left a comment

👍

:+1:

Reviewers

The pull request has been merged as c49467766c.
You can also view command line instructions.

Step 1:

From your project repository, check out a new branch and test the changes.
git checkout -b update-deps main
git pull origin update-deps

Step 2:

Merge the changes and update on Forgejo.
git checkout main
git merge --no-ff update-deps
git push origin main
Sign in to join this conversation.
No reviewers
No Milestone
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: plume/webfinger#9
Loading…
There is no content yet.