New Issue

Underline links #140

Closed

opened by elegaanz · 1 comments

elegaanz commented (Migrated from github.com)

In the articles, to make it clear they are links. Maybe we can also underline them in other places, but only when the cursor is over them.

bitkeks commented (Migrated from github.com)

The solution in a82cccf feels pretty hacky.
I tried injecting the icon into the Markdown parser in b1c1ba151d/plume-common/src/utils.rs (L27-L29)

by using another match like below. But this doesn't manipulate the link, only the title text 🤦‍♂️

Event::Start(tag) => {
    let tag = match tag {
        Tag::Link(url, title) => {
            let appended_icon: &str = "<i class=\"fas fa-external-link-alt\"></i>";
            Tag::Link(url, title + appended_icon)
        },
        _ => tag
    };
    ...
}

The solution in a82cccf feels pretty hacky. I tried injecting the icon into the Markdown parser in https://github.com/Plume-org/Plume/blob/b1c1ba151dcd84ef18d5d05be50a848dafef0abe/plume-common/src/utils.rs#L27-L29 by using another `match` like below. But this doesn't manipulate the link, only the title text :man_facepalming: ```rust Event::Start(tag) => { let tag = match tag { Tag::Link(url, title) => { let appended_icon: &str = "<i class=\"fas fa-external-link-alt\"></i>"; Tag::Link(url, title + appended_icon) }, _ => tag }; ... } ```

No Milestone

No Assignees

1 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Loading…

There is no content yet.

Labels Milestones

Underline links #140