Add link underline for main body; add link icon
#175
Closed
bitkeks wants to merge 2 commits from feature/underlined_links
into master
pull from: feature/underlined_links
merge into: Plume:master
Plume:paginate-search-init
Plume:main
Plume:s3
Plume:fix-delete-user
Plume:timeline-cli
Plume:blog-title
Plume:signature
Plume:remove-dup-images
Plume:ldap-non-anon
Plume:drone-ci
Plume:DearRude/force-lang
Plume:igalic/go/async-all-mut
Plume:go/async
Plume:floreal/translations-update
Plume:missing-docs
Plume:RAOF/fix-arm64-build
Plume:epsilon-phase/authorized-fetch
Plume:upgrade
Plume:improve-the-editor-once-again
Plume:igalic/feat/custom-fairing-domains
Plume:feature/ldap
Plume:test/dotenv_error
Plume:fix-mobile-margin
Reviewers
Request review
No reviewers
Labels
Clear labels
Related to the REST API
Code running on the server
Stuff related to Federation
Related to the front-end
Translations, and related code
More about project management or code than the project itself
The building, or installation process of Plume
Something isn't working
We need to talk
New feature or request
This is a new feature
Compatibility with different browsers, readers and OS
Related to an external package that Plume uses
UI/UX related issues and PRs
Good for newcomers
Extra attention is needed
Issues affecting only mobile UX
How elements're rendered out for the end user
Something else needs to be fixed first
This issue or pull request already exists
This PR is not complete yet
Issues concern a limited number of instances
This doesn't seem right
Need to be discussed by the community (on Loomio)
This PR is ready to be reviewed
Proposed ideas worth considering
This is issue has been created after a vote on Loomio
This will not be worked on
Apply labels
A: API
Related to the REST API
A: Backend
Code running on the server
A: Federation
Stuff related to Federation
A: Front-End
Related to the front-end
A: I18N
Translations, and related code
A: Meta
More about project management or code than the project itself
A: Security
Build
The building, or installation process of Plume
C: Bug
Something isn't working
C: Discussion
We need to talk
C: Enhancement
New feature or request
C: Feature
This is a new feature
Compatibility
Compatibility with different browsers, readers and OS
Dependency
Related to an external package that Plume uses
Design
UI/UX related issues and PRs
Documentation
Good first issue
Good for newcomers
Help welcome
Extra attention is needed
Mobile
Issues affecting only mobile UX
Rendering
How elements're rendered out for the end user
S: Blocked
Something else needs to be fixed first
S: Duplicate
This issue or pull request already exists
S: Incomplete
This PR is not complete yet
S: Instance specific
Issues concern a limited number of instances
S: Invalid
This doesn't seem right
S: Needs Voting/Discussion
Need to be discussed by the community (on Loomio)
S: Ready for review
This PR is ready to be reviewed
Suggestion
Proposed ideas worth considering
S: Voted on Loomio
This is issue has been created after a vote on Loomio
S: Wontfix
This will not be worked on
No Label
A: API
A: Backend
A: Federation
A: Front-End
A: I18N
A: Meta
A: Security
Build
C: Bug
C: Discussion
C: Enhancement
C: Feature
Compatibility
Dependency
Design
Documentation
Good first issue
Help welcome
Mobile
Rendering
S: Blocked
S: Duplicate
S: Incomplete
S: Instance specific
S: Invalid
S: Needs Voting/Discussion
S: Ready for review
Suggestion
S: Voted on Loomio
S: Wontfix
Milestone
Set milestone
Clear milestone
No items
No Milestone
Assignees
Assign users
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.
No due date set.
Dependencies
No dependencies set.
Reference: Plume/Plume#175
Reference in New Issue
There is no content yet.
Delete Branch 'feature/underlined_links'
Deleting a branch is permanent. It CANNOT be undone. Continue?
No
Yes
Links in the main body part are now underlined on mouse hover.
tags in the article content are expanded by an icon from
FontAwesome.
Fixes #140
I have two little remarks:
Otherwise, it looks good. 👍
Adding an icon next to a link can be done in CSS only, so I don't see the point of injecting an icon in the markdown parser, or do I misunderstand something?
No other than enhanced visibility!
My editor shows me tab characters, with a width of 8 spaces?
Yeah, might be the best solution if any icons should be used. The injection was a fix to use the FontAwesome icon, I didn't find a CSS-only solution.
Looks good! (but there are conflicts now 😑)
For the CSS only solution, I think something with
::after
andcontent
should be possible.Yes, if you look on the FontAwesome website, it indicates the character used for a specific icon. Then you just have to apply the FontAwesome font to this (look into the FontAwesome css file if you want, there is an example of how you can do this! :-))
Should I make a PR with an icon next to the links?
@Madeorsk I don't think it is really useful, it is more bloating the interface and making the text harder to read than anything else IMHO.
@bitkeks Hello! Do you plan to fix the conflicts? It's OK if you don't want, but tell us, so that we can close this PR and make it clear nobody is working on this issue anymore. 🙂
If needed, I have what I think is a successful rebase to master here
Sorry people, this issue must have been gone under the radar..
Feel free to close this one and merge from @fdb-hiroshima, I'm not sure if I have enough time to cleanly resolve the conflicts to current master. 🙂
Ok, thanks for keeping us informed. 🙂
Reviewers
Step 1:
From your project repository, check out a new branch and test the changes.Step 2:
Merge the changes and update on Forgejo.