Make Plume compile on release #365

trinity-1686a · 2018-12-19T00:03:00Z

trinity-1686a commented

2018-12-19 00:03:00 +00:00

Remove use of String for body parameters
Create SignedJson and implement FromData for it

Fix #328

Remove use of String for body parameters Create SignedJson and implement FromData for it Fix #328

codecov[bot] commented

2018-12-19 00:29:29 +00:00

(Migrated from github.com)

Codecov Report

Merging #365 into master will increase coverage by 0.53%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master     #365      +/-   ##
==========================================
+ Coverage    28.2%   28.73%   +0.53%     
==========================================
  Files          62       62              
  Lines        6578     5658     -920     
==========================================
- Hits         1855     1626     -229     
+ Misses       4723     4032     -691

# [Codecov](https://codecov.io/gh/Plume-org/Plume/pull/365?src=pr&el=h1) Report > Merging [#365](https://codecov.io/gh/Plume-org/Plume/pull/365?src=pr&el=desc) into [master](https://codecov.io/gh/Plume-org/Plume/commit/ce083464872f012b89f997db783493cdea3f8ed7?src=pr&el=desc) will **increase** coverage by `0.53%`. > The diff coverage is `0%`. ```diff @@ Coverage Diff @@ ## master #365 +/- ## ========================================== + Coverage 28.2% 28.73% +0.53% ========================================== Files 62 62 Lines 6578 5658 -920 ========================================== - Hits 1855 1626 -229 + Misses 4723 4032 -691 ```

igalic (Migrated from github.com) reviewed 2018-12-19 07:49:57 +00:00

igalic (Migrated from github.com) left a comment

just 👀

plume-common/src/activity_pub/request.rs

					
				@ -44,1 +45,4 @@

				        self.value()==other.value()

				    }

				    pub fn algorithm(&self) -> &str {

igalic (Migrated from github.com) commented

2018-12-19 07:37:24 +00:00

i just realised we have a lot of public functions here, but don't document any

trinity-1686a reviewed 2018-12-19 10:32:42 +00:00

plume-common/src/activity_pub/request.rs

					
				@ -44,1 +45,4 @@

				        self.value()==other.value()

				    }

				    pub fn algorithm(&self) -> &str {

trinity-1686a commented

2018-12-19 10:32:42 +00:00

Yes, we should do it. Also we should probably use https://git.asonix.dog/asonix/http-signatures instead of rolling our own code

igalic commented

2018-12-19 13:28:23 +00:00

(Migrated from github.com)

we should also expand our .travis.yml to (test) build release

we should also expand our .travis.yml to (test) build `release`

trinity-1686a commented

2018-12-19 13:33:53 +00:00

Maybe we should just test in release, that's what peoples will use anyway

igalic commented

2018-12-19 14:01:34 +00:00

(Migrated from github.com)

except for us developers, so, yeah, 👍

trinity-1686a commented

2018-12-19 15:25:37 +00:00

I should also update install instructions
Edit: actually documentation already use release, no wonder people where asking for help with installation

I should also update install instructions Edit: actually documentation already use release, no wonder people where asking for help with installation

trinity-1686a commented

2018-12-19 16:22:57 +00:00

Oops I broke code coverage even more I think
Can't complain about low coverage if you don't upload any coverage report 🙃

Oops I broke code coverage even more I think Can't complain about low coverage if you don't upload any coverage report :upside_down_face:

marek-lach commented

2018-12-22 14:59:30 +00:00

(Migrated from github.com)

Just posting this here, as it might be relevant for this pull request:

https://mstdn.nipponalba.scot/@jk/101279615979810008

Just posting this here, as it might be relevant for this pull request: https://mstdn.nipponalba.scot/@jk/101279615979810008

elegaanz commented

2018-12-22 15:20:47 +00:00

(Migrated from github.com)

@marek-lach Thanks! It is indeed related. I responded them.

elegaanz (Migrated from github.com) approved these changes 2018-12-22 16:38:36 +00:00

elegaanz (Migrated from github.com) left a comment

Thanks!

Sign in to join this conversation.

No reviewers

elegaanz

No milestone

No project

No assignees

2 participants

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Plume/Plume#365