Corrected grammar pointed out by translators #514

Merged
marek-lach merged 7 commits from Corrected-grammar-pointed-out-by-translators into master 5 years ago
marek-lach commented 5 years ago (Migrated from github.com)

The user 'UniqueActive' pointed these issues out on Crowdin.

Thank you!

The user 'UniqueActive' pointed these issues out on Crowdin. Thank you!
elegaanz (Migrated from github.com) reviewed 5 years ago
elegaanz (Migrated from github.com) left a comment

Thank you for that, I wanted to do it too, but you beat me to it. 😀

Also they saw a ' that shouldn't be here in templates/users/followed.rs.html IIRC, could you please remove it?

Thank you for that, I wanted to do it too, but you beat me to it. :grinning: Also they saw a `'` that shouldn't be here in templates/users/followed.rs.html IIRC, could you please remove it?
elegaanz (Migrated from github.com) commented 5 years ago

I would have preferred to use "people" for both, it feels more like they are real human beings than "users" IMO.

I would have preferred to use "people" for both, it feels more like they are real human beings than "users" IMO.
marek-lach (Migrated from github.com) reviewed 5 years ago
marek-lach (Migrated from github.com) commented 5 years ago

Right. Done :-)

Right. Done :-)
marek-lach commented 5 years ago (Migrated from github.com)

Also they saw a ' that shouldn't be here in templates/users/followed.rs.html IIRC, could you please remove it?

Yup.

> Also they saw a `'` that shouldn't be here in templates/users/followed.rs.html IIRC, could you please remove it? Yup.
igalic (Migrated from github.com) reviewed 5 years ago
@ -15,3 +15,3 @@
<div>
<p>@Html(i18n!(ctx.1, "Home to <em>{0}</em> users"; n_users))</p>
<p>@Html(i18n!(ctx.1, "Home to <em>{0}</em> people"; n_users))</p>
</div>
igalic (Migrated from github.com) commented 5 years ago

👍

would be easier to remember if n_users was n_people

👍 would be easier to remember if `n_users` was `n_people`
marek-lach (Migrated from github.com) reviewed 5 years ago
@ -15,3 +15,3 @@
<div>
<p>@Html(i18n!(ctx.1, "Home to <em>{0}</em> users"; n_users))</p>
<p>@Html(i18n!(ctx.1, "Home to <em>{0}</em> people"; n_users))</p>
</div>
marek-lach (Migrated from github.com) commented 5 years ago

It's honestly not a big problem. I think from a programmer's perspective, having the declaration as users is easier to understand in code maybe?

It's honestly not a big problem. I think from a programmer's perspective, having the declaration as `users` is easier to understand in code maybe?
igalic (Migrated from github.com) reviewed 5 years ago
@ -15,3 +15,3 @@
<div>
<p>@Html(i18n!(ctx.1, "Home to <em>{0}</em> users"; n_users))</p>
<p>@Html(i18n!(ctx.1, "Home to <em>{0}</em> people"; n_users))</p>
</div>
igalic (Migrated from github.com) commented 5 years ago

true, true…

true, true…
elegaanz (Migrated from github.com) approved these changes 5 years ago
elegaanz (Migrated from github.com) left a comment

Looks good. Thank you!

Looks good. Thank you!

Reviewers

The pull request has been merged as 38701c8a40.
You can also view command line instructions.

Step 1:

From your project repository, check out a new branch and test the changes.
git checkout -b Corrected-grammar-pointed-out-by-translators master
git pull origin Corrected-grammar-pointed-out-by-translators

Step 2:

Merge the changes and update on Forgejo.
git checkout master
git merge --no-ff Corrected-grammar-pointed-out-by-translators
git push origin master
Sign in to join this conversation.
No reviewers
No Milestone
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Plume/Plume#514
Loading…
There is no content yet.