Plume/Plume
9
18
Fork 24
Code Issues 177 Pull requests 9 Releases 8 Wiki Activity

Corrected grammar pointed out by translators #514

Merged
marek-lach merged 7 commits from Corrected-grammar-pointed-out-by-translators into master 2019-04-04 19:06:38 +00:00
Conversation 1 Commits 7 Files changed 5 +5 -5
marek-lach commented 2019-04-03 19:13:43 +00:00 (Migrated from github.com)
Copy link

The user 'UniqueActive' pointed these issues out on Crowdin.

Thank you!

The user 'UniqueActive' pointed these issues out on Crowdin. Thank you!
elegaanz (Migrated from github.com) reviewed 2019-04-03 20:52:05 +00:00
elegaanz (Migrated from github.com) left a comment
Copy link

Thank you for that, I wanted to do it too, but you beat me to it. 😀

Also they saw a ' that shouldn't be here in templates/users/followed.rs.html IIRC, could you please remove it?

Thank you for that, I wanted to do it too, but you beat me to it. :grinning: Also they saw a `'` that shouldn't be here in templates/users/followed.rs.html IIRC, could you please remove it?
templates/partials/instance_description.rs.html
elegaanz (Migrated from github.com) commented 2019-04-03 20:50:24 +00:00
Copy link

I would have preferred to use "people" for both, it feels more like they are real human beings than "users" IMO.

I would have preferred to use "people" for both, it feels more like they are real human beings than "users" IMO.
marek-lach (Migrated from github.com) reviewed 2019-04-03 21:58:09 +00:00
templates/partials/instance_description.rs.html
marek-lach (Migrated from github.com) commented 2019-04-03 21:58:08 +00:00
Copy link

Right. Done :-)

Right. Done :-)
marek-lach commented 2019-04-03 22:00:27 +00:00 (Migrated from github.com)
Copy link

Also they saw a ' that shouldn't be here in templates/users/followed.rs.html IIRC, could you please remove it?

Yup.

> Also they saw a `'` that shouldn't be here in templates/users/followed.rs.html IIRC, could you please remove it? Yup.
👍 1
igalic (Migrated from github.com) reviewed 2019-04-04 09:51:13 +00:00
templates/instance/about.rs.html
@ -15,3 +15,3 @@
<div>
<p>@Html(i18n!(ctx.1, "Home to <em>{0}</em> users"; n_users))</p>
<p>@Html(i18n!(ctx.1, "Home to <em>{0}</em> people"; n_users))</p>
</div>
igalic (Migrated from github.com) commented 2019-04-04 09:50:07 +00:00
Copy link

👍

would be easier to remember if n_users was n_people

👍 would be easier to remember if `n_users` was `n_people`
marek-lach (Migrated from github.com) reviewed 2019-04-04 10:33:51 +00:00
templates/instance/about.rs.html
@ -15,3 +15,3 @@
<div>
<p>@Html(i18n!(ctx.1, "Home to <em>{0}</em> users"; n_users))</p>
<p>@Html(i18n!(ctx.1, "Home to <em>{0}</em> people"; n_users))</p>
</div>
marek-lach (Migrated from github.com) commented 2019-04-04 10:33:50 +00:00
Copy link

It's honestly not a big problem. I think from a programmer's perspective, having the declaration as users is easier to understand in code maybe?

It's honestly not a big problem. I think from a programmer's perspective, having the declaration as `users` is easier to understand in code maybe?
igalic (Migrated from github.com) reviewed 2019-04-04 13:18:36 +00:00
templates/instance/about.rs.html
@ -15,3 +15,3 @@
<div>
<p>@Html(i18n!(ctx.1, "Home to <em>{0}</em> users"; n_users))</p>
<p>@Html(i18n!(ctx.1, "Home to <em>{0}</em> people"; n_users))</p>
</div>
igalic (Migrated from github.com) commented 2019-04-04 13:18:36 +00:00
Copy link

true, true…

true, true…
elegaanz (Migrated from github.com) approved these changes 2019-04-04 19:06:16 +00:00
elegaanz (Migrated from github.com) left a comment
Copy link

Looks good. Thank you!

Looks good. Thank you!
Sign in to join this conversation.
Reviewers
No reviewers
elegaanz
Labels
Clear labels   
A: API

Related to the REST API

  
A: Backend

Code running on the server

  
A: Federation

Stuff related to Federation

  
A: Front-End

Related to the front-end

  
A: I18N

Translations, and related code

  
A: Meta

More about project management or code than the project itself

  
A: Security

   
Build

The building, or installation process of Plume

  
C: Bug

Something isn't working

  
C: Discussion

We need to talk

  
C: Enhancement

New feature or request

  
C: Feature

This is a new feature

  
Compatibility

Compatibility with different browsers, readers and OS

  
Dependency

Related to an external package that Plume uses

  
Design

UI/UX related issues and PRs

  
Documentation

   
Good first issue

Good for newcomers

  
Help welcome

Extra attention is needed

  
Mobile

Issues affecting only mobile UX

  
Rendering

How elements're rendered out for the end user

  
S: Blocked

Something else needs to be fixed first

  
S: Duplicate

This issue or pull request already exists

  
S: Incomplete

This PR is not complete yet

  
S: Instance specific

Issues concern a limited number of instances

  
S: Invalid

This doesn't seem right

  
S: Needs Voting/Discussion

Need to be discussed by the community (on Loomio)

  
S: Ready for review

This PR is ready to be reviewed

  
Suggestion

Proposed ideas worth considering

  
S: Voted on Loomio

This is issue has been created after a vote on Loomio

  
S: Wontfix

This will not be worked on

No labels
A: API
A: Backend
A: Federation
A: Front-End
A: I18N
A: Meta
A: Security
Build
C: Bug
C: Discussion
C: Enhancement
C: Feature
Compatibility
Dependency
Design
Documentation
Good first issue
Help welcome
Mobile
Rendering
S: Blocked
S: Duplicate
S: Incomplete
S: Instance specific
S: Invalid
S: Needs Voting/Discussion
S: Ready for review
Suggestion
S: Voted on Loomio
S: Wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Plume/Plume#514
No description provided.
Delete branch "Corrected-grammar-pointed-out-by-translators"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?