#514 Corrected grammar pointed out by translators

Merged
marek-lach merged 7 commits from Corrected-grammar-pointed-out-by-translators into master 1 year ago
marek-lach commented 1 year ago (Migrated from github.com)

The user ‘UniqueActive’ pointed these issues out on Crowdin.

Thank you!

The user 'UniqueActive' pointed these issues out on Crowdin. Thank you!
elegaanz (Migrated from github.com) reviewed 1 year ago
elegaanz (Migrated from github.com) left a comment

Thank you for that, I wanted to do it too, but you beat me to it. 😀

Also they saw a ' that shouldn’t be here in templates/users/followed.rs.html IIRC, could you please remove it?

Plume_migration_agent commented 1 year ago

I would have preferred to use “people” for both, it feels more like they are real human beings than “users” IMO.

I would have preferred to use "people" for both, it feels more like they are real human beings than "users" IMO.
marek-lach (Migrated from github.com) reviewed 1 year ago
marek-lach commented 1 year ago (Migrated from github.com)
Owner

Also they saw a ' that shouldn’t be here in templates/users/followed.rs.html IIRC, could you please remove it?

Yup.

> Also they saw a `'` that shouldn't be here in templates/users/followed.rs.html IIRC, could you please remove it? Yup.
igalic (Migrated from github.com) reviewed 1 year ago
@@ -15,3 +15,3 @@
<div>
<p>@Html(i18n!(ctx.1, "Home to <em>{0}</em> users"; n_users))</p>
<p>@Html(i18n!(ctx.1, "Home to <em>{0}</em> people"; n_users))</p>
</div>
Plume_migration_agent commented 1 year ago

👍

would be easier to remember if n_users was n_people

👍 would be easier to remember if `n_users` was `n_people`
marek-lach (Migrated from github.com) reviewed 1 year ago
@@ -15,3 +15,3 @@
<div>
<p>@Html(i18n!(ctx.1, "Home to <em>{0}</em> users"; n_users))</p>
<p>@Html(i18n!(ctx.1, "Home to <em>{0}</em> people"; n_users))</p>
</div>
Plume_migration_agent commented 1 year ago

It’s honestly not a big problem. I think from a programmer’s perspective, having the declaration as users is easier to understand in code maybe?

It's honestly not a big problem. I think from a programmer's perspective, having the declaration as `users` is easier to understand in code maybe?
igalic (Migrated from github.com) reviewed 1 year ago
@@ -15,3 +15,3 @@
<div>
<p>@Html(i18n!(ctx.1, "Home to <em>{0}</em> users"; n_users))</p>
<p>@Html(i18n!(ctx.1, "Home to <em>{0}</em> people"; n_users))</p>
</div>
Plume_migration_agent commented 1 year ago

true, true…

true, true…
elegaanz (Migrated from github.com) approved these changes 1 year ago
elegaanz (Migrated from github.com) left a comment

Looks good. Thank you!

Reviewers

Plume_migration_agent approved these changes 1 year ago
The pull request has been merged as 38701c8a40.
Sign in to join this conversation.
No Milestone
No Assignees
1 Participants
Notifications
Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

Loading…
There is no content yet.