use openssl instead of sha256sum for build.rs #568

Merged

Plume_migration_agent merged 2 commits from openssl into master

trinity-1686a commented

Owner

fix #566

igalic (Migrated from github.com) reviewed

igalic (Migrated from github.com) left a comment

👀

build.rs

igalic (Migrated from github.com) commented

i'd prefer we leave stat(1) out of this, as the --printf option is not platform independent, and no equivalent, platform independent option exists

the only other would be to use -c

i'd prefer we leave `stat(1)` out of this, as the `--printf` option is not platform independent, and no equivalent, platform independent option exists the only other would be to use `-c`

trinity-1686a reviewed

build.rs

trinity-1686a commented

Poster

Owner

The goal of this function is to have a unique id, and best effort is made to not invalidate cache if not necessary. We can also not make that best effort (recompiling Plume => new cache id) and just generate a random hex string. That would be platform independent.
What shall I do?

codecov[bot] commented (Migrated from github.com)

Codecov Report

Merging #568 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #568   +/-   ##
=======================================
  Coverage   35.06%   35.06%           
=======================================
  Files          67       67           
  Lines        7851     7851           
  Branches     1886     1886           
=======================================
  Hits         2753     2753           
  Misses       4336     4336           
  Partials      762      762

# [Codecov](https://codecov.io/gh/Plume-org/Plume/pull/568?src=pr&el=h1) Report > Merging [#568](https://codecov.io/gh/Plume-org/Plume/pull/568?src=pr&el=desc) into [master](https://codecov.io/gh/Plume-org/Plume/commit/33619abdfbe1845f56d283265bae2e3e68ad0485?src=pr&el=desc) will **not change** coverage. > The diff coverage is `n/a`. ```diff @@ Coverage Diff @@ ## master #568 +/- ## ======================================= Coverage 35.06% 35.06% ======================================= Files 67 67 Lines 7851 7851 Branches 1886 1886 ======================================= Hits 2753 2753 Misses 4336 4336 Partials 762 762 ```

igalic (Migrated from github.com) reviewed

build.rs

igalic (Migrated from github.com) commented

i think i'd just go with stat -c for now

there's not a big chance we'll be building on windows… easily… i think, so let's just go with this.

i think i'd just go with `stat -c` for now there's not a big chance we'll be building on windows… easily… i think, so let's just go with this.

igalic (Migrated from github.com) approved these changes

igalic (Migrated from github.com) left a comment

tested, works!

Reviewers

The pull request has been merged as 5b50f90d2b.

You can also view command line instructions.

Step 1:

From your project repository, check out a new branch and test the changes.

git checkout -b openssl master

git pull origin openssl

Step 2:

Merge the changes and update on Forgejo.

git checkout master

git merge --no-ff openssl

git push origin master

No reviewers

No Milestone

No Assignees

2 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Loading…

There is no content yet.

Labels Milestones

use openssl instead of sha256sum for build.rs #568

Codecov Report

Reviewers

Step 1:

Step 2: