Add RTL support (BIDI)
#575
Closed
opened 5 years ago by ahangarha
·
8 comments
No Branch/Tag Specified
paginate-search-init
main
s3
fix-delete-user
timeline-cli
blog-title
signature
remove-dup-images
ldap-non-anon
drone-ci
DearRude/force-lang
igalic/go/async-all-mut
go/async
floreal/translations-update
missing-docs
RAOF/fix-arm64-build
epsilon-phase/authorized-fetch
upgrade
improve-the-editor-once-again
igalic/feat/custom-fairing-domains
feature/ldap
test/dotenv_error
fix-mobile-margin
0.7.2
0.7.0
0.2.0-alpha-1
0.3.0-alpha-2
0.4.0-alpha-4
0.5.0
0.6.0
0.7.1
Labels
Clear labels
Related to the REST API
Code running on the server
Stuff related to Federation
Related to the front-end
Translations, and related code
More about project management or code than the project itself
The building, or installation process of Plume
Something isn't working
We need to talk
New feature or request
This is a new feature
Compatibility with different browsers, readers and OS
Related to an external package that Plume uses
UI/UX related issues and PRs
Good for newcomers
Extra attention is needed
Issues affecting only mobile UX
How elements're rendered out for the end user
Something else needs to be fixed first
This issue or pull request already exists
This PR is not complete yet
Issues concern a limited number of instances
This doesn't seem right
Need to be discussed by the community (on Loomio)
This PR is ready to be reviewed
Proposed ideas worth considering
This is issue has been created after a vote on Loomio
This will not be worked on
Apply labels
A: API
Related to the REST API
A: Backend
Code running on the server
A: Federation
Stuff related to Federation
A: Front-End
Related to the front-end
A: I18N
Translations, and related code
A: Meta
More about project management or code than the project itself
A: Security
Build
The building, or installation process of Plume
C: Bug
Something isn't working
C: Discussion
We need to talk
C: Enhancement
New feature or request
C: Feature
This is a new feature
Compatibility
Compatibility with different browsers, readers and OS
Dependency
Related to an external package that Plume uses
Design
UI/UX related issues and PRs
Documentation
Good first issue
Good for newcomers
Help welcome
Extra attention is needed
Mobile
Issues affecting only mobile UX
Rendering
How elements're rendered out for the end user
S: Blocked
Something else needs to be fixed first
S: Duplicate
This issue or pull request already exists
S: Incomplete
This PR is not complete yet
S: Instance specific
Issues concern a limited number of instances
S: Invalid
This doesn't seem right
S: Needs Voting/Discussion
Need to be discussed by the community (on Loomio)
S: Ready for review
This PR is ready to be reviewed
Suggestion
Proposed ideas worth considering
S: Voted on Loomio
This is issue has been created after a vote on Loomio
S: Wontfix
This will not be worked on
No Label
A: API
A: Backend
A: Federation
A: Front-End
A: I18N
A: Meta
A: Security
Build
C: Bug
C: Discussion
C: Enhancement
C: Feature
Compatibility
Dependency
Design
Documentation
Good first issue
Help welcome
Mobile
Rendering
S: Blocked
S: Duplicate
S: Incomplete
S: Instance specific
S: Invalid
S: Needs Voting/Discussion
S: Ready for review
Suggestion
S: Voted on Loomio
S: Wontfix
Milestone
Set milestone
Clear milestone
No items
No Milestone
Assignees
Assign users
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.
No due date set.
Dependencies
No dependencies set.
Reference: Plume/Plume#575
Reference in New Issue
There is no content yet.
Delete Branch '%!s(<nil>)'
Deleting a branch is permanent. It CANNOT be undone. Continue?
No
Yes
Plume simply is LTR suited. It doesn't follow direction based on the language. Therefore, If a post be made in RTL languages (such as Persian, Arabic, Urdu or Hebrew) the text is still shown in LTR. I just tested it on http://fediverse.blog/ and the result is as following:
I tried to work on this issue. I need some help with understanding template in rust. I couldn't figure out where to find related stuff to
@Html(&article.content)
which is intemplates/posts/details.rs.html
.Moreover, I couldn't find the workflow for building and testing the project after committing changes.
I do appreciate any help. Otherwise, it seems I cannot continue!
Html(..)
means whatever is inside won't get escaped so there can be html content in it (otherwise pictures, links and so on would be escaped instead of shown properly).article
is aPost
structure (defined in plume-models/src/posts.rs around line 40), andcontent
is it's field containing the html-rendered body of the article. I think your best bet would be to adddir="auto"
to the surrounding<article>
, if there is need for more changes it will probably be in the Rust part.If you have installed a test instance, to rebuild, just stop the running one and run
cargo run
, it will recompile what needs to. The other (maybe easier way) is to make a pull request. After a few minutes it should appear here, and it will be updated with each new commit you pushActually adding
dir="auto"
would make whole of the article follow direction based on the first letter on the article. As per my experience, this is not going to work properly. I have already put it for H1 and H2, but it should be added to each and every paragraph tags in the post content.This is the result of applying
dir=auto
to article tag:If I be right, this should be handled from markdown interpreter. Right?
For test, I can send WIP PR. would it work?
I think you are right.
Yes you can make WIP PR, just write it's WIP in the title or the first message so we know it's not ready for review yet :)
So I will apply
dir="auto"
to article for the time being till we can solve this issue permanently.May you guide me for this issue: where is the MD to HTML engine? I need to work on that to add bidi support. Logically it is out of this project, but where?
the markdown processor we use is pulldown-cmark
The issue is opened on pulldown-cmark repo and I try chance to apply changes. if they accept, it would be a great step ahead