Fix problem of PL #956 #962

Closed

mskf1383 wants to merge 3 commits from <deleted>:main into main

mskf1383 commented

The pull request #956 has problem with posts with long title. In posts with long title, description went behind the title.
So I made some other changes to fix that:

.card header {     /*******/
    display: flex; /* New */
}                  /*******/
.card h3 {
    flex-grow: 1;
    margin: 0;
    font-family: "Vazir","Playfair Display",serif;
    font-size: 1.75em;
    font-weight: normal;
    line-height: 1.75;
    display: inline-block;
    position: absolute; /* removed */
}

I hope there isn't any more problems!

The pull request https://git.joinplu.me/Plume/Plume/pulls/956 has problem with posts with long title. In posts with long title, description went behind the title. So I made some other changes to fix that: ```css .card header { /*******/ display: flex; /* New */ } /*******/ .card h3 { flex-grow: 1; margin: 0; font-family: "Vazir","Playfair Display",serif; font-size: 1.75em; font-weight: normal; line-height: 1.75; display: inline-block; position: absolute; /* removed */ } ``` I hope there isn't any more problems!

mskf1383 added 2 commits

4d0d412ad3 Update 'assets/themes/default/_global.scss'

04284e0ca5 Update 'assets/themes/default/_global.scss'

mareklach commented

@mskf1383 Please don't remove position: absolute; completely, I changed it to position: relative; in #960 in order to make what you're adressing work on mobile devices like the iPhone too!

Thanks,

@mskf1383 Please don't remove `position: absolute;` completely, I changed it to `position: relative;` in #960 in order to make what you're adressing work on mobile devices like the iPhone too! Thanks,

mskf1383 commented

Poster

@mskf1383 Please don't remove position: absolute; completely, I changed it to position: relative; in #960 in order to make what you're adressing work on mobile devices like the iPhone too!

Thanks,

I don't think this make problem for mobile screens.
I attach some pictures.

My first change:

Your change:

This change:

> @mskf1383 Please don't remove `position: absolute;` completely, I changed it to `position: relative;` in #960 in order to make what you're adressing work on mobile devices like the iPhone too! > > Thanks, I don't think this make problem for mobile screens. I attach some pictures. My first change: ![My first change](https://git.joinplu.me/attachments/d7e2732e-402f-4b19-9823-c567e5a621cc) Your change: ![Your change](https://git.joinplu.me/attachments/89ff18ed-f918-4d12-80e8-6b922d8cb86e) This change: ![This change](https://git.joinplu.me/attachments/09254ab9-7b60-43b4-b68a-3fcbc3aefb6d)

نماگرفت از 2021-12-02 12-53-32.png

43 KiB

نماگرفت از 2021-12-02 12-52-58.png

42 KiB

نماگرفت از 2021-12-02 12-52-32.png

42 KiB

mskf1383 commented

Poster

And nothing happen if I add a position: relative to it

And nothing happen if I add a `position: relative` to it

mareklach commented

@mskf1383 I suppose you're right. Your pull request will have a merge conflict with #960 because of position: relative; though...

@mskf1383 I suppose you're right. Your pull request will have a merge conflict with #960 because of `position: relative;` though...

mskf1383 added 1 commit

122124e3d4 Update 'assets/themes/default/_global.scss'

mskf1383 closed this pull request

mskf1383 referenced this pull request

Fix problem of PL #956 #963

This pull request cannot be reopened because the branch was deleted.

No reviewers

No Milestone

No Assignees

2 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Loading…

There is no content yet.

Labels Milestones

Fix problem of PL #956 #962