Plume
/
Plume
5
12
Fork 10
Code Issues 144 Pull Requests 12 Releases 5 Wiki Activity
Labels Milestones
New Pull Request

#104 New forms style

Merged
Madeorsk merged 1 commits from forms into master 2 years ago
Conversation 2 Commits 1 Files Changed 1
Madeorsk commented 2 years ago (Migrated from github.com)

Login example on phones and register example on a computer.
Mobile Computer

Login example on phones and register example on a computer. ![Mobile](https://user-images.githubusercontent.com/5805468/42125649-3435b00e-7c7b-11e8-8393-eb9e77f8e5dc.png) ![Computer](https://user-images.githubusercontent.com/5805468/42125665-5b6c920a-7c7b-11e8-9b00-e12dfb649b38.png)
👍 1 ❤️ 1
elegaanz commented 2 years ago (Migrated from github.com)
Owner

Looking at your screens, it looks really nicer than before. My only concern would be about the centered text in inputs, since the text is moving in a quite strange way when typing like that. But I still should give it a live try.

Looking at your screens, it looks really nicer than before. My only concern would be about the centered text in inputs, since the text is moving in a quite strange way when typing like that. But I still should give it a live try.
elegaanz (Migrated from github.com) reviewed 2 years ago
elegaanz (Migrated from github.com) left a comment

As I said, I’m not sure having text centered in inputs is a good idea.

And I don’t know if the textarea to write an article should be that small. Maybe if it has a bigger default height?

Otherwise, it looks very good! Great job! 👌

(and as usual I’m open to discussion if there are good reasons behind these choices)

elegaanz commented 2 years ago (Migrated from github.com)
Owner

I’m going to merge this and make a few changes after.

I'm going to merge this and make a few changes after.
The pull request has been merged as 4aa184ba45.
Sign in to join this conversation.
Reviewers
Request review
No reviewers
Labels
Apply labels
Clear labels
A: API
Related to the REST API A: Backend
Code running on the server A: Federation
Stuff related to Federation A: Front-End
Related to the front-end A: I18N
Translations, and related code A: Meta
More about project management or code than the project itself A: Security Build
The building, or installation process of Plume C: Bug
Something isn't working C: Discussion
We need to talk C: Enhancement
New feature or request C: Feature
This is a new feature Compatibility
Compatibility with different browsers, readers and OS Dependency
Related to an external package that Plume uses Design
UI/UX related issues and PRs Documentation Good first issue
Good for newcomers Help welcome
Extra attention is needed Mobile
Issues affecting only mobile UX Rendering
How elements're rendered out for the end user S: Blocked
Something else needs to be fixed first S: Duplicate
This issue or pull request already exists S: Incomplete
This PR is not complete yet S: Instance specific
Issues concern a limited number of instances S: Invalid
This doesn't seem right S: Needs Voting/Discussion
Need to be discussed by the community (on Loomio) S: Ready for review
This PR is ready to be reviewed Suggestion
Proposed ideas worth considering S: Voted on Loomio
This is issue has been created after a vote on Loomio S: Wontfix
This will not be worked on
No Label
A: API
A: Backend
A: Federation
A: Front-End
A: I18N
A: Meta
A: Security
Build
C: Bug
C: Discussion
C: Enhancement
C: Feature
Compatibility
Dependency
Design
Documentation
Good first issue
Help welcome
Mobile
Rendering
S: Blocked
S: Duplicate
S: Incomplete
S: Instance specific
S: Invalid
S: Needs Voting/Discussion
S: Ready for review
Suggestion
S: Voted on Loomio
S: Wontfix
Milestone
Set milestone
Clear milestone
No items
No Milestone
Assignees
Assign users
Clear assignees
No Assignees
1 Participants
Notifications
Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'forms'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes