Update to a more recent rocket and rust toolchain

lthms がコメント

2018-09-07 23:18:04 +00:00

(github.comから移行)

So, I have made some progress tonight, but unfortunately, this has become way more complicated than initially expected. The main reason is pretty simple: rocket has introduced some serious breaking changes related to the Uri type, and I am not familiar enough unfortunately to fix them easily.

I push this so you folks can have a look, maybe with enough familiarity this is trivial to fix.

Beware that this PR uses my forks of rocket_{i18n,csrf}. They are basically working, AFAICT at least, but I wanted to have a working Plume before creating PR there.

So, yeah. TL;DR: I tried and failed, but maybe what I achieved will help you?

To do before merging:

Fix the warnings
PR to rocket_i18n
PR to rocket_csrf

So, I have made some progress tonight, but unfortunately, this has become way more complicated than initially expected. The main reason is pretty simple: rocket has introduced some serious breaking changes related to the `Uri` type, and I am not familiar enough unfortunately to fix them easily. I push this so you folks can have a look, maybe with enough familiarity this is trivial to fix. Beware that this PR uses my forks of `rocket_{i18n,csrf}`. They are basically working, AFAICT at least, but I wanted to have a working Plume before creating PR there. So, yeah. TL;DR: I tried and failed, but maybe what I achieved will help you? To do before merging: - [x] Fix the warnings - [x] PR to `rocket_i18n` - [x] PR to `rocket_csrf`

👍 3 ❤️ 1

lthms がコメント

2018-09-07 23:25:00 +00:00

(github.comから移行)

Related commits:

rocket_i18n :: b9bd6b9674
rocket_csrf :: 9828be7546 (cc @fdb-hiroshima)

Related commits: - `rocket_i18n` :: https://github.com/lthms/rocket_i18n/commit/b9bd6b9674b09590a7f43c8408781e8030397743 - `rocket_csrf` :: https://github.com/lthms/rocket_csrf/commit/9828be7546f1b7f975e3b71ebe1be664b3ae1014 (cc @fdb-hiroshima)

👍 1

elegaanz がコメント

2018-09-08 07:22:47 +00:00

(github.comから移行)

Thanks a lot for your help! Looks like a lot of errors are happening because of 56c6a96f6a, so adding .into() after uri! invocations should fix it.

Thanks a lot for your help! Looks like a lot of errors are happening because of https://github.com/SergioBenitez/Rocket/commit/56c6a96f6a94ab844a0f571c303d741c7ec668d3, so adding `.into()` after `uri!` invocations should fix it.

lthms がコメント

2018-09-08 07:34:42 +00:00

(github.comから移行)

I will try to do that, if that’s okay with you.

👍 1

elegaanz がコメント

2018-09-08 07:50:10 +00:00

(github.comから移行)

Yes, of course! If you have any question about the code, you know you can ask me 😉

Yes, of course! If you have any question about the code, you know you can ask me :wink:

lthms がコメント

2018-09-08 07:56:29 +00:00

(github.comから移行)

I’ve pushed a new commit that fixes the remaining errors. There remains a lot of warnings, though.

👍 1 ❤️ 1

lthms がコメント

2018-09-08 08:26:38 +00:00

(github.comから移行)

Some warnings are due to a change in rustc that affects diesel. The crate has already been updated, but not released.

Some warnings are due to a change in `rustc` that affects `diesel`. The crate has already been updated, but not released.

elegaanz がコメント

2018-09-08 08:40:03 +00:00

(github.comから移行)

@lthms Could you please use the git repository directly in the Cargo.toml then, with a pinned rev? We will go back to a stable version once it will be released.

@lthms Could you please use the git repository directly in the Cargo.toml then, with a pinned `rev`? We will go back to a stable version once it will be released.

lthms がコメント

2018-09-08 08:46:48 +00:00

(github.comから移行)

I think the PR of interest is https://github.com/diesel-rs/diesel/pull/1787

So we need to depend on at least this revision. Unfortunately, I don't know if there are pending issues in current diesel master branch, so I have to admit I am not sure which revision to choose…

I think the PR of interest is https://github.com/diesel-rs/diesel/pull/1787 So we need to depend on at least this revision. Unfortunately, I don't know if there are pending issues in current `diesel` `master` branch, so I have to admit I am not sure which revision to choose…

elegaanz がコメント

2018-09-08 08:52:11 +00:00

(github.comから移行)

Another solution could be to ignore these warnings for the moment… https://github.com/rust-lang/crates.io/pull/1469/files

lthms がコメント

2018-09-08 09:29:27 +00:00

(github.comから移行)

Once https://github.com/fdb-hiroshima/rocket_csrf/pull/1 is merged, I will update Cargo.toml to use the upstream rocket_csrf, squash my commits and I think it will be okay, at least from my side.

Once https://github.com/fdb-hiroshima/rocket_csrf/pull/1 is merged, I will update `Cargo.toml` to use the upstream `rocket_csrf`, squash my commits and I think it will be okay, at least from my side.

👍 2

lthms がコメント

2018-09-08 13:55:36 +00:00

(github.comから移行)

From my perspective, this PR is now ready. I don’t think I have broken something, but I guess you never know :D.

👍 1 ❤️ 1

Rows
Columns

Update to a more recent rocket and rust toolchain #205