Plume/Plume
9
18
Fork 24
Code Issues 177 Pull requests 8 Releases 8 Wiki Activity

CLI tools #261

Merged
elegaanz merged 7 commits from setup-tools into master 2018-10-06 13:28:14 +00:00
Conversation 3 Commits 7 Files changed 12 +424 -300
elegaanz commented 2018-10-04 20:50:09 +00:00 (Migrated from github.com)
Copy link
  • New sub-crate: plume-cli
  • Creates a binary called 'plm'
  • Uses clap to parse CLI arguments
  • Add a first command: plm instance new (to init the local instance)

Example usage:

plm instance new -d foo.bar -n 'Hey'

Fix #260

- New sub-crate: plume-cli - Creates a binary called 'plm' - Uses clap to parse CLI arguments - Add a first command: plm instance new (to init the local instance) Example usage: ``` plm instance new -d foo.bar -n 'Hey' ``` Fix #260
EliotBerriot (Migrated from github.com) approved these changes 2018-10-06 11:23:12 +00:00
EliotBerriot (Migrated from github.com) left a comment
Copy link

Looks good to me! I'll let you know if I have any issue next time I upgrade the instance using Docker :)

Looks good to me! I'll let you know if I have any issue next time I upgrade the instance using Docker :)
igalic (Migrated from github.com) reviewed 2018-10-06 11:38:11 +00:00
igalic (Migrated from github.com) left a comment
Copy link

is plm supposed to only support Pg?

is plm supposed to only support Pg?
plume-cli/src/instance.rs
igalic (Migrated from github.com) commented 2018-10-06 11:36:38 +00:00
Copy link

shouldn't this be database agnostic now?

shouldn't this be database agnostic now?
elegaanz (Migrated from github.com) reviewed 2018-10-06 11:52:25 +00:00
plume-cli/src/instance.rs
elegaanz (Migrated from github.com) commented 2018-10-06 11:52:25 +00:00
Copy link

Oops, forgot it! 😁

Oops, forgot it! :grin:
elegaanz (Migrated from github.com) reviewed 2018-10-06 12:00:32 +00:00
plume-cli/src/instance.rs
elegaanz (Migrated from github.com) commented 2018-10-06 12:00:32 +00:00
Copy link

Fixed

Fixed
elegaanz commented 2018-10-06 12:55:55 +00:00 (Migrated from github.com)
Copy link

Will also fix #157 #89 and #209

Will also fix #157 #89 and #209
igalic (Migrated from github.com) reviewed 2018-10-06 13:36:08 +00:00
igalic (Migrated from github.com) left a comment
Copy link

default license has changed!

default license has changed!
docs/CLI.md
@ -0,0 +20,4 @@
- `--domain`, `-d`: the domain name on which your instance will be available.
- `--name`, `-n`: The name of your instance. It will be displayed on the homepage.
- `--default-license`, `-l`: the license to use for articles written on this instance, if no other license is explicitely specified. Optional, defaults to CC-0.
igalic (Migrated from github.com) commented 2018-10-06 13:29:13 +00:00
Copy link

this is not correct anymore

this is not correct anymore
docs/INSTALL.md
@ -133,44 +133,73 @@ This command may be useful if you decided to use a separate database server.
## Starting Plume
igalic (Migrated from github.com) commented 2018-10-06 13:30:51 +00:00
Copy link

We should have fixed the info on how to compile Plume with sqlite in #226, why DM i only thinking of this now?

We should have fixed the info on how to compile Plume with sqlite in #226, why DM i only thinking of this now?
plume-cli/src/instance.rs
@ -0,0 +46,4 @@
.unwrap_or_else(|| env::var("BASE_URL")
.unwrap_or_else(|_| super::ask_for("Domain name")));
let name = args.value_of("name").map(String::from).unwrap_or_else(|| super::ask_for("Instance name"));
let license = args.value_of("default-license").map(String::from).unwrap_or(String::from("CC-0"));
igalic (Migrated from github.com) commented 2018-10-06 13:32:34 +00:00
Copy link

we've decided to change the default license

we've decided to change the default license
igalic commented 2018-10-06 13:38:05 +00:00 (Migrated from github.com)
Copy link

we have forgotten to fix up the compile / installation instructions after/with #226

we have forgotten to fix up the compile / installation instructions after/with #226
elegaanz commented 2018-10-06 13:43:31 +00:00 (Migrated from github.com)
Copy link

@igalic yes, I thought about it a few minutes ago too. I will update them right now.

@igalic yes, I thought about it a few minutes ago too. I will update them right now.
elegaanz (Migrated from github.com) reviewed 2018-10-06 13:43:59 +00:00
docs/CLI.md
@ -0,0 +20,4 @@
- `--domain`, `-d`: the domain name on which your instance will be available.
- `--name`, `-n`: The name of your instance. It will be displayed on the homepage.
- `--default-license`, `-l`: the license to use for articles written on this instance, if no other license is explicitely specified. Optional, defaults to CC-0.
elegaanz (Migrated from github.com) commented 2018-10-06 13:43:59 +00:00
Copy link

Yes, but I will change everything in the same PR, so for now I used CC-0.

Yes, but I will change everything in the same PR, so for now I used CC-0.
Sign in to join this conversation.
Reviewers
No reviewers
EliotBerriot
Labels
Clear labels   
A: API

Related to the REST API

  
A: Backend

Code running on the server

  
A: Federation

Stuff related to Federation

  
A: Front-End

Related to the front-end

  
A: I18N

Translations, and related code

  
A: Meta

More about project management or code than the project itself

  
A: Security

   
Build

The building, or installation process of Plume

  
C: Bug

Something isn't working

  
C: Discussion

We need to talk

  
C: Enhancement

New feature or request

  
C: Feature

This is a new feature

  
Compatibility

Compatibility with different browsers, readers and OS

  
Dependency

Related to an external package that Plume uses

  
Design

UI/UX related issues and PRs

  
Documentation

   
Good first issue

Good for newcomers

  
Help welcome

Extra attention is needed

  
Mobile

Issues affecting only mobile UX

  
Rendering

How elements're rendered out for the end user

  
S: Blocked

Something else needs to be fixed first

  
S: Duplicate

This issue or pull request already exists

  
S: Incomplete

This PR is not complete yet

  
S: Instance specific

Issues concern a limited number of instances

  
S: Invalid

This doesn't seem right

  
S: Needs Voting/Discussion

Need to be discussed by the community (on Loomio)

  
S: Ready for review

This PR is ready to be reviewed

  
Suggestion

Proposed ideas worth considering

  
S: Voted on Loomio

This is issue has been created after a vote on Loomio

  
S: Wontfix

This will not be worked on

No labels
A: API
A: Backend
A: Federation
A: Front-End
A: I18N
A: Meta
A: Security
Build
C: Bug
C: Discussion
C: Enhancement
C: Feature
Compatibility
Dependency
Design
Documentation
Good first issue
Help welcome
Mobile
Rendering
S: Blocked
S: Duplicate
S: Incomplete
S: Instance specific
S: Invalid
S: Needs Voting/Discussion
S: Ready for review
Suggestion
S: Voted on Loomio
S: Wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Plume/Plume#261
No description provided.
Delete branch "setup-tools"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?