Add support for blog deletion #282

Merged

Plume_migration_agent merged 2 commits from blog-deletion into master

2018-10-21 12:39:42 +00:00

trinity-1686a commented

2018-10-20 13:15:24 +00:00

Owner

fix #181

At the moment it is done in a similar way to user deletion, i.e. post deletion is not federated, whereas it should probably be. Tell me if I have to implement that part too before merging.

There is a new string to translate ("Delete this blog") however I don't know well how gettext work so I did not add it to .pos

fix #181 At the moment it is done in a similar way to user deletion, i.e. post deletion is not federated, whereas it should probably be. Tell me if I have to implement that part too before merging. There is a new string to translate ("Delete this blog") however I don't know well how gettext work so I did not add it to `.po`s

elegaanz commented

2018-10-20 14:47:54 +00:00

(Migrated from github.com)

I think article deletion should be federated, but we could probably implement it in another PR.

To add the new string to the .po files, just add this to po/plume.pot (the template used for the .po)

msgid "Delete this blog"
msgstr ""

I think article deletion should be federated, but we could probably implement it in another PR. To add the new string to the `.po` files, just add this to `po/plume.pot` (the template used for the `.po`) ```po msgid "Delete this blog" msgstr "" ```

elegaanz (Migrated from github.com) reviewed 2018-10-20 14:59:19 +00:00

elegaanz (Migrated from github.com) left a comment

You should probably delete BlogAuthors linked to this blog too.

You should probably delete `BlogAuthor`s linked to this blog too.

trinity-1686a commented

2018-10-20 15:46:23 +00:00

Author

Owner

Edit:
Actually most entities are deleted in cascade, we could even let the database delete posts (but this would mean no deletion federation)

I was testing if changes I was doing would work, then I noticed I did not have entry from previous attempts. Delete is set to cascade on blog_authors, so we don't actually need to delete blog_authors, databases do it by themselves Edit: Actually most entities are deleted in cascade, we could even let the database delete posts (but this would mean no deletion federation)

👍 1

elegaanz (Migrated from github.com) approved these changes 2018-10-21 12:39:36 +00:00

elegaanz (Migrated from github.com) left a comment

Thank you!

No reviewers

elegaanz

No milestone

No project

No assignees

2 participants

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Plume/Plume#282

No description provided.

Rows
Columns