Add support for blog deletion #282

Merged

Plume_migration_agent merged 2 commits from blog-deletion into master

trinity-1686a commented

Owner

At the moment it is done in a similar way to user deletion, i.e. post deletion is not federated, whereas it should probably be. Tell me if I have to implement that part too before merging.

There is a new string to translate ("Delete this blog") however I don't know well how gettext work so I did not add it to .pos

fix #181 At the moment it is done in a similar way to user deletion, i.e. post deletion is not federated, whereas it should probably be. Tell me if I have to implement that part too before merging. There is a new string to translate ("Delete this blog") however I don't know well how gettext work so I did not add it to `.po`s

elegaanz commented (Migrated from github.com)

I think article deletion should be federated, but we could probably implement it in another PR.

To add the new string to the .po files, just add this to po/plume.pot (the template used for the .po)

msgid "Delete this blog"
msgstr ""

I think article deletion should be federated, but we could probably implement it in another PR. To add the new string to the `.po` files, just add this to `po/plume.pot` (the template used for the `.po`) ```po msgid "Delete this blog" msgstr "" ```

elegaanz (Migrated from github.com) reviewed

elegaanz (Migrated from github.com) left a comment

You should probably delete BlogAuthors linked to this blog too.

You should probably delete `BlogAuthor`s linked to this blog too.

trinity-1686a commented

Poster

Owner

Edit:
Actually most entities are deleted in cascade, we could even let the database delete posts (but this would mean no deletion federation)

I was testing if changes I was doing would work, then I noticed I did not have entry from previous attempts. Delete is set to cascade on blog_authors, so we don't actually need to delete blog_authors, databases do it by themselves Edit: Actually most entities are deleted in cascade, we could even let the database delete posts (but this would mean no deletion federation)

👍 1

elegaanz (Migrated from github.com) approved these changes

elegaanz (Migrated from github.com) left a comment

Thank you!

Reviewers

The pull request has been merged as 9187aefda0.

You can also view command line instructions.

Step 1:

From your project repository, check out a new branch and test the changes.

git checkout -b blog-deletion master

git pull origin blog-deletion

Step 2:

Merge the changes and update on Forgejo.

git checkout master

git merge --no-ff blog-deletion

git push origin master

No reviewers

No Milestone

No Assignees

2 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Loading…

There is no content yet.

Labels Milestones

Add support for blog deletion #282

Reviewers

Step 1:

Step 2: