Fix editor auto-expansion #293

병합
elegaanz issue-237 에서 master 로 4 commits 를 머지했습니다 6 년 전
elegaanz 코멘트됨, 6 년 전 (Migrated from github.com)

Fixes #237

Another element with the content ID was present in the header.

Fixes #237 Another element with the `content` ID was present in the header.
trinity-1686a 코멘트됨, 6 년 전
소유자

I've tried with a very big text (a few thousands words of lorem ipsum), the expansion works well, however I'm getting a weird effect when trying to edit anything behind the base size, it auto-scroll to the very beginning of the post at each key up, and go back to the cursor at each key down. The issue is reproducible on both Firefox (63) and Chromium (70)

I've tried with a very big text (a few thousands words of lorem ipsum), the expansion works well, however I'm getting a weird effect when trying to edit anything behind the base size, it auto-scroll to the very beginning of the post at each key up, and go back to the cursor at each key down. The issue is reproducible on both Firefox (63) and Chromium (70)
elegaanz 코멘트됨, 6 년 전 (Migrated from github.com)

I can't reproduce (I tried with Firefox 63 and Chromium 70 too 🤷‍♀️)

I can't reproduce (I tried with Firefox 63 and Chromium 70 too :woman_shrugging:)
trinity-1686a 검토됨 6 년 전
@ -27,8 +27,8 @@
{% endfor %}
trinity-1686a 코멘트됨, 6 년 전
소유자

the for should be modified to match textarea's new id

     <label for="plume-editor">{{ "Content" | _ }}<small>{{ "Markdown is supported" | _ }}</small></label>
the `for` should be modified to match textarea's new id ```suggestion <label for="plume-editor">{{ "Content" | _ }}<small>{{ "Markdown is supported" | _ }}</small></label> ```
trinity-1686a 코멘트됨, 6 년 전
소유자

@BaptisteGelez that's odd, I tried again on a fresh Plume install and this is definitely reproducible on my side. I tried one single big paragraph, multiple small ones, one word per line... anything longer than 50 lines seems to trigger it (which is in fact more than the hard-coded 20 rows)

Also, not related but I think the id should be changed too in templates/posts/details.html.tera:112 (and its label), otherwise the comment editor won't be affected by those changes

@BaptisteGelez that's odd, I tried again on a fresh Plume install and this is definitely reproducible on my side. I tried one single big paragraph, multiple small ones, one word per line... anything longer than 50 lines seems to trigger it (which is in fact more than the hard-coded 20 rows) Also, not related but I think the id should be changed too in `templates/posts/details.html.tera:112` (and its label), otherwise the comment editor won't be affected by those changes
elegaanz 코멘트됨, 6 년 전 (Migrated from github.com)

OK, I can indeed reproduce with a longer text. I'll try to fix it.

OK, I can indeed reproduce with a longer text. I'll try to fix it.
elegaanz 코멘트됨, 6 년 전 (Migrated from github.com)

The issue has normally been fixed (all these commits could probably be squashed before merging BTW)

The issue has normally been fixed (all these commits could probably be squashed before merging BTW)
trinity-1686a 코멘트됨, 6 년 전
소유자

So it no longer scroll back and forth, however it do scroll on the first keypress after moving the cursor. This is way better and can probably be merged as is, but we might want to take a look at it. What I get is not coherent between browser however : on Firefox the line being edited is aligned with the bottom of the screen, whereas in Chromium it's aligned with the middle of it

So it no longer scroll back and forth, however it do scroll on the first keypress after moving the cursor. This is way better and can probably be merged as is, but we might want to take a look at it. What I get is not coherent between browser however : on Firefox the line being edited is aligned with the bottom of the screen, whereas in Chromium it's aligned with the middle of it
elegaanz 코멘트됨, 6 년 전 (Migrated from github.com)

I don't want to fight against browsers and their different implementation, so I will merge this branch as it is. If your issue is too problematic, we will still be able to fix it afterwards. This editor will (almost) disappear soon anyway…

I don't want to fight against browsers and their different implementation, so I will merge this branch as it is. If your issue is too problematic, we will still be able to fix it afterwards. This editor will (almost) disappear soon anyway…
The pull request has been merged as 2e072affb5.
You can also view command line instructions.

Step 1:

From your project repository, check out a new branch and test the changes.
git checkout -b issue-237 master
git pull origin issue-237

Step 2:

Merge the changes and update on Forgejo.
git checkout master
git merge --no-ff issue-237
git push origin master
로그인하여 이 대화에 참여
No reviewers
마일스톤 없음
담당자 없음
참여자 2명
알림
마감일
기한이 올바르지 않거나 범위를 벗어났습니다. 'yyyy-mm-dd'형식을 사용해주십시오.

마감일이 설정되지 않았습니다.

의존성

No dependencies set.

Reference: Plume/Plume#293
불러오는 중...
아직 콘텐츠가 없습니다.