#307 Post creation API

Merged
elegaanz merged 9 commits from post-api into master 1 year ago
elegaanz commented 2 years ago (Migrated from github.com)
There is no content yet.
codecov[bot] commented 2 years ago (Migrated from github.com)
Owner

Codecov Report

Merging #307 into master will decrease coverage by 0.44%.
The diff coverage is 11.34%.

@@            Coverage Diff             @@
##           master     #307      +/-   ##
==========================================
- Coverage    28.3%   27.86%   -0.45%     
==========================================
  Files          63       63              
  Lines        5949     6280     +331     
==========================================
+ Hits         1684     1750      +66     
- Misses       4265     4530     +265
# [Codecov](https://codecov.io/gh/Plume-org/Plume/pull/307?src=pr&el=h1) Report > Merging [#307](https://codecov.io/gh/Plume-org/Plume/pull/307?src=pr&el=desc) into [master](https://codecov.io/gh/Plume-org/Plume/commit/fdfeeed6d9fa9dec92862366a8b646eb27d17422?src=pr&el=desc) will **decrease** coverage by `0.44%`. > The diff coverage is `11.34%`. ```diff @@ Coverage Diff @@ ## master #307 +/- ## ========================================== - Coverage 28.3% 27.86% -0.45% ========================================== Files 63 63 Lines 5949 6280 +331 ========================================== + Hits 1684 1750 +66 - Misses 4265 4530 +265 ```
elegaanz commented 2 years ago (Migrated from github.com)
Owner

Ah, yes, I should write tests…

Ah, yes, I should write tests…
elegaanz commented 2 years ago (Migrated from github.com)
Owner

I think I will wait for #310 to be merged before adding tests, as it would probably create conflicts otherwise…

I think I will wait for #310 to be merged before adding tests, as it would probably create conflicts otherwise…
trinity-1686a reviewed 2 years ago
trinity-1686a commented 2 years ago

anything after let conn = ... should be surrounded by a big

conn.test_transaction::<_, (), _>(|| { 
    [...]
    Ok(())
})

to prevent any side effect

anything after `let conn = ...` should be surrounded by a big ```rust conn.test_transaction::<_, (), _>(|| { [...] Ok(()) }) ``` to prevent any side effect
trinity-1686a commented 1 year ago
Owner

Is this still ready for review? If so you should fix the conflict with master

Is this still ready for review? If so you should fix the conflict with master
trinity-1686a reviewed 1 year ago
trinity-1686a approved these changes 1 year ago

Reviewers

trinity-1686a approved these changes 1 year ago
The pull request has been merged as 4ec2480f50.
Sign in to join this conversation.
No reviewers
No Milestone
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

Loading…
There is no content yet.