Plume/Plume

Fork 24

Post creation API #307

Merged

elegaanz merged 9 commits from post-api into master

2018-12-24 15:42:41 +00:00

elegaanz commented

2018-11-06 15:51:40 +00:00

(Migrated from github.com)

No description provided.

codecov[bot] commented

2018-11-06 16:23:57 +00:00

(Migrated from github.com)

Codecov Report

Merging #307 into master will decrease coverage by 0.44%.
The diff coverage is 11.34%.

@@            Coverage Diff             @@
##           master     #307      +/-   ##
==========================================
- Coverage    28.3%   27.86%   -0.45%     
==========================================
  Files          63       63              
  Lines        5949     6280     +331     
==========================================
+ Hits         1684     1750      +66     
- Misses       4265     4530     +265

# [Codecov](https://codecov.io/gh/Plume-org/Plume/pull/307?src=pr&el=h1) Report > Merging [#307](https://codecov.io/gh/Plume-org/Plume/pull/307?src=pr&el=desc) into [master](https://codecov.io/gh/Plume-org/Plume/commit/fdfeeed6d9fa9dec92862366a8b646eb27d17422?src=pr&el=desc) will **decrease** coverage by `0.44%`. > The diff coverage is `11.34%`. ```diff @@ Coverage Diff @@ ## master #307 +/- ## ========================================== - Coverage 28.3% 27.86% -0.45% ========================================== Files 63 63 Lines 5949 6280 +331 ========================================== + Hits 1684 1750 +66 - Misses 4265 4530 +265 ```

elegaanz commented

2018-11-06 16:55:24 +00:00

(Migrated from github.com)

Ah, yes, I should write tests…

👍 2

elegaanz commented

2018-11-11 10:28:46 +00:00

(Migrated from github.com)

I think I will wait for #310 to be merged before adding tests, as it would probably create conflicts otherwise…

trinity-1686a reviewed 2018-11-25 14:40:32 +00:00

src/api/posts.rs

trinity-1686a commented

2018-11-25 14:40:32 +00:00

Owner

anything after let conn = ... should be surrounded by a big

conn.test_transaction::<_, (), _>(|| { 
    [...]
    Ok(())
})

to prevent any side effect

anything after `let conn = ...` should be surrounded by a big ```rust conn.test_transaction::<_, (), _>(|| { [...] Ok(()) }) ``` to prevent any side effect

trinity-1686a commented

2018-12-17 18:30:46 +00:00

Owner

Is this still ready for review? If so you should fix the conflict with master

trinity-1686a reviewed 2018-12-24 13:41:31 +00:00

trinity-1686a approved these changes 2018-12-24 14:25:22 +00:00

No reviewers

No milestone

No project

No assignees

2 participants

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Plume/Plume#307

No description provided.