Test with PostgreSQL too #309

Merged
elegaanz merged 5 commits from postgres-tests into master 5 years ago
elegaanz commented 5 years ago (Migrated from github.com)

The coverage is still only reported with SQLite, but it should be the same anyway.

The coverage is still only reported with SQLite, but it should be the same anyway.
Owner

You can probably add 'test' to the stages, so they are run in a logical order (test before code cov), or maybe we should calculate code coverage with both postgres and sqlite, and change the name of the code coverage stage, so it's more symmetrical

You can probably add 'test' to the stages, so they are run in a logical order (test before code cov), or maybe we should calculate code coverage with both postgres and sqlite, and change the name of the `code coverage` stage, so it's more symmetrical
codecov[bot] commented 5 years ago (Migrated from github.com)

Codecov Report

Merging #309 into master will increase coverage by 0.17%.
The diff coverage is 93.75%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #309      +/-   ##
=========================================
+ Coverage    4.96%   5.14%   +0.17%     
=========================================
  Files          55      55              
  Lines        3708    3715       +7     
=========================================
+ Hits          184     191       +7     
  Misses       3524    3524
Impacted Files Coverage Δ
plume-models/tests/lib.rs 96% <93.75%> (+0.54%) ⬆️
plume-models/src/safe_string.rs 35% <0%> (+1.66%) ⬆️
plume-models/src/lib.rs 34.61% <0%> (+3.24%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3690e4c...2c8ff67. Read the comment docs.

# [Codecov](https://codecov.io/gh/Plume-org/Plume/pull/309?src=pr&el=h1) Report > Merging [#309](https://codecov.io/gh/Plume-org/Plume/pull/309?src=pr&el=desc) into [master](https://codecov.io/gh/Plume-org/Plume/commit/3690e4cfb92537a5b948e18c6b1e850e496c5c8a?src=pr&el=desc) will **increase** coverage by `0.17%`. > The diff coverage is `93.75%`. [![Impacted file tree graph](https://codecov.io/gh/Plume-org/Plume/pull/309/graphs/tree.svg?width=650&token=sHtxmDuZ06&height=150&src=pr)](https://codecov.io/gh/Plume-org/Plume/pull/309?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #309 +/- ## ========================================= + Coverage 4.96% 5.14% +0.17% ========================================= Files 55 55 Lines 3708 3715 +7 ========================================= + Hits 184 191 +7 Misses 3524 3524 ``` | [Impacted Files](https://codecov.io/gh/Plume-org/Plume/pull/309?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [plume-models/tests/lib.rs](https://codecov.io/gh/Plume-org/Plume/pull/309/diff?src=pr&el=tree#diff-cGx1bWUtbW9kZWxzL3Rlc3RzL2xpYi5ycw==) | `96% <93.75%> (+0.54%)` | :arrow_up: | | [plume-models/src/safe\_string.rs](https://codecov.io/gh/Plume-org/Plume/pull/309/diff?src=pr&el=tree#diff-cGx1bWUtbW9kZWxzL3NyYy9zYWZlX3N0cmluZy5ycw==) | `35% <0%> (+1.66%)` | :arrow_up: | | [plume-models/src/lib.rs](https://codecov.io/gh/Plume-org/Plume/pull/309/diff?src=pr&el=tree#diff-cGx1bWUtbW9kZWxzL3NyYy9saWIucnM=) | `34.61% <0%> (+3.24%)` | :arrow_up: | ------ [Continue to review full report at Codecov](https://codecov.io/gh/Plume-org/Plume/pull/309?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/Plume-org/Plume/pull/309?src=pr&el=footer). Last update [3690e4c...2c8ff67](https://codecov.io/gh/Plume-org/Plume/pull/309?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
elegaanz commented 5 years ago (Migrated from github.com)

I don't know how Codecov will react if we send two different coverage reports for the same commit…

I don't know how Codecov will react if we send two different coverage reports for the same commit…
Owner

They "add" the two report, a line caught by at least one test is considered covered, lines caught by no tests are considered missed

They "add" the two report, a line caught by at least one test is considered covered, lines caught by no tests are considered missed
elegaanz commented 5 years ago (Migrated from github.com)

OK, great! I will try to get coverage for Postgres too then.

OK, great! I will try to get coverage for Postgres too then.
trinity-1686a approved these changes 5 years ago
trinity-1686a left a comment
Owner

I've nothing more to add, I think this can be merged

I've nothing more to add, I think this can be merged
elegaanz commented 5 years ago (Migrated from github.com)

Oh thanks for your commit!

Oh thanks for your commit!

Reviewers

trinity-1686a approved these changes 5 years ago
The pull request has been merged as b28411da99.
You can also view command line instructions.

Step 1:

From your project repository, check out a new branch and test the changes.
git checkout -b postgres-tests master
git pull origin postgres-tests

Step 2:

Merge the changes and update on Forgejo.
git checkout master
git merge --no-ff postgres-tests
git push origin master
Sign in to join this conversation.
No reviewers
No Milestone
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Plume/Plume#309
Loading…
There is no content yet.