elegaanz commented

(Migrated from github.com)

The coverage is still only reported with SQLite, but it should be the same anyway.

trinity-1686a commented

2018-11-06 18:49:24 +00:00

Owner

You can probably add 'test' to the stages, so they are run in a logical order (test before code cov), or maybe we should calculate code coverage with both postgres and sqlite, and change the name of the code coverage stage, so it's more symmetrical

You can probably add 'test' to the stages, so they are run in a logical order (test before code cov), or maybe we should calculate code coverage with both postgres and sqlite, and change the name of the `code coverage` stage, so it's more symmetrical

👍 1

codecov[bot] commented

2018-11-06 18:50:58 +00:00

(Migrated from github.com)

Codecov Report

Merging #309 into master will increase coverage by 0.17%.
The diff coverage is 93.75%.

@@            Coverage Diff            @@
##           master    #309      +/-   ##
=========================================
+ Coverage    4.96%   5.14%   +0.17%     
=========================================
  Files          55      55              
  Lines        3708    3715       +7     
=========================================
+ Hits          184     191       +7     
  Misses       3524    3524

Impacted Files	Coverage Δ
plume-models/tests/lib.rs	`96% <93.75%> (+0.54%)`	⬆️
plume-models/src/safe_string.rs	`35% <0%> (+1.66%)`	⬆️
plume-models/src/lib.rs	`34.61% <0%> (+3.24%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3690e4c...2c8ff67. Read the comment docs.

# [Codecov](https://codecov.io/gh/Plume-org/Plume/pull/309?src=pr&el=h1) Report > Merging [#309](https://codecov.io/gh/Plume-org/Plume/pull/309?src=pr&el=desc) into [master](https://codecov.io/gh/Plume-org/Plume/commit/3690e4cfb92537a5b948e18c6b1e850e496c5c8a?src=pr&el=desc) will **increase** coverage by `0.17%`. > The diff coverage is `93.75%`. [![Impacted file tree graph](https://codecov.io/gh/Plume-org/Plume/pull/309/graphs/tree.svg?width=650&token=sHtxmDuZ06&height=150&src=pr)](https://codecov.io/gh/Plume-org/Plume/pull/309?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #309 +/- ## ========================================= + Coverage 4.96% 5.14% +0.17% ========================================= Files 55 55 Lines 3708 3715 +7 ========================================= + Hits 184 191 +7 Misses 3524 3524 ``` | [Impacted Files](https://codecov.io/gh/Plume-org/Plume/pull/309?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [plume-models/tests/lib.rs](https://codecov.io/gh/Plume-org/Plume/pull/309/diff?src=pr&el=tree#diff-cGx1bWUtbW9kZWxzL3Rlc3RzL2xpYi5ycw==) | `96% <93.75%> (+0.54%)` | :arrow_up: | | [plume-models/src/safe\_string.rs](https://codecov.io/gh/Plume-org/Plume/pull/309/diff?src=pr&el=tree#diff-cGx1bWUtbW9kZWxzL3NyYy9zYWZlX3N0cmluZy5ycw==) | `35% <0%> (+1.66%)` | :arrow_up: | | [plume-models/src/lib.rs](https://codecov.io/gh/Plume-org/Plume/pull/309/diff?src=pr&el=tree#diff-cGx1bWUtbW9kZWxzL3NyYy9saWIucnM=) | `34.61% <0%> (+3.24%)` | :arrow_up: | ------ [Continue to review full report at Codecov](https://codecov.io/gh/Plume-org/Plume/pull/309?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/Plume-org/Plume/pull/309?src=pr&el=footer). Last update [3690e4c...2c8ff67](https://codecov.io/gh/Plume-org/Plume/pull/309?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

elegaanz commented

2018-11-06 18:57:37 +00:00

(Migrated from github.com)

I don't know how Codecov will react if we send two different coverage reports for the same commit…