Generate valid follow Accept activity URI #317

Merged

KokaKiwi merged 1 commit from valid-follow-accept-uri into master

2018-11-23 12:23:47 +00:00

KokaKiwi commented

2018-11-23 01:17:03 +00:00

(Migrated from github.com)

For now it only generate a "fake" URI for accept follow activities, but it should be possible to get the URI dereferencable later.

Also I don't know if this URI looks ok, I tried to get something kind of future-proof, but I don't really know about the actual URIs conventions.

Closes #313

For now it only generate a "fake" URI for accept follow activities, but it should be possible to get the URI dereferencable later. Also I don't know if this URI looks ok, I tried to get something kind of future-proof, but I don't really know about the actual URIs conventions. Closes #313

👍 1 ❤️ 1

codecov[bot] commented

2018-11-23 01:42:01 +00:00

(Migrated from github.com)

Codecov Report

Merging #317 into master will not change coverage.
The diff coverage is 0%.

@@          Coverage Diff           @@
##           master    #317   +/-   ##
======================================
  Coverage    5.13%   5.13%           
======================================
  Files          55      55           
  Lines        3719    3719           
======================================
  Hits          191     191           
  Misses       3528    3528

Impacted Files	Coverage Δ
plume-models/src/follows.rs	`0% <0%> (ø)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 00a205a...86c547a. Read the comment docs.

# [Codecov](https://codecov.io/gh/Plume-org/Plume/pull/317?src=pr&el=h1) Report > Merging [#317](https://codecov.io/gh/Plume-org/Plume/pull/317?src=pr&el=desc) into [master](https://codecov.io/gh/Plume-org/Plume/commit/00a205a882aa0229fe33f358a7ba1b24171899d0?src=pr&el=desc) will **not change** coverage. > The diff coverage is `0%`. [![Impacted file tree graph](https://codecov.io/gh/Plume-org/Plume/pull/317/graphs/tree.svg?width=650&token=sHtxmDuZ06&height=150&src=pr)](https://codecov.io/gh/Plume-org/Plume/pull/317?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #317 +/- ## ====================================== Coverage 5.13% 5.13% ====================================== Files 55 55 Lines 3719 3719 ====================================== Hits 191 191 Misses 3528 3528 ``` | [Impacted Files](https://codecov.io/gh/Plume-org/Plume/pull/317?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [plume-models/src/follows.rs](https://codecov.io/gh/Plume-org/Plume/pull/317/diff?src=pr&el=tree#diff-cGx1bWUtbW9kZWxzL3NyYy9mb2xsb3dzLnJz) | `0% <0%> (ø)` | :arrow_up: | ------ [Continue to review full report at Codecov](https://codecov.io/gh/Plume-org/Plume/pull/317?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/Plume-org/Plume/pull/317?src=pr&el=footer). Last update [00a205a...86c547a](https://codecov.io/gh/Plume-org/Plume/pull/317?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

elegaanz (Migrated from github.com) approved these changes 2018-11-23 12:22:35 +00:00

elegaanz (Migrated from github.com) left a comment

Thanks for all your contributions! The URL looks good to me 👌

Thanks for all your contributions! The URL looks good to me :ok_hand:

No reviewers

elegaanz

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Plume/Plume#317

No description provided.