Plume/Plume

Fork 24

Use SCSS #355

Merged

elegaanz merged 3 commits from sass into master

2018-12-15 21:06:28 +00:00

elegaanz commented

2018-12-15 18:01:05 +00:00

(Migrated from github.com)

Use variables
Split everything in various files

The SCSS is compiled with cargo build/run

I also fixed a few visual issues.

- Use variables - Split everything in various files The SCSS is compiled with `cargo build`/`run` I also fixed a few visual issues.

trinity-1686a reviewed 2018-12-15 18:04:48 +00:00

build.rs

trinity-1686a commented

2018-12-15 18:04:48 +00:00

Owner

is it some cargo keyword or a debug print?

codecov[bot] commented

2018-12-15 18:30:25 +00:00

(Migrated from github.com)

Codecov Report

Merging #355 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #355   +/-   ##
=======================================
  Coverage   28.29%   28.29%           
=======================================
  Files          62       62           
  Lines        6545     6545           
=======================================
  Hits         1852     1852           
  Misses       4693     4693

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3830220...95ae645. Read the comment docs.

# [Codecov](https://codecov.io/gh/Plume-org/Plume/pull/355?src=pr&el=h1) Report > Merging [#355](https://codecov.io/gh/Plume-org/Plume/pull/355?src=pr&el=desc) into [master](https://codecov.io/gh/Plume-org/Plume/commit/38302203f490d09a481baa14a2f2443fc62da94c?src=pr&el=desc) will **not change** coverage. > The diff coverage is `n/a`. [![Impacted file tree graph](https://codecov.io/gh/Plume-org/Plume/pull/355/graphs/tree.svg?width=650&token=sHtxmDuZ06&height=150&src=pr)](https://codecov.io/gh/Plume-org/Plume/pull/355?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #355 +/- ## ======================================= Coverage 28.29% 28.29% ======================================= Files 62 62 Lines 6545 6545 ======================================= Hits 1852 1852 Misses 4693 4693 ``` ------ [Continue to review full report at Codecov](https://codecov.io/gh/Plume-org/Plume/pull/355?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/Plume-org/Plume/pull/355?src=pr&el=footer). Last update [3830220...95ae645](https://codecov.io/gh/Plume-org/Plume/pull/355?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

elegaanz (Migrated from github.com) reviewed 2018-12-15 18:31:01 +00:00

build.rs

elegaanz (Migrated from github.com) commented

2018-12-15 18:31:01 +00:00

Oops, I did it again.

It should probably have a pre-commit hook listing the println! I added→ 🤔

Oops, I did it again. It should probably have a pre-commit hook listing the println! I added→ :thinking:

trinity-1686a reviewed 2018-12-15 18:37:06 +00:00

build.rs

trinity-1686a commented

2018-12-15 18:37:06 +00:00

Owner

I personally use "poisson" followed by a color ("poisson rouge" (=golden fish), "poisson vert"...) in my debug prints. That way a simple git grep poisson prevent me from doing such. It's quite weird when someone look at my code over my shoulder, but work fairly well

I personally use "poisson" followed by a color ("poisson rouge" (=golden fish), "poisson vert"...) in my debug prints. That way a simple `git grep poisson` prevent me from doing such. It's quite weird when someone look at my code over my shoulder, but work fairly well

trinity-1686a approved these changes 2018-12-15 20:24:50 +00:00

trinity-1686a left a comment

Owner

Don't seems to break anything, so it's fine by me. I wonder if in the long run it wouldn't be better to not mix generated files with static ones. Using symbolic links or something like that when necessary

No reviewers

No milestone

No project

No assignees

2 participants

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Plume/Plume#355

No description provided.

Rows
Columns