Fix some federation issues #357
No reviewers
Labels
No labels
A: API
A: Backend
A: Federation
A: Front-End
A: I18N
A: Meta
A: Security
Build
C: Bug
C: Discussion
C: Enhancement
C: Feature
Compatibility
Dependency
Design
Documentation
Good first issue
Help welcome
Mobile
Rendering
S: Blocked
S: Duplicate
S: Incomplete
S: Instance specific
S: Invalid
S: Needs Voting/Discussion
S: Ready for review
Suggestion
S: Voted on Loomio
S: Wontfix
No milestone
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: Plume/Plume#357
Loading…
Add table
Reference in a new issue
No description provided.
Delete branch "fix-federation"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
There are some bugs in federation, the goal of this will be to fix most of them
(Maybe incomplete) list of things to do :
Codecov Report
Concerning mention links, I think the only easy solution is to add a domain argument to the parser, and prefix each link with it. Any other solution I'm thinking of either imply post processing or database access in the parser
Maybe we can always use the FQN for these links so that they are correct on remote instances, and add a redirection when requesting a FQN that is on the current instance?
FQN will do the trick when talking to other Plume, but Mastodon use a different model for user links (
https://mastodon.local/@<name>
, notice no slash between @ and<name>
), and Pleroma uses yet another (https://pleroma.local/users/<name>
). So either we use users ap-url (need db access), or we use an absolute link to the current instance (not the best solution, but definitely the easiest)Mastodon also recognises the profile URL format of
https://mastodon.local/users/<name>
, to redirect to the correct user profile, I have tried it. Thus it may be possible if you were to implement the URL format ofhttps://pleroma.local/users/<name>
that it should work just fine for Mastodon too, I think?We could change our scheme, but it wouldn't fix how we treat remote users.
/@/<user@domain>
is valid with Plume, but the equivalent is not with Mastodon/Pleroma. I really think using absolute urls is the easiest way to goOne can undo activities made by others. I should fix that too before merging
All your changes seems to work! The only issue, but I'm not sure if it one is that I'm still getting notifications in Pleroma: it appears on the notification page (/USER/mentions) but not in the notification panel on the left (but maybe that's just how Pleroma works, I don't use it regularly enough to know).
I've no idea why it's that way, I would expect the left panel, /USER/mentions and the notification on /web to be in sync, apparently they aren't???
Yes, I don't know how Pleroma works 🤷♀️ but I guess we can ignore this issue, it is still better than before even if not perfect…