Allow for comment deletion #363
No reviewers
Labels
No labels
A: API
A: Backend
A: Federation
A: Front-End
A: I18N
A: Meta
A: Security
Build
C: Bug
C: Discussion
C: Enhancement
C: Feature
Compatibility
Dependency
Design
Documentation
Good first issue
Help welcome
Mobile
Rendering
S: Blocked
S: Duplicate
S: Incomplete
S: Instance specific
S: Invalid
S: Needs Voting/Discussion
S: Ready for review
Suggestion
S: Voted on Loomio
S: Wontfix
No milestone
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: Plume/Plume#363
Loading…
Add table
Reference in a new issue
No description provided.
Delete branch "delete-comment"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Fix #224
Current design is a bit terrible. I've tried things, only made it worse. If someone better than me at CSS could give it a try
This tries to conserve as much threads as possible, by re-linking comments to the parent of the one being deleted
we could do the reddit thing and leave a greyed out
deleted
box. that might be easiest.My problem is not with deleted comment, I just delete them. It's with the delete button itself
just 👀
@ -1,4 +1,4 @@
use activitypub::{activity::Create, link, object::Note};
use activitypub::{activity::{Create, Delete}, link, object::{Note, Tombstone}};
use chrono::{self, NaiveDateTime};
Tombstone… sounds cool
@ -13,3 +13,3 @@
</a>
</a>
@if let Some(ref ap_url) = comm.ap_url {
<a class="u-url" href="@ap_url"></a>
why this indent?
@ -1,4 +1,4 @@
use activitypub::{activity::Create, link, object::Note};
use activitypub::{activity::{Create, Delete}, link, object::{Note, Tombstone}};
use chrono::{self, NaiveDateTime};
It's what you need to live behind when deleting things (as opposed to undoing)
Codecov Report
0% <ø> (ø)
0% <0%> (ø)
0% <0%> (ø)
0% <0%> (ø)
12.01% <0%> (-0.65%)
90.56% <0%> (-0.18%)
59.8% <0%> (-0.14%)
0% <0%> (ø)
0% <0%> (ø)
Continue to review full report at Codecov.
@ -13,3 +13,3 @@
</a>
</a>
@if let Some(ref ap_url) = comm.ap_url {
<a class="u-url" href="@ap_url"></a>
There is a 100% chance my vim is still fucking up the indent in html templates, I have no idea why but in those rs.html it absolutely want to add tabs everywhere
I improved a bit the deletion button style, I don't know if there anything else that would need better styling.
No, that was all
Then, we can merge I think.