Plume
/
Plume
8
16
Fork 22
Code Issues 174 Pull Requests 8 Releases 8 Wiki Activity

Labels Milestones

Allow for comment deletion #363

Merged
Plume_migration_agent merged 3 commits from delete-comment into master 5 years ago
Conversation 5 Commits 3 Files Changed 8
trinity-1686a commented 5 years ago
Owner

Fix #224

Current design is a bit terrible. I've tried things, only made it worse. If someone better than me at CSS could give it a try

This tries to conserve as much threads as possible, by re-linking comments to the parent of the one being deleted

Fix #224 Current design is a bit terrible. I've tried things, only made it worse. If someone better than me at CSS could give it a try This tries to conserve as much threads as possible, by re-linking comments to the parent of the one being deleted
igalic commented 5 years ago (Migrated from github.com)

we could do the reddit thing and leave a greyed out deleted box. that might be easiest.

we could do the reddit thing and leave a greyed out `deleted` box. that might be easiest.
trinity-1686a commented 5 years ago
Poster
Owner

My problem is not with deleted comment, I just delete them. It's with the delete button itself

My problem is not with deleted comment, I just delete them. It's with the delete button itself
igalic (Migrated from github.com) reviewed 5 years ago
igalic (Migrated from github.com) left a comment

just 👀

just 👀
plume-models/src/comments.rs
@ -1,4 +1,4 @@
use activitypub::{activity::Create, link, object::Note};
use activitypub::{activity::{Create, Delete}, link, object::{Note, Tombstone}};
use chrono::{self, NaiveDateTime};
igalic (Migrated from github.com) commented 5 years ago

Tombstone… sounds cool

Tombstone… sounds cool
templates/partials/comment.rs.html
@ -13,3 +13,3 @@
</a>
</a>
@if let Some(ref ap_url) = comm.ap_url {
<a class="u-url" href="@ap_url"></a>
igalic (Migrated from github.com) commented 5 years ago

why this indent?

why this indent?
trinity-1686a reviewed 5 years ago
plume-models/src/comments.rs
@ -1,4 +1,4 @@
use activitypub::{activity::Create, link, object::Note};
use activitypub::{activity::{Create, Delete}, link, object::{Note, Tombstone}};
use chrono::{self, NaiveDateTime};
trinity-1686a commented 5 years ago
Poster
Owner

It's what you need to live behind when deleting things (as opposed to undoing)

It's what you need to live behind when deleting things (as opposed to undoing)
codecov[bot] commented 5 years ago (Migrated from github.com)

Codecov Report

Merging #363 into master will decrease coverage by 0.24%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #363      +/-   ##
==========================================
- Coverage   28.29%   28.05%   -0.25%     
==========================================
  Files          62       62              
  Lines        6545     5810     -735     
==========================================
- Hits         1852     1630     -222     
+ Misses       4693     4180     -513
Impacted Files Coverage Δ
src/main.rs 0% <ø> (ø) ⬆️
plume-models/src/comments.rs 0% <0%> (ø) ⬆️
src/inbox.rs 0% <0%> (ø) ⬆️
src/routes/comments.rs 0% <0%> (ø) ⬆️
plume-models/src/posts.rs 12.01% <0%> (-0.65%) ⬇️
plume-models/src/lib.rs 90.56% <0%> (-0.18%) ⬇️
plume-models/src/blogs.rs 59.8% <0%> (-0.14%) ⬇️
src/routes/posts.rs 0% <0%> (ø) ⬆️
src/routes/mod.rs 0% <0%> (ø) ⬆️
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e799f2...0951d98. Read the comment docs.

# [Codecov](https://codecov.io/gh/Plume-org/Plume/pull/363?src=pr&el=h1) Report > Merging [#363](https://codecov.io/gh/Plume-org/Plume/pull/363?src=pr&el=desc) into [master](https://codecov.io/gh/Plume-org/Plume/commit/9e799f2cf224c2d289e0a2de91dec0f513af1854?src=pr&el=desc) will **decrease** coverage by `0.24%`. > The diff coverage is `0%`. [![Impacted file tree graph](https://codecov.io/gh/Plume-org/Plume/pull/363/graphs/tree.svg?width=650&token=sHtxmDuZ06&height=150&src=pr)](https://codecov.io/gh/Plume-org/Plume/pull/363?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #363 +/- ## ========================================== - Coverage 28.29% 28.05% -0.25% ========================================== Files 62 62 Lines 6545 5810 -735 ========================================== - Hits 1852 1630 -222 + Misses 4693 4180 -513 ``` | [Impacted Files](https://codecov.io/gh/Plume-org/Plume/pull/363?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [src/main.rs](https://codecov.io/gh/Plume-org/Plume/pull/363/diff?src=pr&el=tree#diff-c3JjL21haW4ucnM=) | `0% <ø> (ø)` | :arrow_up: | | [plume-models/src/comments.rs](https://codecov.io/gh/Plume-org/Plume/pull/363/diff?src=pr&el=tree#diff-cGx1bWUtbW9kZWxzL3NyYy9jb21tZW50cy5ycw==) | `0% <0%> (ø)` | :arrow_up: | | [src/inbox.rs](https://codecov.io/gh/Plume-org/Plume/pull/363/diff?src=pr&el=tree#diff-c3JjL2luYm94LnJz) | `0% <0%> (ø)` | :arrow_up: | | [src/routes/comments.rs](https://codecov.io/gh/Plume-org/Plume/pull/363/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcy9jb21tZW50cy5ycw==) | `0% <0%> (ø)` | :arrow_up: | | [plume-models/src/posts.rs](https://codecov.io/gh/Plume-org/Plume/pull/363/diff?src=pr&el=tree#diff-cGx1bWUtbW9kZWxzL3NyYy9wb3N0cy5ycw==) | `12.01% <0%> (-0.65%)` | :arrow_down: | | [plume-models/src/lib.rs](https://codecov.io/gh/Plume-org/Plume/pull/363/diff?src=pr&el=tree#diff-cGx1bWUtbW9kZWxzL3NyYy9saWIucnM=) | `90.56% <0%> (-0.18%)` | :arrow_down: | | [plume-models/src/blogs.rs](https://codecov.io/gh/Plume-org/Plume/pull/363/diff?src=pr&el=tree#diff-cGx1bWUtbW9kZWxzL3NyYy9ibG9ncy5ycw==) | `59.8% <0%> (-0.14%)` | :arrow_down: | | [src/routes/posts.rs](https://codecov.io/gh/Plume-org/Plume/pull/363/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcy9wb3N0cy5ycw==) | `0% <0%> (ø)` | :arrow_up: | | [src/routes/mod.rs](https://codecov.io/gh/Plume-org/Plume/pull/363/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcy9tb2QucnM=) | `0% <0%> (ø)` | :arrow_up: | | ... and [13 more](https://codecov.io/gh/Plume-org/Plume/pull/363/diff?src=pr&el=tree-more) | | ------ [Continue to review full report at Codecov](https://codecov.io/gh/Plume-org/Plume/pull/363?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/Plume-org/Plume/pull/363?src=pr&el=footer). Last update [9e799f2...0951d98](https://codecov.io/gh/Plume-org/Plume/pull/363?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
trinity-1686a reviewed 5 years ago
templates/partials/comment.rs.html
@ -13,3 +13,3 @@
</a>
</a>
@if let Some(ref ap_url) = comm.ap_url {
<a class="u-url" href="@ap_url"></a>
trinity-1686a commented 5 years ago
Poster
Owner

There is a 100% chance my vim is still fucking up the indent in html templates, I have no idea why but in those rs.html it absolutely want to add tabs everywhere

There is a 100% chance my vim is still fucking up the indent in html templates, I have no idea why but in those rs.html it absolutely want to add tabs everywhere
elegaanz commented 5 years ago (Migrated from github.com)

I improved a bit the deletion button style, I don't know if there anything else that would need better styling.

2018-12-23-101854_418x115_scrot

I improved a bit the deletion button style, I don't know if there anything else that would need better styling. ![2018-12-23-101854_418x115_scrot](https://user-images.githubusercontent.com/16254623/50382308-97071780-069c-11e9-8b08-489db6b85834.png)
trinity-1686a commented 5 years ago
Poster
Owner

No, that was all

No, that was all
👍 1
elegaanz (Migrated from github.com) approved these changes 5 years ago
elegaanz (Migrated from github.com) left a comment

Then, we can merge I think.

Then, we can merge I think.

Reviewers

elegaanz
The pull request has been merged as 5c5cf36b0d.
You can also view command line instructions.

Step 1:

From your project repository, check out a new branch and test the changes.
git checkout -b delete-comment master
git pull origin delete-comment

Step 2:

Merge the changes and update on Forgejo.
git checkout master
git merge --no-ff delete-comment
git push origin master
Sign in to join this conversation.
Reviewers
Request review
No reviewers
elegaanz
Labels
Apply labels
Clear labels   
A: API

Related to the REST API   
A: Backend

Code running on the server   
A: Federation

Stuff related to Federation   
A: Front-End

Related to the front-end   
A: I18N

Translations, and related code   
A: Meta

More about project management or code than the project itself   
A: Security
   
Build

The building, or installation process of Plume   
C: Bug

Something isn't working   
C: Discussion

We need to talk   
C: Enhancement

New feature or request   
C: Feature

This is a new feature   
Compatibility

Compatibility with different browsers, readers and OS   
Dependency

Related to an external package that Plume uses   
Design

UI/UX related issues and PRs   
Documentation
   
Good first issue

Good for newcomers   
Help welcome

Extra attention is needed   
Mobile

Issues affecting only mobile UX   
Rendering

How elements're rendered out for the end user   
S: Blocked

Something else needs to be fixed first   
S: Duplicate

This issue or pull request already exists   
S: Incomplete

This PR is not complete yet   
S: Instance specific

Issues concern a limited number of instances   
S: Invalid

This doesn't seem right   
S: Needs Voting/Discussion

Need to be discussed by the community (on Loomio)   
S: Ready for review

This PR is ready to be reviewed   
Suggestion

Proposed ideas worth considering   
S: Voted on Loomio

This is issue has been created after a vote on Loomio   
S: Wontfix

This will not be worked on
No Label
A: API
A: Backend
A: Federation
A: Front-End
A: I18N
A: Meta
A: Security
Build
C: Bug
C: Discussion
C: Enhancement
C: Feature
Compatibility
Dependency
Design
Documentation
Good first issue
Help welcome
Mobile
Rendering
S: Blocked
S: Duplicate
S: Incomplete
S: Instance specific
S: Invalid
S: Needs Voting/Discussion
S: Ready for review
Suggestion
S: Voted on Loomio
S: Wontfix
Milestone
Set milestone
Clear milestone
No items
No Milestone
Assignees
Assign users
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Plume/Plume#363
Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'delete-comment'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes