Allow for comment deletion #363

Merged
Plume_migration_agent merged 3 commits from delete-comment into master 2018-12-23 10:13:36 +00:00

Fix #224

Current design is a bit terrible. I've tried things, only made it worse. If someone better than me at CSS could give it a try

This tries to conserve as much threads as possible, by re-linking comments to the parent of the one being deleted

Fix #224 Current design is a bit terrible. I've tried things, only made it worse. If someone better than me at CSS could give it a try This tries to conserve as much threads as possible, by re-linking comments to the parent of the one being deleted
igalic commented 2018-12-17 20:04:53 +00:00 (Migrated from github.com)

we could do the reddit thing and leave a greyed out deleted box. that might be easiest.

we could do the reddit thing and leave a greyed out `deleted` box. that might be easiest.
Author
Owner

My problem is not with deleted comment, I just delete them. It's with the delete button itself

My problem is not with deleted comment, I just delete them. It's with the delete button itself
igalic (Migrated from github.com) reviewed 2018-12-17 20:10:13 +00:00
igalic (Migrated from github.com) left a comment

just 👀

just 👀
@ -1,4 +1,4 @@
use activitypub::{activity::Create, link, object::Note};
use activitypub::{activity::{Create, Delete}, link, object::{Note, Tombstone}};
use chrono::{self, NaiveDateTime};
igalic (Migrated from github.com) commented 2018-12-17 20:07:49 +00:00

Tombstone… sounds cool

Tombstone… sounds cool
@ -13,3 +13,3 @@
</a>
</a>
@if let Some(ref ap_url) = comm.ap_url {
<a class="u-url" href="@ap_url"></a>
igalic (Migrated from github.com) commented 2018-12-17 20:06:56 +00:00

why this indent?

why this indent?
trinity-1686a reviewed 2018-12-17 20:11:48 +00:00
@ -1,4 +1,4 @@
use activitypub::{activity::Create, link, object::Note};
use activitypub::{activity::{Create, Delete}, link, object::{Note, Tombstone}};
use chrono::{self, NaiveDateTime};
Author
Owner

It's what you need to live behind when deleting things (as opposed to undoing)

It's what you need to live behind when deleting things (as opposed to undoing)
codecov[bot] commented 2018-12-17 20:13:50 +00:00 (Migrated from github.com)

Codecov Report

Merging #363 into master will decrease coverage by 0.24%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #363      +/-   ##
==========================================
- Coverage   28.29%   28.05%   -0.25%     
==========================================
  Files          62       62              
  Lines        6545     5810     -735     
==========================================
- Hits         1852     1630     -222     
+ Misses       4693     4180     -513
Impacted Files Coverage Δ
src/main.rs 0% <ø> (ø) ⬆️
plume-models/src/comments.rs 0% <0%> (ø) ⬆️
src/inbox.rs 0% <0%> (ø) ⬆️
src/routes/comments.rs 0% <0%> (ø) ⬆️
plume-models/src/posts.rs 12.01% <0%> (-0.65%) ⬇️
plume-models/src/lib.rs 90.56% <0%> (-0.18%) ⬇️
plume-models/src/blogs.rs 59.8% <0%> (-0.14%) ⬇️
src/routes/posts.rs 0% <0%> (ø) ⬆️
src/routes/mod.rs 0% <0%> (ø) ⬆️
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e799f2...0951d98. Read the comment docs.

# [Codecov](https://codecov.io/gh/Plume-org/Plume/pull/363?src=pr&el=h1) Report > Merging [#363](https://codecov.io/gh/Plume-org/Plume/pull/363?src=pr&el=desc) into [master](https://codecov.io/gh/Plume-org/Plume/commit/9e799f2cf224c2d289e0a2de91dec0f513af1854?src=pr&el=desc) will **decrease** coverage by `0.24%`. > The diff coverage is `0%`. [![Impacted file tree graph](https://codecov.io/gh/Plume-org/Plume/pull/363/graphs/tree.svg?width=650&token=sHtxmDuZ06&height=150&src=pr)](https://codecov.io/gh/Plume-org/Plume/pull/363?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #363 +/- ## ========================================== - Coverage 28.29% 28.05% -0.25% ========================================== Files 62 62 Lines 6545 5810 -735 ========================================== - Hits 1852 1630 -222 + Misses 4693 4180 -513 ``` | [Impacted Files](https://codecov.io/gh/Plume-org/Plume/pull/363?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [src/main.rs](https://codecov.io/gh/Plume-org/Plume/pull/363/diff?src=pr&el=tree#diff-c3JjL21haW4ucnM=) | `0% <ø> (ø)` | :arrow_up: | | [plume-models/src/comments.rs](https://codecov.io/gh/Plume-org/Plume/pull/363/diff?src=pr&el=tree#diff-cGx1bWUtbW9kZWxzL3NyYy9jb21tZW50cy5ycw==) | `0% <0%> (ø)` | :arrow_up: | | [src/inbox.rs](https://codecov.io/gh/Plume-org/Plume/pull/363/diff?src=pr&el=tree#diff-c3JjL2luYm94LnJz) | `0% <0%> (ø)` | :arrow_up: | | [src/routes/comments.rs](https://codecov.io/gh/Plume-org/Plume/pull/363/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcy9jb21tZW50cy5ycw==) | `0% <0%> (ø)` | :arrow_up: | | [plume-models/src/posts.rs](https://codecov.io/gh/Plume-org/Plume/pull/363/diff?src=pr&el=tree#diff-cGx1bWUtbW9kZWxzL3NyYy9wb3N0cy5ycw==) | `12.01% <0%> (-0.65%)` | :arrow_down: | | [plume-models/src/lib.rs](https://codecov.io/gh/Plume-org/Plume/pull/363/diff?src=pr&el=tree#diff-cGx1bWUtbW9kZWxzL3NyYy9saWIucnM=) | `90.56% <0%> (-0.18%)` | :arrow_down: | | [plume-models/src/blogs.rs](https://codecov.io/gh/Plume-org/Plume/pull/363/diff?src=pr&el=tree#diff-cGx1bWUtbW9kZWxzL3NyYy9ibG9ncy5ycw==) | `59.8% <0%> (-0.14%)` | :arrow_down: | | [src/routes/posts.rs](https://codecov.io/gh/Plume-org/Plume/pull/363/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcy9wb3N0cy5ycw==) | `0% <0%> (ø)` | :arrow_up: | | [src/routes/mod.rs](https://codecov.io/gh/Plume-org/Plume/pull/363/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcy9tb2QucnM=) | `0% <0%> (ø)` | :arrow_up: | | ... and [13 more](https://codecov.io/gh/Plume-org/Plume/pull/363/diff?src=pr&el=tree-more) | | ------ [Continue to review full report at Codecov](https://codecov.io/gh/Plume-org/Plume/pull/363?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/Plume-org/Plume/pull/363?src=pr&el=footer). Last update [9e799f2...0951d98](https://codecov.io/gh/Plume-org/Plume/pull/363?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
trinity-1686a reviewed 2018-12-17 20:14:15 +00:00
@ -13,3 +13,3 @@
</a>
</a>
@if let Some(ref ap_url) = comm.ap_url {
<a class="u-url" href="@ap_url"></a>
Author
Owner

There is a 100% chance my vim is still fucking up the indent in html templates, I have no idea why but in those rs.html it absolutely want to add tabs everywhere

There is a 100% chance my vim is still fucking up the indent in html templates, I have no idea why but in those rs.html it absolutely want to add tabs everywhere
elegaanz commented 2018-12-23 09:23:13 +00:00 (Migrated from github.com)

I improved a bit the deletion button style, I don't know if there anything else that would need better styling.

2018-12-23-101854_418x115_scrot

I improved a bit the deletion button style, I don't know if there anything else that would need better styling. ![2018-12-23-101854_418x115_scrot](https://user-images.githubusercontent.com/16254623/50382308-97071780-069c-11e9-8b08-489db6b85834.png)
Author
Owner

No, that was all

No, that was all
elegaanz (Migrated from github.com) approved these changes 2018-12-23 09:36:28 +00:00
elegaanz (Migrated from github.com) left a comment

Then, we can merge I think.

Then, we can merge I think.
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Plume/Plume#363
No description provided.