#370 An attempt to fix disorted submit button on mobile devices like iPhone - please review

Merged
marek-lach merged 3 commits from patch-1 into master 1 year ago
marek-lach commented 1 year ago (Migrated from github.com)
There is no content yet.
elegaanz commented 1 year ago (Migrated from github.com)
Owner

@marek-lach Hello! What was the issue you are trying to fix? I can’t find anything similar to what you describe in the title…

@marek-lach Hello! What was the issue you are trying to fix? I can't find anything similar to what you describe in the title…
codecov[bot] commented 1 year ago (Migrated from github.com)
Owner

Codecov Report

Merging #370 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #370   +/-   ##
=======================================
  Coverage   28.47%   28.47%           
=======================================
  Files          62       62           
  Lines        5706     5706           
=======================================
  Hits         1625     1625           
  Misses       4081     4081
# [Codecov](https://codecov.io/gh/Plume-org/Plume/pull/370?src=pr&el=h1) Report > Merging [#370](https://codecov.io/gh/Plume-org/Plume/pull/370?src=pr&el=desc) into [master](https://codecov.io/gh/Plume-org/Plume/commit/5c5cf36b0d6609127793e22ed315edf5a5c689d2?src=pr&el=desc) will **not change** coverage. > The diff coverage is `n/a`. ```diff @@ Coverage Diff @@ ## master #370 +/- ## ======================================= Coverage 28.47% 28.47% ======================================= Files 62 62 Lines 5706 5706 ======================================= Hits 1625 1625 Misses 4081 4081 ```
marek-lach commented 1 year ago (Migrated from github.com)
Owner

Problem:
When on a mobile device, like an iPhone, the submit comment button gets disorted (i.e. out of shape, squashed) when you press submit. As far as I know, this isn’t the case on the desktop.

Before pressing the submit button for a comment on an iPhone (though I suspect Android’s the same):

img_0551

After pressing the submit button on an iPhone (it works, the distortion is just a visual CSS problem):
img_0552

I am sure the fix for this has to do with responsivness of the submit button, and it must be easy to do, but addmitedly I have no idea, what precisely would fix it, just took a guess.

**Problem:** When on a mobile device, like an iPhone, the submit comment button gets disorted (i.e. out of shape, squashed) when you press submit. As far as I know, this isn't the case on the desktop. Before pressing the submit button for a comment on an iPhone (though I suspect Android's the same): ![img_0551](https://user-images.githubusercontent.com/45913977/50384758-19a1ce00-06c1-11e9-89f4-7e85ca6bcd03.PNG) After pressing the submit button on an iPhone (it works, the distortion is just a visual CSS problem): ![img_0552](https://user-images.githubusercontent.com/45913977/50384770-51107a80-06c1-11e9-92df-8088fd998695.PNG) I am sure the fix for this has to do with responsivness of the submit button, and it must be easy to do, but addmitedly I have no idea, what precisely would fix it, just took a guess.
elegaanz commented 1 year ago (Migrated from github.com)
Owner

This seems to be related to Safari’s rendering engine (I cant’ reproduce on my Android phone), and I have no iPhone to test. If it doesn’t break anything I’ll merge your change, hoping it will fix the issue…

This seems to be related to Safari's rendering engine (I cant' reproduce on my Android phone), and I have no iPhone to test. If it doesn't break anything I'll merge your change, hoping it will fix the issue…
elegaanz (Migrated from github.com) requested changes 1 year ago
elegaanz (Migrated from github.com) left a comment

It doesn’t work: no border is displayed at all… 😕

marek-lach commented 1 year ago (Migrated from github.com)
Owner

Right, couldn’t reproduce the problem on Android. Will try to modify specifically for Safari only then.

Right, couldn't reproduce the problem on Android. Will try to modify specifically for Safari only then.
marek-lach commented 1 year ago (Migrated from github.com)
Owner

Hmm... reverted the change and tried a Safari-specific style. Let me know if the border is back as before with this last commit.

Hmm... reverted the change and tried a Safari-specific style. Let me know if the border is back as before with this last commit.
elegaanz (Migrated from github.com) requested changes 1 year ago
elegaanz (Migrated from github.com) left a comment

I don’t have the issue with borders anymore, but I have some other issues, for instance on the user page:

2018-12-23-163432_362x492_scrot

I think this is the same issue as here: https://stackoverflow.com/a/5438653

marek-lach commented 1 year ago (Migrated from github.com)
Owner

I have reverted all of the changes up to now, and added the suggested webkit-specific fix as advised on stack owerflow. As long as this does not disort anything anywhere else, it might work as a quick solution to the problem for now...

I have reverted all of the changes up to now, and added the suggested webkit-specific fix as advised on stack owerflow. As long as this does not disort anything anywhere else, it might work as a quick solution to the problem for now...
elegaanz (Migrated from github.com) approved these changes 1 year ago
elegaanz (Migrated from github.com) left a comment

Thanks! Looks good now. I hope it will fix your issue.

Reviewers

Plume_migration_agent approved these changes 1 year ago
The pull request has been merged as 2621549f5e.
Sign in to join this conversation.
No Milestone
No Assignees
1 Participants
Notifications
Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

Loading…
There is no content yet.