An attempt to fix disorted submit button on mobile devices like iPhone - please review #370
Нет рецензентов
Метки
Нет меток
A: API
A: Backend
A: Federation
A: Front-End
A: I18N
A: Meta
A: Security
Build
C: Bug
C: Discussion
C: Enhancement
C: Feature
Compatibility
Dependency
Design
Documentation
Good first issue
Help welcome
Mobile
Rendering
S: Blocked
S: Duplicate
S: Incomplete
S: Instance specific
S: Invalid
S: Needs Voting/Discussion
S: Ready for review
Suggestion
S: Voted on Loomio
S: Wontfix
Нет этапа
Нет проекта
Нет назначенных
1 участник
Уведомления
Срок выполнения
Срок выполнения не установлен.
Зависимости
Зависимостей нет.
Ссылка: Plume/Plume#370
Загрузка…
Создание таблицы
Сослаться в новой задаче
Описание отсутствует.
Удалить ветвь «patch-1»
Удаление ветви необратимо. Несмотря на то, что удаленная ветвь может просуществовать некоторое время перед тем, как она будет окончательно удалена, это действие НЕВОЗМОЖНО отменить в большинстве случаев. Продолжить?
@marek-lach Hello! What was the issue you are trying to fix? I can't find anything similar to what you describe in the title…
Codecov Report
Problem:
When on a mobile device, like an iPhone, the submit comment button gets disorted (i.e. out of shape, squashed) when you press submit. As far as I know, this isn't the case on the desktop.
Before pressing the submit button for a comment on an iPhone (though I suspect Android's the same):
After pressing the submit button on an iPhone (it works, the distortion is just a visual CSS problem):

I am sure the fix for this has to do with responsivness of the submit button, and it must be easy to do, but addmitedly I have no idea, what precisely would fix it, just took a guess.
This seems to be related to Safari's rendering engine (I cant' reproduce on my Android phone), and I have no iPhone to test. If it doesn't break anything I'll merge your change, hoping it will fix the issue…
It doesn't work: no border is displayed at all… 😕
Right, couldn't reproduce the problem on Android. Will try to modify specifically for Safari only then.
Hmm... reverted the change and tried a Safari-specific style. Let me know if the border is back as before with this last commit.
I don't have the issue with borders anymore, but I have some other issues, for instance on the user page:
I think this is the same issue as here: https://stackoverflow.com/a/5438653
I have reverted all of the changes up to now, and added the suggested webkit-specific fix as advised on stack owerflow. As long as this does not disort anything anywhere else, it might work as a quick solution to the problem for now...
Thanks! Looks good now. I hope it will fix your issue.