Plume/Plume
8
17
Fork 23
Code Issues 176 Pull requests 9 Releases 8 Wiki Activity

Improve search UI #375

Merged
elegaanz merged 2 commits from search-ui into master 2019-01-28 12:12:57 +00:00
Conversation 6 Commits 2 Files changed 15 +1359 -500
elegaanz commented 2018-12-24 11:31:33 +00:00 (Migrated from github.com)
Copy link
  • Add a link to the search page in the header
  • Translate it

I also removed placeholders because there were not adding much value, and were making the code harder to read when translated (I don't know if it was really a good idea, maybe we should keep them ?).

- Add a link to the search page in the header - Translate it I also removed placeholders because there were not adding much value, and were making the code harder to read when translated (I don't know if it was really a good idea, maybe we should keep them ?).
trinity-1686a commented 2018-12-24 11:51:49 +00:00
Owner
Copy link

Whoops all this got totally off my mind. I don't like where is placed the search button when connected, but I see no better place to put it. Concerning placeholders, I think it feel a bit empty without them 😐

Whoops all this got totally off my mind. I don't like where is placed the search button when connected, but I see no better place to put it. Concerning placeholders, I think it feel a bit empty without them :neutral_face:
codecov[bot] commented 2018-12-24 11:57:15 +00:00 (Migrated from github.com)
Copy link

Codecov Report

Merging #375 into master will decrease coverage by 0.02%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master     #375      +/-   ##
==========================================
- Coverage    28.3%   28.27%   -0.03%     
==========================================
  Files          63       63              
  Lines        5949     5955       +6     
==========================================
  Hits         1684     1684              
- Misses       4265     4271       +6
# [Codecov](https://codecov.io/gh/Plume-org/Plume/pull/375?src=pr&el=h1) Report > Merging [#375](https://codecov.io/gh/Plume-org/Plume/pull/375?src=pr&el=desc) into [master](https://codecov.io/gh/Plume-org/Plume/commit/fdfeeed6d9fa9dec92862366a8b646eb27d17422?src=pr&el=desc) will **decrease** coverage by `0.02%`. > The diff coverage is `0%`. ```diff @@ Coverage Diff @@ ## master #375 +/- ## ========================================== - Coverage 28.3% 28.27% -0.03% ========================================== Files 63 63 Lines 5949 5955 +6 ========================================== Hits 1684 1684 - Misses 4265 4271 +6 ```
codecov[bot] commented 2018-12-24 11:57:15 +00:00 (Migrated from github.com)
Copy link

Codecov Report

Merging #375 into master will decrease coverage by 0.02%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master     #375      +/-   ##
==========================================
- Coverage   27.64%   27.62%   -0.03%     
==========================================
  Files          63       63              
  Lines        7336     7342       +6     
==========================================
  Hits         2028     2028              
- Misses       5308     5314       +6
# [Codecov](https://codecov.io/gh/Plume-org/Plume/pull/375?src=pr&el=h1) Report > Merging [#375](https://codecov.io/gh/Plume-org/Plume/pull/375?src=pr&el=desc) into [master](https://codecov.io/gh/Plume-org/Plume/commit/a2ddfb0ee91c575bb0d9c1d42944a78e75f9669f?src=pr&el=desc) will **decrease** coverage by `0.02%`. > The diff coverage is `0%`. ```diff @@ Coverage Diff @@ ## master #375 +/- ## ========================================== - Coverage 27.64% 27.62% -0.03% ========================================== Files 63 63 Lines 7336 7342 +6 ========================================== Hits 2028 2028 - Misses 5308 5314 +6 ```
elegaanz commented 2018-12-24 12:20:14 +00:00 (Migrated from github.com)
Copy link

Ok, I'll had placeholders back. And for the button, maybe putting it before the Dashboard button?

Ok, I'll had placeholders back. And for the button, maybe putting it before the Dashboard button?
trinity-1686a commented 2018-12-24 12:29:46 +00:00
Owner
Copy link

I tried, it's maybe a bit better. I think my issue is there start to be maybe too many buttons here, maybe replacing the /me link with a drop-down where you can also logout and see your dashboard? But that would need it's own pr I think

I tried, it's maybe a bit better. I think my issue is there start to be maybe too many buttons here, maybe replacing the /me link with a drop-down where you can also logout and see your dashboard? But that would need it's own pr I think
👍 1
trinity-1686a approved these changes 2019-01-28 10:05:29 +00:00
trinity-1686a left a comment
Owner
Copy link

sorry to react so late, I did not notice you added placeholders back while merging before

sorry to react so late, I did not notice you added placeholders back while merging before
elegaanz commented 2019-01-28 12:12:49 +00:00 (Migrated from github.com)
Copy link

No problem. 🙂

No problem. :slightly_smiling_face:
Sign in to join this conversation.
Reviewers
No reviewers
trinity-1686a
Labels
Clear labels   
A: API

Related to the REST API

  
A: Backend

Code running on the server

  
A: Federation

Stuff related to Federation

  
A: Front-End

Related to the front-end

  
A: I18N

Translations, and related code

  
A: Meta

More about project management or code than the project itself

  
A: Security

   
Build

The building, or installation process of Plume

  
C: Bug

Something isn't working

  
C: Discussion

We need to talk

  
C: Enhancement

New feature or request

  
C: Feature

This is a new feature

  
Compatibility

Compatibility with different browsers, readers and OS

  
Dependency

Related to an external package that Plume uses

  
Design

UI/UX related issues and PRs

  
Documentation

   
Good first issue

Good for newcomers

  
Help welcome

Extra attention is needed

  
Mobile

Issues affecting only mobile UX

  
Rendering

How elements're rendered out for the end user

  
S: Blocked

Something else needs to be fixed first

  
S: Duplicate

This issue or pull request already exists

  
S: Incomplete

This PR is not complete yet

  
S: Instance specific

Issues concern a limited number of instances

  
S: Invalid

This doesn't seem right

  
S: Needs Voting/Discussion

Need to be discussed by the community (on Loomio)

  
S: Ready for review

This PR is ready to be reviewed

  
Suggestion

Proposed ideas worth considering

  
S: Voted on Loomio

This is issue has been created after a vote on Loomio

  
S: Wontfix

This will not be worked on

No labels
A: API
A: Backend
A: Federation
A: Front-End
A: I18N
A: Meta
A: Security
Build
C: Bug
C: Discussion
C: Enhancement
C: Feature
Compatibility
Dependency
Design
Documentation
Good first issue
Help welcome
Mobile
Rendering
S: Blocked
S: Duplicate
S: Incomplete
S: Instance specific
S: Invalid
S: Needs Voting/Discussion
S: Ready for review
Suggestion
S: Voted on Loomio
S: Wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Plume/Plume#375
No description provided.
Delete branch "search-ui"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?