try to fetch user when receiving an invalid signature
regenerate new key-pair when sending Delete activity

Codecov Report

Merging #399 into master will increase coverage by 0.21%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master     #399      +/-   ##
==========================================
+ Coverage   27.87%   28.08%   +0.21%     
==========================================
  Files          63       63              
  Lines        7254     7405     +151     
==========================================
+ Hits         2022     2080      +58     
- Misses       5232     5325      +93

igalic (Migrated from github.com) reviewed 1 year ago

👀

src/routes/user.rs

Plume_migration_agent commented 1 year ago

should we be printing stuff here?

trinity-1686a reviewed 1 year ago

src/routes/user.rs

trinity-1686a commented 1 year ago

I kept it because it was here before. If we had a proper logger this should get logged as this could be a an attack trial, but as it is, lost in stdout, I guess it’s more of a debugging print?

igalic (Migrated from github.com) reviewed 1 year ago

src/routes/user.rs

Plume_migration_agent commented 1 year ago

i was wondering where our (debugging) log was

elegaanz (Migrated from github.com) reviewed 1 year ago

The code looks right, but I think I found a bug (maybe it’s only me). To reproduce:

Create a@plume.one and b@plume.two
Make them follow each other
a@plume.one posts two articles, they are received on plume.two as they should
a@plume.one deletes one of these articles, and it is deleted on plume.two too
a@plume.one waits more than 10 minutes, and delete the second article
the Delete activity gets rejected by plume.two

Edit: also note that the next activities from a@plume.one are correctly received by plume.two

elegaanz (Migrated from github.com) approved these changes 1 year ago

It is working now. 👍 (but I don’t understand what was wrong with the previous condition, and this one doesn’t make sense for me)

previously, the first if would match in case of invalid request, and the second would do exactly the same, match on invalid request. But the first block is the Ok(()) one, so on invalid request it would say “ok this is fine”.
Now the condition for the second if is inverted, so when the request is valid it returns Ok(()), when the request is invalid it returns the signature error

👍 2

Reviewers

Plume_migration_agent approved these changes 1 year ago

The pull request has been merged as c4a4ea5b6c.

Plume_migration_agent

A: Backend

A: Federation

A: Security

C: Feature

S: Ready for review

No Milestone

No Assignees

2 Participants

Notifications

Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

#399 Support blind key rotation

Codecov Report

Reviewers