Support blind key rotation #399
No reviewers
Labels
No labels
A: API
A: Backend
A: Federation
A: Front-End
A: I18N
A: Meta
A: Security
Build
C: Bug
C: Discussion
C: Enhancement
C: Feature
Compatibility
Dependency
Design
Documentation
Good first issue
Help welcome
Mobile
Rendering
S: Blocked
S: Duplicate
S: Incomplete
S: Instance specific
S: Invalid
S: Needs Voting/Discussion
S: Ready for review
Suggestion
S: Voted on Loomio
S: Wontfix
No milestone
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: Plume/Plume#399
Loading…
Add table
Reference in a new issue
No description provided.
Delete branch "blind-key-rotation"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Fix #398
Delete
activityCodecov Report
👀
should we be printing stuff here?
I kept it because it was here before. If we had a proper logger this should get logged as this could be a an attack trial, but as it is, lost in stdout, I guess it's more of a debugging print?
i was wondering where our (debugging) log was
The code looks right, but I think I found a bug (maybe it's only me). To reproduce:
Delete
activity gets rejected by plume.twoEdit: also note that the next activities from a@plume.one are correctly received by plume.two
It is working now. 👍 (but I don't understand what was wrong with the previous condition, and this one doesn't make sense for me)
previously, the first
if
would match in case of invalid request, and the second would do exactly the same, match on invalid request. But the first block is the Ok(()) one, so on invalid request it would say "ok this is fine".Now the condition for the second
if
is inverted, so when the request is valid it returns Ok(()), when the request is invalid it returns the signature error