Support blind key rotation
#399
Zusammengeführt
Plume_migration_agent
hat 3 Commits von blind-key-rotation
nach master
vor 5 Jahren zusammengeführt
Laden…
In neuem Issue referenzieren
Hier gibt es bis jetzt noch keinen Inhalt.
Branch „blind-key-rotation“ löschen
Das Löschen eines Branches ist permanent. Es KANN NICHT rückgängig gemacht werden. Fortfahren?
Fix #398
Delete
activityCodecov Report
👀
should we be printing stuff here?
I kept it because it was here before. If we had a proper logger this should get logged as this could be a an attack trial, but as it is, lost in stdout, I guess it's more of a debugging print?
i was wondering where our (debugging) log was
The code looks right, but I think I found a bug (maybe it's only me). To reproduce:
Delete
activity gets rejected by plume.twoEdit: also note that the next activities from a@plume.one are correctly received by plume.two
It is working now. 👍 (but I don't understand what was wrong with the previous condition, and this one doesn't make sense for me)
previously, the first
if
would match in case of invalid request, and the second would do exactly the same, match on invalid request. But the first block is the Ok(()) one, so on invalid request it would say "ok this is fine".Now the condition for the second
if
is inverted, so when the request is valid it returns Ok(()), when the request is invalid it returns the signature errorReviewer
c4a4ea5b6c
gemergt.Schritt 1:
Wechsle auf einen neuen Branch in deinem lokalen Repository und teste die Änderungen.Schritt 2:
Führe die Änderungen zusammen und aktualisiere den Stand online auf Forgejo.