#401 Fix login issue

Merged
Plume_migration_agent merged 1 commits from fix-login into master 1 year ago

Fix regression introduced by 80a4dae8bd

Fix regression introduced by 80a4dae8bda18139da71ff678a50d4cc6baa27b3
codecov[bot] commented 1 year ago (Migrated from github.com)
Owner

Codecov Report

Merging #401 into master will increase coverage by <.01%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master     #401      +/-   ##
==========================================
+ Coverage   27.87%   27.88%   +<.01%     
==========================================
  Files          63       63              
  Lines        7254     7252       -2     
==========================================
  Hits         2022     2022              
+ Misses       5232     5230       -2
# [Codecov](https://codecov.io/gh/Plume-org/Plume/pull/401?src=pr&el=h1) Report > Merging [#401](https://codecov.io/gh/Plume-org/Plume/pull/401?src=pr&el=desc) into [master](https://codecov.io/gh/Plume-org/Plume/commit/3128e6a3b9963bda81f482e972eb853c0d564d35?src=pr&el=desc) will **increase** coverage by `<.01%`. > The diff coverage is `0%`. ```diff @@ Coverage Diff @@ ## master #401 +/- ## ========================================== + Coverage 27.87% 27.88% +<.01% ========================================== Files 63 63 Lines 7254 7252 -2 ========================================== Hits 2022 2022 + Misses 5232 5230 -2 ```
igalic commented 1 year ago (Migrated from github.com)
Owner

how’d that happen in? 4059a840be

how'd that happen in? https://github.com/Plume-org/Plume/commit/4059a840becdb6fd036593f5a4293d3b324fe62d
igalic (Migrated from github.com) approved these changes 1 year ago
igalic (Migrated from github.com) left a comment

👍

trinity-1686a commented 1 year ago
Owner

I tagged the wrong commit 😬

I tagged the wrong commit :grimacing:
igalic commented 1 year ago (Migrated from github.com)
Owner

that seems more likely
i blame myself for not reading that entire pr 😅

that seems more likely i blame myself for not reading that entire pr 😅

Reviewers

Plume_migration_agent approved these changes 1 year ago
The pull request has been merged as 2896eb1705.
Sign in to join this conversation.
No Milestone
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

Loading…
There is no content yet.