Better contrast for input fields #417

2019-01-08T18:32:52Z

dfeyer がコメント

2019-01-08 18:32:52 +00:00

(github.comから移行)

This change set a white background for input field (text, select and textarea)
to have a better contrast with the page background and improve accessibility for
people with vision problem, and just crappy screen.

This change also remove the round corner for the input to have a clear difference
between editing field and buttons.

This max-width of the form element are a bit bigger too.

This change set a white background for input field (text, select and textarea) to have a better contrast with the page background and improve accessibility for people with vision problem, and just crappy screen. This change also remove the round corner for the input to have a clear difference between editing field and buttons. This max-width of the form element are a bit bigger too.

dfeyer がコメント

2019-01-08 18:33:46 +00:00

(github.comから移行)

Screenshot are better than a long description

Screenshot are better than a long description ![image](https://user-images.githubusercontent.com/221173/50851373-efb50080-137c-11e9-8211-ebac3dae5489.png)

👍 2

dfeyer (github.comから移行) がレビュー 2019-01-08 18:39:23 +00:00

static/css/_forms.scss

dfeyer (github.comから移行) がコメント

2019-01-08 18:34:50 +00:00

This will enforce the max-width for all element inside so we don't have to define the max-width for every element that can be used in a form element

static/css/_forms.scss

dfeyer (github.comから移行) がコメント

2019-01-08 18:39:17 +00:00

I don't have the full history of the project so I don't know why you use a different box sizing here ?

static/css/_global.scss

					
				@ -49,3 +49,3 @@

				body > main > *, .h-feed > * {

				 	padding: 0 20%;

				 	margin: 0 20%;

				}

dfeyer (github.comから移行) がコメント

2019-01-08 18:35:19 +00:00

Needed to set the max-width on form element, should not break anything

dfeyer がコメント

2019-01-09 12:32:58 +00:00

(github.comから移行)

I forgot to say that the margin between to label and the input are smaller with this change, to make the block (label+input/textarea) more "solid".

An other issue we have here is the too low color contrast between the help text/button and the background, will try to solve this in an other PR

I forgot to say that the margin between to label and the input are smaller with this change, to make the block (label+input/textarea) more "solid". An other issue we have here is the too low color contrast between the help text/button and the background, will try to solve this in an other PR

👍 2

elegaanz (github.comから移行) が変更を承認 2019-01-09 16:25:49 +00:00

elegaanz (github.comから移行) がコメント

Thanks a lot! It indeed greatly improves contrast. My only concern is that buttons seem a bit inconsistent with the rest of the design now, since they are the only elements with slightly rounded corners (everything else has sharp angles, expecting avatars that are totally rounded). Otherwise it looks great! Thanks again.

static/css/_forms.scss

elegaanz (github.comから移行) がコメント

2019-01-09 16:17:33 +00:00

I don't remember either 😅

I don't remember either :sweat_smile:

static/css/_global.scss

					
				@ -49,3 +49,3 @@

				body > main > *, .h-feed > * {

				 	padding: 0 20%;

				 	margin: 0 20%;

				}

elegaanz (github.comから移行) がコメント

2019-01-09 16:16:46 +00:00

I think it broke the article list on the profile page, but that's not a real problem. However if you want to fix it, just replace padding with margin in .cards too.

I think it broke the article list on the profile page, but that's not a real problem. However if you want to fix it, just replace `padding` with `margin` in `.cards` too.

elegaanz (github.comから移行) がコメント

2019-01-09 16:17:09 +00:00

(and actually it is not broken, just different from what we currently have)

dfeyer がコメント

2019-01-09 16:30:35 +00:00

(github.comから移行)

My only concern is that buttons seem a bit inconsistent

@BaptisteGelez Button are my next topic, will need a better visual language to make them different from input, but not too much. Maybe playing with the height of the element, and use plume violet color for the primary action as a background color. Will push an other PR when my design research are more advanced, will try to prototype on figma and share the design here before the implementation.

> My only concern is that buttons seem a bit inconsistent @BaptisteGelez Button are my next topic, will need a better visual language to make them different from input, but not too much. Maybe playing with the height of the element, and use plume violet color for the primary action as a background color. Will push an other PR when my design research are more advanced, will try to prototype on figma and share the design here before the implementation.

👍 1

elegaanz がコメント

2019-01-09 16:41:44 +00:00

(github.comから移行)

Okay! Then unless you want to fix this little "issue": https://github.com/Plume-org/Plume/pull/417#discussion_r246444928 I will merge this PR (but I'm totally fine merging it as it is if you don't want to take the time to do the change, I completely understand).

dfeyer がコメント

2019-01-09 16:48:14 +00:00

(github.comから移行)

Let's merge this one, and I can fix the margin of cards in an other PR, I hate swapping padding / margin all the time, so maybe we can found a cleaner solution.

👍 2

codecov[bot] がコメント

2019-01-09 17:55:34 +00:00

(github.comから移行)

Codecov Report

Merging #417 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #417   +/-   ##
=======================================
  Coverage   27.64%   27.64%           
=======================================
  Files          63       63           
  Lines        7336     7336           
=======================================
  Hits         2028     2028           
  Misses       5308     5308

# [Codecov](https://codecov.io/gh/Plume-org/Plume/pull/417?src=pr&el=h1) Report > Merging [#417](https://codecov.io/gh/Plume-org/Plume/pull/417?src=pr&el=desc) into [master](https://codecov.io/gh/Plume-org/Plume/commit/0490b698cbab7833b171e684bd9f47bbc1260407?src=pr&el=desc) will **not change** coverage. > The diff coverage is `n/a`. ```diff @@ Coverage Diff @@ ## master #417 +/- ## ======================================= Coverage 27.64% 27.64% ======================================= Files 63 63 Lines 7336 7336 ======================================= Hits 2028 2028 Misses 5308 5308 ```

サインインしてこの会話に参加。

レビューアなし

elegaanz

マイルストーンなし

プロジェクトなし

担当者なし

1 人の参加者

通知

期日

期日が正しくないか範囲を超えています。 "yyyy-mm-dd" の形式で入力してください。

期日は未設定です。

依存関係

依存関係が設定されていません。

リファレンス: Plume/Plume#417

Rows
Columns