Plume
/
Plume
7
9
Fork 8
Code Issues 132 Pull Requests 13 Releases 4 Wiki Activity
Labels Milestones
New Pull Request

#444 Add a page listing people someone follows

Merged
elegaanz merged 5 commits from follows-page into master 1 year ago
Conversation 2 Commits 5 Files Changed 24
elegaanz commented 1 year ago (Migrated from github.com)

Nothing exceptional, the layout is the same as the followers page.

Fixes #325

Nothing exceptional, the layout is the same as the followers page. Fixes #325
codecov[bot] commented 1 year ago (Migrated from github.com)
Owner

Codecov Report

Merging #444 into master will increase coverage by 0.18%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master     #444      +/-   ##
==========================================
+ Coverage   25.58%   25.76%   +0.18%     
==========================================
  Files          63       63              
  Lines        6254     6477     +223     
==========================================
+ Hits         1600     1669      +69     
- Misses       4654     4808     +154
# [Codecov](https://codecov.io/gh/Plume-org/Plume/pull/444?src=pr&el=h1) Report > Merging [#444](https://codecov.io/gh/Plume-org/Plume/pull/444?src=pr&el=desc) into [master](https://codecov.io/gh/Plume-org/Plume/commit/576a4ed49946545af1e2ef8db5058f840c05c8df?src=pr&el=desc) will **increase** coverage by `0.18%`. > The diff coverage is `0%`. ```diff @@ Coverage Diff @@ ## master #444 +/- ## ========================================== + Coverage 25.58% 25.76% +0.18% ========================================== Files 63 63 Lines 6254 6477 +223 ========================================== + Hits 1600 1669 +69 - Misses 4654 4808 +154 ```
trinity-1686a reviewed 1 year ago
trinity-1686a left a comment

👍

igalic (Migrated from github.com) reviewed 1 year ago
igalic (Migrated from github.com) left a comment

words are hard…

plume-models/src/users.rs
@@ -580,0 +586,4 @@
.map_err(Error::from)
}

pub fn get_followed_page(&self, conn: &Connection, (min, max): (i32, i32)) -> Result<Vec<User>> {
Plume_migration_agent commented 1 year ago

n.b.: many people on the fediverse are not happy with the “clout” that comes from these numbers

do we offer an option to disable it?

i would also suggest considering “subscribe” instead of “follow”.
it fits better with a blog, and has slightly less of a cult meaning

n.b.: many people on the fediverse are not happy with the "clout" that comes from these numbers do we offer an option to disable it? i would also suggest considering "subscribe" instead of "follow". it fits better with a blog, and has slightly less of a cult meaning
elegaanz (Migrated from github.com) reviewed 1 year ago
plume-models/src/users.rs
@@ -580,0 +586,4 @@
.map_err(Error::from)
}

pub fn get_followed_page(&self, conn: &Connection, (min, max): (i32, i32)) -> Result<Vec<User>> {
Plume_migration_agent commented 1 year ago

These numbers are not currently displayed in the UI, we only use this function to know how many pages listing followers/followed we need. If we display them one day, I totally agree that we should be able to hide them (maybe even hide them by default?), or that they should only be shown for your own profile.

And I agree on “follow”/“subscribe” too, I will change it. 🙂

These numbers are not currently displayed in the UI, we only use this function to know how many pages listing followers/followed we need. If we display them one day, I totally agree that we should be able to hide them (maybe even hide them by default?), or that they should only be shown for your own profile. And I agree on "follow"/"subscribe" too, I will change it. :slightly_smiling_face:
igalic (Migrated from github.com) reviewed 1 year ago
igalic (Migrated from github.com) left a comment

🇩🇪 / 🇦🇹

po/plume/de.po
Plume_migration_agent commented 1 year ago

not quite… “Abonoment” would be a better translation.

not quite… "Abonoment" would be a better translation.
Plume_migration_agent commented 1 year ago

“Abonomenten”

"Abonomenten"
po/plume/de.po
@@ -338,15 +341,19 @@ msgstr "Ändere dein Profil"
msgid "Open on {0}"
Plume_migration_agent commented 1 year ago

“abonieren”

"abonieren"
Plume_migration_agent commented 1 year ago

“abbestellen”

"abbestellen"
elegaanz (Migrated from github.com) reviewed 1 year ago
po/plume/de.po
Plume_migration_agent commented 1 year ago

Yes, these strings have probably been automatically translated by GetText… 😕 I will edit them.

Yes, these strings have probably been automatically translated by GetText… :confused: I will edit them.
trinity-1686a reviewed 1 year ago
trinity-1686a left a comment

(there are still 7 times the word “follow” and it’s derivative in translations, so I believe it must not be gone everywhere, but this is not the main point of this pr)

elegaanz commented 1 year ago (Migrated from github.com)
Owner

I replaced the other occurrences of “follow” while we are at it.

I replaced the other occurrences of "follow" while we are at it.
trinity-1686a approved these changes 1 year ago
trinity-1686a left a comment

👍

Reviewers

trinity-1686a approved these changes 1 year ago
The pull request has been merged as e28371bbe4.
Sign in to join this conversation.
Reviewers
Request review
No reviewers
 trinity-1686a
Labels
Apply labels
Clear labels
A: API
Related to the REST API A: Backend
Code running on the server A: Federation
Stuff related to Federation A: Front-End
Related to the front-end A: I18N
Translations, and related code A: Meta
More about project management or code than the project itself A: Security Build
The building, or installation process of Plume C: Bug
Something isn't working C: Discussion
We need to talk C: Enhancement
New feature or request C: Feature
This is a new feature Compatibility
Compatibility with different browsers, readers and OS Dependency
Related to an external package that Plume uses Design
UI/UX related issues and PRs Documentation Good first issue
Good for newcomers Help welcome
Extra attention is needed Mobile
Issues affecting only mobile UX Rendering
How elements're rendered out for the end user S: Blocked
Something else needs to be fixed first S: Duplicate
This issue or pull request already exists S: Incomplete
This PR is not complete yet S: Instance specific
Issues concern a limited number of instances S: Invalid
This doesn't seem right S: Needs Voting/Discussion
Need to be discussed by the community (on Loomio) S: Ready for review
This PR is ready to be reviewed Suggestion
Proposed ideas worth considering S: Voted on Loomio
This is issue has been created after a vote on Loomio S: Wontfix
This will not be worked on
No Label
A: API
A: Backend
A: Federation
A: Front-End
A: I18N
A: Meta
A: Security
Build
C: Bug
C: Discussion
C: Enhancement
C: Feature
Compatibility
Dependency
Design
Documentation
Good first issue
Help welcome
Mobile
Rendering
S: Blocked
S: Duplicate
S: Incomplete
S: Instance specific
S: Invalid
S: Needs Voting/Discussion
S: Ready for review
Suggestion
S: Voted on Loomio
S: Wontfix
Milestone
Set milestone
Clear milestone
No items
No Milestone
Assignees
Assign users
Clear assignees
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'follows-page'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes