Use a grid to display the list of media
Add icons for non-image media preview
Paginate the gallery
Add links to the gallery in the editor and in the profile settings to make it more discoverable when you need it

Here are some screenshots:

screenshot_2019-02-26 nouvel article plume screenshot_2019-02-26 modifier votre compte plume

Fixes #432

🎉 1

Codecov Report

Merging #452 into master will increase coverage by 1%.
The diff coverage is 19.64%.

@@            Coverage Diff            @@
##           master     #452     +/-   ##
=========================================
+ Coverage   25.73%   26.74%     +1%     
=========================================
  Files          63       64      +1     
  Lines        6150     7223   +1073     
=========================================
+ Hits         1583     1932    +349     
- Misses       4567     5291    +724

trinity-1686a reviewed 1 year ago

It feel a bit odd there are nice pictures for non image files on /media, but not on /media/<id> , otherwise this is all good

trinity-1686a reviewed 1 year ago

plume-models/src/safe_string.rs

trinity-1686a commented 1 year ago

I’m not a big fan off allowing custom class, peoples could inject div/a with the right classes to mess up the interface. I’d prefer maybe an “unsafe” (not necessary in the sens of rust’s unsafe) builder for SafeString, with the contract that things put in it must already be trusted

trinity-1686a reviewed 1 year ago

plume-models/src/medias.rs

trinity-1686a commented 1 year ago

~~the alt and title can’t be trusted (and trusted is unnecessary here)~~ they are actually escaped, but url might be partially untrusted

plume-models/src/medias.rs

trinity-1686a commented 1 year ago

~~title can’t be trusted. I don’t know how to handle this one. Maybe have some way of concatenating SafeString, and do concat(trusted("<div></div>"),new("<audio/>"))~~
title is actually escaped, but url might be partially untrusted atm

plume-models/src/medias.rs

trinity-1686a commented 1 year ago

~~title can’t be trusted (and would be unnecessary here if we keep video/audio allowed)~~
title is actually escaped, but url might be partially untrusted atm

plume-models/src/safe_string.rs

												
			@@ -22,3 +22,3 @@
		
			            .add_tags(iter::once("iframe"))
		
			            .add_tags(&[ "iframe", "video", "audio" ])
		
			            .id_prefix(Some("postcontent-"))
		
			            .url_relative(UrlRelative::Custom(Box::new(url_add_prefix)))