Slightly improve the media experience #452

Merged
elegaanz merged 5 commits from better-media into master 3 years ago
elegaanz commented 3 years ago (Migrated from github.com)
Owner
  • Use a grid to display the list of media
  • Add icons for non-image media preview
  • Paginate the gallery
  • Add links to the gallery in the editor and in the profile settings to make it more discoverable when you need it

Here are some screenshots:

screenshot_2019-02-26 vos medias plume
screenshot_2019-02-26 nouvel article plume
screenshot_2019-02-26 modifier votre compte plume

Fixes #432

- Use a grid to display the list of media - Add icons for non-image media preview - Paginate the gallery - Add links to the gallery in the editor and in the profile settings to make it more discoverable when you need it Here are some screenshots: ![screenshot_2019-02-26 vos medias plume](https://user-images.githubusercontent.com/16254623/53444828-70a08800-3a0f-11e9-97ee-a7a265287623.png) ![screenshot_2019-02-26 nouvel article plume](https://user-images.githubusercontent.com/16254623/53444832-74cca580-3a0f-11e9-9f9a-29460480ec24.png) ![screenshot_2019-02-26 modifier votre compte plume](https://user-images.githubusercontent.com/16254623/53444842-7bf3b380-3a0f-11e9-82d9-fbfd06b3f753.png) Fixes #432
codecov[bot] commented 3 years ago (Migrated from github.com)
Owner

Codecov Report

Merging #452 into master will increase coverage by 1%.
The diff coverage is 19.64%.

@@            Coverage Diff            @@
##           master     #452     +/-   ##
=========================================
+ Coverage   25.73%   26.74%     +1%     
=========================================
  Files          63       64      +1     
  Lines        6150     7223   +1073     
=========================================
+ Hits         1583     1932    +349     
- Misses       4567     5291    +724
# [Codecov](https://codecov.io/gh/Plume-org/Plume/pull/452?src=pr&el=h1) Report > Merging [#452](https://codecov.io/gh/Plume-org/Plume/pull/452?src=pr&el=desc) into [master](https://codecov.io/gh/Plume-org/Plume/commit/e28371bbe4bda5d338ae453a1fbe198f3dc74071?src=pr&el=desc) will **increase** coverage by `1%`. > The diff coverage is `19.64%`. ```diff @@ Coverage Diff @@ ## master #452 +/- ## ========================================= + Coverage 25.73% 26.74% +1% ========================================= Files 63 64 +1 Lines 6150 7223 +1073 ========================================= + Hits 1583 1932 +349 - Misses 4567 5291 +724 ```
trinity-1686a reviewed 3 years ago
trinity-1686a left a comment

It feel a bit odd there are nice pictures for non image files on /media, but not on /media/<id> , otherwise this is all good

trinity-1686a reviewed 3 years ago
Owner

I'm not a big fan off allowing custom class, peoples could inject div/a with the right classes to mess up the interface. I'd prefer maybe an "unsafe" (not necessary in the sens of rust's unsafe) builder for SafeString, with the contract that things put in it must already be trusted

I'm not a big fan off allowing custom class, peoples could inject div/a with the right classes to mess up the interface. I'd prefer maybe an "unsafe" (not necessary in the sens of rust's unsafe) builder for SafeString, with the contract that things put in it must already be trusted
trinity-1686a reviewed 3 years ago
Owner

the alt and title can't be trusted (and trusted is unnecessary here) they are actually escaped, but url might be partially untrusted

~~the alt and title can't be trusted (and trusted is unnecessary here)~~ they are actually escaped, but url might be partially untrusted
Owner

title can't be trusted. I don't know how to handle this one. Maybe have some way of concatenating SafeString, and do concat(trusted("<div></div>"),new("<audio/>"))
title is actually escaped, but url might be partially untrusted atm

~~title can't be trusted. I don't know how to handle this one. Maybe have some way of concatenating SafeString, and do `concat(trusted("<div></div>"),new("<audio/>"))`~~ title is actually escaped, but url might be partially untrusted atm
Owner

title can't be trusted (and would be unnecessary here if we keep video/audio allowed)
title is actually escaped, but url might be partially untrusted atm

~~title can't be trusted (and would be unnecessary here if we keep video/audio allowed)~~ title is actually escaped, but url might be partially untrusted atm
.add_tags(iter::once("iframe"))
.add_tags(&[ "iframe", "video", "audio" ])
.id_prefix(Some("postcontent-"))
.url_relative(UrlRelative::Custom(Box::new(url_add_prefix)))
Owner

I think we should keep video and audio tags, So that people can insert media content in their posts

I think we should keep video and audio tags, So that people can insert media content in their posts
trinity-1686a approved these changes 3 years ago
trinity-1686a left a comment

👍

Reviewers

trinity-1686a approved these changes 3 years ago
The pull request has been merged as eff2698664.
Sign in to join this conversation.
No reviewers
No Milestone
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

Loading…
There is no content yet.