Slightly improve the media experience #452

trinity-1686a · 2019-02-26T20:46:15Z

elegaanz commented

2019-02-26 20:46:15 +00:00

(Migrated from github.com)

Use a grid to display the list of media
Add icons for non-image media preview
Paginate the gallery
Add links to the gallery in the editor and in the profile settings to make it more discoverable when you need it

Here are some screenshots:

Fixes #432

- Use a grid to display the list of media - Add icons for non-image media preview - Paginate the gallery - Add links to the gallery in the editor and in the profile settings to make it more discoverable when you need it Here are some screenshots: ![screenshot_2019-02-26 vos medias plume](https://user-images.githubusercontent.com/16254623/53444828-70a08800-3a0f-11e9-97ee-a7a265287623.png) ![screenshot_2019-02-26 nouvel article plume](https://user-images.githubusercontent.com/16254623/53444832-74cca580-3a0f-11e9-9f9a-29460480ec24.png) ![screenshot_2019-02-26 modifier votre compte plume](https://user-images.githubusercontent.com/16254623/53444842-7bf3b380-3a0f-11e9-82d9-fbfd06b3f753.png) Fixes #432

🎉 1

codecov[bot] commented

2019-02-26 21:07:51 +00:00

(Migrated from github.com)

Codecov Report

Merging #452 into master will increase coverage by 1%.
The diff coverage is 19.64%.

@@            Coverage Diff            @@
##           master     #452     +/-   ##
=========================================
+ Coverage   25.73%   26.74%     +1%     
=========================================
  Files          63       64      +1     
  Lines        6150     7223   +1073     
=========================================
+ Hits         1583     1932    +349     
- Misses       4567     5291    +724

# [Codecov](https://codecov.io/gh/Plume-org/Plume/pull/452?src=pr&el=h1) Report > Merging [#452](https://codecov.io/gh/Plume-org/Plume/pull/452?src=pr&el=desc) into [master](https://codecov.io/gh/Plume-org/Plume/commit/e28371bbe4bda5d338ae453a1fbe198f3dc74071?src=pr&el=desc) will **increase** coverage by `1%`. > The diff coverage is `19.64%`. ```diff @@ Coverage Diff @@ ## master #452 +/- ## ========================================= + Coverage 25.73% 26.74% +1% ========================================= Files 63 64 +1 Lines 6150 7223 +1073 ========================================= + Hits 1583 1932 +349 - Misses 4567 5291 +724 ```

trinity-1686a reviewed 2019-03-04 19:10:07 +00:00

trinity-1686a left a comment

It feel a bit odd there are nice pictures for non image files on /media, but not on /media/<id> , otherwise this is all good

It feel a bit odd there are nice pictures for non image files on `/media`, but not on `/media/<id>` , otherwise this is all good

trinity-1686a reviewed 2019-03-06 09:40:17 +00:00

plume-models/src/safe_string.rs

trinity-1686a commented

2019-03-06 09:40:12 +00:00

I'm not a big fan off allowing custom class, peoples could inject div/a with the right classes to mess up the interface. I'd prefer maybe an "unsafe" (not necessary in the sens of rust's unsafe) builder for SafeString, with the contract that things put in it must already be trusted

trinity-1686a reviewed 2019-03-06 10:15:13 +00:00

plume-models/src/medias.rs

trinity-1686a commented

2019-03-06 10:08:07 +00:00

~~the alt and title can't be trusted (and trusted is unnecessary here)~~ they are actually escaped, but url might be partially untrusted

~~the alt and title can't be trusted (and trusted is unnecessary here)~~ they are actually escaped, but url might be partially untrusted

plume-models/src/medias.rs

trinity-1686a commented

2019-03-06 10:10:43 +00:00

~~title can't be trusted. I don't know how to handle this one. Maybe have some way of concatenating SafeString, and do concat(trusted("<div></div>"),new("<audio/>"))~~
title is actually escaped, but url might be partially untrusted atm

~~title can't be trusted. I don't know how to handle this one. Maybe have some way of concatenating SafeString, and do `concat(trusted("<div></div>"),new("<audio/>"))`~~ title is actually escaped, but url might be partially untrusted atm

plume-models/src/medias.rs

trinity-1686a commented

2019-03-06 10:11:30 +00:00

~~title can't be trusted (and would be unnecessary here if we keep video/audio allowed)~~
title is actually escaped, but url might be partially untrusted atm

~~title can't be trusted (and would be unnecessary here if we keep video/audio allowed)~~ title is actually escaped, but url might be partially untrusted atm

plume-models/src/safe_string.rs

					
				@ -22,3 +22,3 @@

				            .add_tags(iter::once("iframe"))

				            .add_tags(&[ "iframe", "video", "audio" ])

				            .id_prefix(Some("postcontent-"))

				            .url_relative(UrlRelative::Custom(Box::new(url_add_prefix)))

trinity-1686a commented

2019-03-06 10:09:54 +00:00

I think we should keep video and audio tags, So that people can insert media content in their posts

trinity-1686a approved these changes 2019-03-06 12:57:37 +00:00

trinity-1686a left a comment

👍

:+1:

Sign in to join this conversation.

No reviewers

No milestone

No project

No assignees

2 participants

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Plume/Plume#452

Rows
Columns