Plume
/
Plume
8
16
Fork 22
Koodi Ongelmat 174 Pull-pyynnöt 8 Julkaisut 8 Wiki Toiminta

Tunnisteet Merkkipaalut

Caching #480

Yhdistetty
Plume_migration_agent yhdistetty 3 committia lähteestä cache kohteeseen master 5 vuotta sitten
Keskustelu 1 Commitit 3 Muuttuneet tiedostot 6
trinity-1686a kommentoi 5 vuotta sitten
Omistaja

Try to cache static resources.
Static non media file's timestamps are hashed at compile tome so that modifying them invalidate old cache.
For some reason, plume-front.wasm isn't loaded from cache, even if it contains the right headers.
I changed nothing and now it is? I guess I'm ok with it
I'll look into adding Etag support too
All response made from templates and not containing a form are now Etag-cached

Try to cache static resources. Static non media file's timestamps are hashed at compile tome so that modifying them invalidate old cache. ~~For some reason, plume-front.wasm isn't loaded from cache, even if it contains the right headers.~~ I changed nothing and now it is? I guess I'm ok with it ~~I'll look into adding Etag support too~~ All response made from templates and not containing a form are now Etag-cached
👍 1 ❤️ 1
igalic (Migrated from github.com) reviewed 5 vuotta sitten
igalic (Migrated from github.com) jätti kommentin

👀

👀
build.rs
@ -5,0 +13,4 @@
.spawn()
.expect("failed find command");
let sort = Command::new("sort")
igalic (Migrated from github.com) kommentoi 5 vuotta sitten

i'd rather this wasn't random, but deterministic

such as the file's she256sum

i'd rather this wasn't random, but deterministic such as the file's she256sum
trinity-1686a reviewed 5 vuotta sitten
build.rs
@ -5,0 +13,4 @@
.spawn()
.expect("failed find command");
let sort = Command::new("sort")
trinity-1686a kommentoi 5 vuotta sitten
Tekijä
Omistaja

What is your issue with it being random? It's fixed at compile time, so assuming a production server, which may restart but won't recompile often, the cache will be ok. My first through was using git commit sha, but this may be unnecessary information disclosure

What is your issue with it being random? It's fixed at compile time, so assuming a production server, which may restart but won't recompile often, the cache will be ok. My first through was using git commit sha, but this may be unnecessary information disclosure
igalic (Migrated from github.com) reviewed 5 vuotta sitten
build.rs
@ -5,0 +13,4 @@
.spawn()
.expect("failed find command");
let sort = Command::new("sort")
igalic (Migrated from github.com) kommentoi 5 vuotta sitten

if nothing about the code changes, the cache_id shouldn't change either

if nothing about the code changes, the cache_id shouldn't change either
codecov[bot] kommentoi 5 vuotta sitten (Migrated from github.com)

Codecov Report

Merging #480 into master will decrease coverage by 0.31%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master     #480      +/-   ##
==========================================
- Coverage   27.13%   26.82%   -0.32%     
==========================================
  Files          64       64              
  Lines        7337     7423      +86     
==========================================
  Hits         1991     1991              
- Misses       5346     5432      +86
# [Codecov](https://codecov.io/gh/Plume-org/Plume/pull/480?src=pr&el=h1) Report > Merging [#480](https://codecov.io/gh/Plume-org/Plume/pull/480?src=pr&el=desc) into [master](https://codecov.io/gh/Plume-org/Plume/commit/90baf9beb1884a886d4f2bf9df96f761c582d765?src=pr&el=desc) will **decrease** coverage by `0.31%`. > The diff coverage is `0%`. ```diff @@ Coverage Diff @@ ## master #480 +/- ## ========================================== - Coverage 27.13% 26.82% -0.32% ========================================== Files 64 64 Lines 7337 7423 +86 ========================================== Hits 1991 1991 - Misses 5346 5432 +86 ```
elegaanz (Migrated from github.com) reviewed 5 vuotta sitten
build.rs
@ -5,0 +13,4 @@
.spawn()
.expect("failed find command");
let sort = Command::new("sort")
elegaanz (Migrated from github.com) kommentoi 5 vuotta sitten

The build won't be run again if the code didn't changed, so the ID will not change.

The build won't be run again if the code didn't changed, so the ID will not change.
elegaanz (Migrated from github.com) reviewed 5 vuotta sitten
build.rs
elegaanz (Migrated from github.com) kommentoi 5 vuotta sitten

You should probably remove it from Cargo.toml too.

You should probably remove it from `Cargo.toml` too.
trinity-1686a reviewed 5 vuotta sitten
build.rs
trinity-1686a kommentoi 5 vuotta sitten
Tekijä
Omistaja

I totally forgot about that

I totally forgot about that
igalic (Migrated from github.com) reviewed 5 vuotta sitten
build.rs
@ -5,0 +13,4 @@
.spawn()
.expect("failed find command");
let sort = Command::new("sort")
igalic (Migrated from github.com) kommentoi 5 vuotta sitten

yes, in our development environment that is true, but not for anyone building packages or container images of our software. they always start from a clean slate

yes, in our development environment that is true, but not for anyone building packages or container images of our software. they always start from a clean slate
igalic (Migrated from github.com) reviewed 5 vuotta sitten
igalic (Migrated from github.com) jätti kommentin

👍

👍
build.rs
@ -5,0 +13,4 @@
.spawn()
.expect("failed find command");
let sort = Command::new("sort")
igalic (Migrated from github.com) kommentoi 5 vuotta sitten

btw, is there no way to do this in rust?

btw, is there no way to do this in rust?
trinity-1686a reviewed 5 vuotta sitten
build.rs
@ -5,0 +13,4 @@
.spawn()
.expect("failed find command");
let sort = Command::new("sort")
trinity-1686a kommentoi 5 vuotta sitten
Tekijä
Omistaja

I think there are plenty, but I'm lazy and it's a build script. I prototyped using bash, so my rust code is basically bash translated (if you find it really bad, I can change that but I don't know if it's really useful)

I think there are plenty, but I'm lazy and it's a build script. I prototyped using bash, so my rust code is basically bash translated (if you find it really bad, I can change that but I don't know if it's really useful)
igalic (Migrated from github.com) reviewed 5 vuotta sitten
build.rs
@ -5,0 +13,4 @@
.spawn()
.expect("failed find command");
let sort = Command::new("sort")
igalic (Migrated from github.com) kommentoi 5 vuotta sitten

nah, i was just curious

nah, i was just curious
elegaanz (Migrated from github.com) reviewed 5 vuotta sitten
src/template_utils.rs
@ -11,0 +37,4 @@
.merge(HtmlCt(self.0).respond_to(r)?)
.header(ETag(EntityTag::strong(etag)))
.ok()
}
elegaanz (Migrated from github.com) kommentoi 5 vuotta sitten

Probably obvious, but why do we disable caching on pages with a form?

Probably obvious, but why do we disable caching on pages with a form?
trinity-1686a reviewed 5 vuotta sitten
src/template_utils.rs
@ -11,0 +37,4 @@
.merge(HtmlCt(self.0).respond_to(r)?)
.header(ETag(EntityTag::strong(etag)))
.ok()
}
trinity-1686a kommentoi 5 vuotta sitten
Tekijä
Omistaja

If the page contain a form, the csrf token will be cached, and may no longer match user's cookies. As these tokens are added later by a fairing, there is no way to detect the page changed here. The other solution could be to allow caching of page and for rocket_csrf to remove ETag when appropriate

If the page contain a form, the csrf token will be cached, and may no longer match user's cookies. As these tokens are added later by a fairing, there is no way to detect the page changed here. The other solution could be to allow caching of page and for rocket_csrf to remove ETag when appropriate
elegaanz (Migrated from github.com) hyväksyi nämä muutokset 5 vuotta sitten
elegaanz (Migrated from github.com) jätti kommentin

👍 Thanks!

:+1: Thanks!

Reviewers

elegaanz
The pull request has been merged as a2b2e37aa0.
You can also view command line instructions.

Vaihe 1:

From your project repository, check out a new branch and test the changes.
git checkout -b cache master
git pull origin cache

Vaihe 2:

Merge the changes and update on Forgejo.
git checkout master
git merge --no-ff cache
git push origin master
Sign in to join this conversation.
Reviewers
Request review
No reviewers
elegaanz
Tunnisteet
Aseta tunniste
Tyhjennä tunnisteet   
A: API

Related to the REST API   
A: Backend

Code running on the server   
A: Federation

Stuff related to Federation   
A: Front-End

Related to the front-end   
A: I18N

Translations, and related code   
A: Meta

More about project management or code than the project itself   
A: Security
   
Build

The building, or installation process of Plume   
C: Bug

Something isn't working   
C: Discussion

We need to talk   
C: Enhancement

New feature or request   
C: Feature

This is a new feature   
Compatibility

Compatibility with different browsers, readers and OS   
Dependency

Related to an external package that Plume uses   
Design

UI/UX related issues and PRs   
Documentation
   
Good first issue

Good for newcomers   
Help welcome

Extra attention is needed   
Mobile

Issues affecting only mobile UX   
Rendering

How elements're rendered out for the end user   
S: Blocked

Something else needs to be fixed first   
S: Duplicate

This issue or pull request already exists   
S: Incomplete

This PR is not complete yet   
S: Instance specific

Issues concern a limited number of instances   
S: Invalid

This doesn't seem right   
S: Needs Voting/Discussion

Need to be discussed by the community (on Loomio)   
S: Ready for review

This PR is ready to be reviewed   
Suggestion

Proposed ideas worth considering   
S: Voted on Loomio

This is issue has been created after a vote on Loomio   
S: Wontfix

This will not be worked on
Ei tunnistetta
A: API
A: Backend
A: Federation
A: Front-End
A: I18N
A: Meta
A: Security
Build
C: Bug
C: Discussion
C: Enhancement
C: Feature
Compatibility
Dependency
Design
Documentation
Good first issue
Help welcome
Mobile
Rendering
S: Blocked
S: Duplicate
S: Incomplete
S: Instance specific
S: Invalid
S: Needs Voting/Discussion
S: Ready for review
Suggestion
S: Voted on Loomio
S: Wontfix
Merkkipaalu
Aseta merkkipaalu
Tyhjennä merkkipaalu
Ei kohteita
Ei merkkipaalua
Käsittelijä
Osoita käyttäjille
Tyhjennä käsittelijä
Ei käsittelijää
2 osallistujaa
Ilmoitukset
Määräpäivä
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

Määräpäivää ei asetettu.

Riippuvuudet

Riippuvuuksia ei asetettu.

Reference: Plume/Plume#480
Kirjoita Esikatselu
Ladataan…
Peruuta
Tallenna
Sisältöä ei vielä ole.
Poista haara 'cache'

Deleting a branch is permanent. It CANNOT be undone. Continue?

Ei
Kyllä