Plume/Plume
9
18
Fork 24
Code Issues 177 Pull requests 8 Releases 8 Wiki Activity

Add markdown support for summary #482

Merged
Plume_migration_agent merged 4 commits from summary-md into master 2019-03-17 19:11:29 +00:00
Conversation 4 Commits 4 Files changed 12 +79 -12
trinity-1686a commented 2019-03-16 14:31:17 +00:00
Owner
Copy link

I should probably add a new field to keep raw md
Fixes #247

I should probably add a new field to keep raw md Fixes #247
👍 1
elegaanz commented 2019-03-16 15:11:48 +00:00 (Migrated from github.com)
Copy link

Also once #460 is merged, it would be interesting to use the "inline" mode for Markdown that was introduced, to avoid having profiles with big images or titles in their summaries.

Also once #460 is merged, it would be interesting to use the "inline" mode for Markdown that was introduced, to avoid having profiles with big images or titles in their summaries.
👍 1
codecov[bot] commented 2019-03-16 15:12:40 +00:00 (Migrated from github.com)
Copy link

Codecov Report

Merging #482 into master will increase coverage by 0.19%.
The diff coverage is 57.14%.

@@            Coverage Diff             @@
##           master     #482      +/-   ##
==========================================
+ Coverage   26.82%   27.01%   +0.19%     
==========================================
  Files          64       64              
  Lines        7423     7432       +9     
==========================================
+ Hits         1991     2008      +17     
+ Misses       5432     5424       -8
# [Codecov](https://codecov.io/gh/Plume-org/Plume/pull/482?src=pr&el=h1) Report > Merging [#482](https://codecov.io/gh/Plume-org/Plume/pull/482?src=pr&el=desc) into [master](https://codecov.io/gh/Plume-org/Plume/commit/a2b2e37aa0099aac451067ebf4526aa82f5eca51?src=pr&el=desc) will **increase** coverage by `0.19%`. > The diff coverage is `57.14%`. ```diff @@ Coverage Diff @@ ## master #482 +/- ## ========================================== + Coverage 26.82% 27.01% +0.19% ========================================== Files 64 64 Lines 7423 7432 +9 ========================================== + Hits 1991 2008 +17 + Misses 5432 5424 -8 ```
elegaanz (Migrated from github.com) reviewed 2019-03-16 15:57:19 +00:00
elegaanz (Migrated from github.com) left a comment
Copy link

👌

:ok_hand:
elegaanz (Migrated from github.com) approved these changes 2019-03-16 16:41:53 +00:00
elegaanz (Migrated from github.com) left a comment
Copy link

Even more 👌 now that the tests work.

Even more :ok_hand: now that the tests work.
igalic commented 2019-03-16 17:34:42 +00:00 (Migrated from github.com)
Copy link

idea for testing migrations: run the setup, then run redo

would make a lot more sense of we had done test data, too 😅

idea for testing migrations: run the setup, then run `redo` ----- would make a lot more sense of we had done test data, too 😅
trinity-1686a commented 2019-03-16 17:39:58 +00:00
Author
Owner
Copy link

I don't know how to do that in Travis, but it's actually what I'm doing on my computer

I don't know how to do that in Travis, but it's actually what I'm doing on my computer
Sign in to join this conversation.
Reviewers
No reviewers
elegaanz
Labels
Clear labels   
A: API

Related to the REST API

  
A: Backend

Code running on the server

  
A: Federation

Stuff related to Federation

  
A: Front-End

Related to the front-end

  
A: I18N

Translations, and related code

  
A: Meta

More about project management or code than the project itself

  
A: Security

   
Build

The building, or installation process of Plume

  
C: Bug

Something isn't working

  
C: Discussion

We need to talk

  
C: Enhancement

New feature or request

  
C: Feature

This is a new feature

  
Compatibility

Compatibility with different browsers, readers and OS

  
Dependency

Related to an external package that Plume uses

  
Design

UI/UX related issues and PRs

  
Documentation

   
Good first issue

Good for newcomers

  
Help welcome

Extra attention is needed

  
Mobile

Issues affecting only mobile UX

  
Rendering

How elements're rendered out for the end user

  
S: Blocked

Something else needs to be fixed first

  
S: Duplicate

This issue or pull request already exists

  
S: Incomplete

This PR is not complete yet

  
S: Instance specific

Issues concern a limited number of instances

  
S: Invalid

This doesn't seem right

  
S: Needs Voting/Discussion

Need to be discussed by the community (on Loomio)

  
S: Ready for review

This PR is ready to be reviewed

  
Suggestion

Proposed ideas worth considering

  
S: Voted on Loomio

This is issue has been created after a vote on Loomio

  
S: Wontfix

This will not be worked on

No labels
A: API
A: Backend
A: Federation
A: Front-End
A: I18N
A: Meta
A: Security
Build
C: Bug
C: Discussion
C: Enhancement
C: Feature
Compatibility
Dependency
Design
Documentation
Good first issue
Help welcome
Mobile
Rendering
S: Blocked
S: Duplicate
S: Incomplete
S: Instance specific
S: Invalid
S: Needs Voting/Discussion
S: Ready for review
Suggestion
S: Voted on Loomio
S: Wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Plume/Plume#482
No description provided.
Delete branch "summary-md"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?