#482 Add markdown support for summary

Merged
Plume_migration_agent merged 4 commits from summary-md into master 1 year ago

I should probably add a new field to keep raw md
Fixes #247

I should probably add a new field to keep raw md Fixes #247
elegaanz commented 1 year ago (Migrated from github.com)
Owner

Also once #460 is merged, it would be interesting to use the “inline” mode for Markdown that was introduced, to avoid having profiles with big images or titles in their summaries.

Also once #460 is merged, it would be interesting to use the "inline" mode for Markdown that was introduced, to avoid having profiles with big images or titles in their summaries.
codecov[bot] commented 1 year ago (Migrated from github.com)
Owner

Codecov Report

Merging #482 into master will increase coverage by 0.19%.
The diff coverage is 57.14%.

@@            Coverage Diff             @@
##           master     #482      +/-   ##
==========================================
+ Coverage   26.82%   27.01%   +0.19%     
==========================================
  Files          64       64              
  Lines        7423     7432       +9     
==========================================
+ Hits         1991     2008      +17     
+ Misses       5432     5424       -8
# [Codecov](https://codecov.io/gh/Plume-org/Plume/pull/482?src=pr&el=h1) Report > Merging [#482](https://codecov.io/gh/Plume-org/Plume/pull/482?src=pr&el=desc) into [master](https://codecov.io/gh/Plume-org/Plume/commit/a2b2e37aa0099aac451067ebf4526aa82f5eca51?src=pr&el=desc) will **increase** coverage by `0.19%`. > The diff coverage is `57.14%`. ```diff @@ Coverage Diff @@ ## master #482 +/- ## ========================================== + Coverage 26.82% 27.01% +0.19% ========================================== Files 64 64 Lines 7423 7432 +9 ========================================== + Hits 1991 2008 +17 + Misses 5432 5424 -8 ```
elegaanz (Migrated from github.com) reviewed 1 year ago
elegaanz (Migrated from github.com) left a comment

👌

elegaanz (Migrated from github.com) approved these changes 1 year ago
elegaanz (Migrated from github.com) left a comment

Even more 👌 now that the tests work.

igalic commented 1 year ago (Migrated from github.com)
Owner

idea for testing migrations: run the setup, then run redo


would make a lot more sense of we had done test data, too 😅

idea for testing migrations: run the setup, then run `redo` ----- would make a lot more sense of we had done test data, too 😅
trinity-1686a commented 1 year ago
Owner

I don’t know how to do that in Travis, but it’s actually what I’m doing on my computer

I don't know how to do that in Travis, but it's actually what I'm doing on my computer

Reviewers

Plume_migration_agent approved these changes 1 year ago
The pull request has been merged as 570d7fe2d0.
Sign in to join this conversation.
No Milestone
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

Loading…
There is no content yet.