#486 Editor improvements

Merged
elegaanz merged 14 commits from editor-improvements into master 1 year ago
elegaanz commented 1 year ago (Migrated from github.com)
  • Make it possible to insert new paragraphs in the article body
  • Make it impossible to copy formatted HTML (to make media insertion from markdown code work correctly)

TODO:

- Make it possible to insert new paragraphs in the article body - Make it impossible to copy formatted HTML (to make media insertion from markdown code work correctly) TODO: - [x] make it possible to escape draft mode - [x] display errors from the server - [x] button to go back to the "normal" editor - [x] Avoid publishing placeholders
trinity-1686a commented 1 year ago
Owner
If I may add to the todo list: https://github.com/Plume-org/Plume/pull/458#issuecomment-473323102
codecov[bot] commented 1 year ago (Migrated from github.com)
Owner

Codecov Report

Merging #486 into master will decrease coverage by 2.26%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #486      +/-   ##
==========================================
- Coverage   26.83%   24.56%   -2.27%     
==========================================
  Files          65       65              
  Lines        9000     7116    -1884     
==========================================
- Hits         2415     1748     -667     
+ Misses       6585     5368    -1217
# [Codecov](https://codecov.io/gh/Plume-org/Plume/pull/486?src=pr&el=h1) Report > Merging [#486](https://codecov.io/gh/Plume-org/Plume/pull/486?src=pr&el=desc) into [master](https://codecov.io/gh/Plume-org/Plume/commit/c7ee779f51729326567a4c4bdeb416d8882f4b0a?src=pr&el=desc) will **decrease** coverage by `2.26%`. > The diff coverage is `n/a`. ```diff @@ Coverage Diff @@ ## master #486 +/- ## ========================================== - Coverage 26.83% 24.56% -2.27% ========================================== Files 65 65 Lines 9000 7116 -1884 ========================================== - Hits 2415 1748 -667 + Misses 6585 5368 -1217 ```
elegaanz commented 1 year ago (Migrated from github.com)
Owner

@fdb-hiroshima Yes, the first one is already fixed, I’ll see for the other. :)

@fdb-hiroshima Yes, the first one is already fixed, I'll see for the other. :)
trinity-1686a reviewed 1 year ago
trinity-1686a commented 1 year ago

I think basic-editor should be permanent, and there would then be a button to re-enable the “advanced” editor

I think basic-editor should be permanent, and there would then be a button to re-enable the "advanced" editor
elegaanz (Migrated from github.com) reviewed 1 year ago
Plume_migration_agent commented 1 year ago

I don’t really know how to name it…

I don't really know how to name it…
trinity-1686a reviewed 1 year ago
trinity-1686a commented 1 year ago

rich text editor?

rich text editor?
trinity-1686a reviewed 1 year ago
trinity-1686a left a comment

It’s a bit sad markdown does not work with the rich editor (cmark see some div so it assumes it’s only html and does not attempt to parse markdown)

elegaanz commented 1 year ago (Migrated from github.com)
Owner

@fdb-hiroshima This should definitely be fixed before merging this branch I think. I will see what I can do.

@fdb-hiroshima This should definitely be fixed before merging this branch I think. I will see what I can do.
trinity-1686a commented 1 year ago
Owner

The only fix I see is, given the following :

<div>some text</div><div>![desc](path/to/picture.png)</div>

Where we are given a single Html("<div>some text</div><div>![desc](path/to/picture.png)</div>"), we could cut it out as ["some text", "![desc](path/to/picture.png)"], call cmark on each of these, and put back the divs

The only fix I see is, given the following : ```html <div>some text</div><div>![desc](path/to/picture.png)</div> ``` Where we are given a single `Html("<div>some text</div><div>![desc](path/to/picture.png)</div>")`, we could cut it out as `["some text", "![desc](path/to/picture.png)"]`, call cmark on each of these, and put back the `div`s
elegaanz commented 1 year ago (Migrated from github.com)
Owner

I was more thinking of pre-processing the HTML with the DOM APIs in WASM, because your solution may break footnotes, or links that use this syntax:

my [link]

[link]: https://example.org
I was more thinking of pre-processing the HTML with the DOM APIs in WASM, because your solution may break footnotes, or links that use this syntax: ``` my [link] [link]: https://example.org ```
igalic (Migrated from github.com) reviewed 1 year ago
igalic (Migrated from github.com) left a comment

please remove the callgrind output files from the PR

trinity-1686a approved these changes 1 year ago

Reviewers

trinity-1686a approved these changes 1 year ago
The pull request has been merged as 1f7ff62c19.
Sign in to join this conversation.
No reviewers
No Milestone
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

Loading…
There is no content yet.