Plume/Plume

Fork 24

Editor improvements #486

Merged

elegaanz merged 14 commits from editor-improvements into master

2019-04-06 13:20:13 +00:00

elegaanz commented

2019-03-16 17:18:50 +00:00

(Migrated from github.com)

Make it possible to insert new paragraphs in the article body
Make it impossible to copy formatted HTML (to make media insertion from markdown code work correctly)

TODO:

make it possible to escape draft mode
display errors from the server
button to go back to the "normal" editor
Avoid publishing placeholders

- Make it possible to insert new paragraphs in the article body - Make it impossible to copy formatted HTML (to make media insertion from markdown code work correctly) TODO: - [x] make it possible to escape draft mode - [x] display errors from the server - [x] button to go back to the "normal" editor - [x] Avoid publishing placeholders

🎉 1

trinity-1686a commented

2019-03-16 17:28:52 +00:00

Owner

If I may add to the todo list: https://github.com/Plume-org/Plume/pull/458#issuecomment-473323102

codecov[bot] commented

2019-03-16 17:56:13 +00:00

(Migrated from github.com)

Codecov Report

Merging #486 into master will decrease coverage by 2.26%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #486      +/-   ##
==========================================
- Coverage   26.83%   24.56%   -2.27%     
==========================================
  Files          65       65              
  Lines        9000     7116    -1884     
==========================================
- Hits         2415     1748     -667     
+ Misses       6585     5368    -1217

# [Codecov](https://codecov.io/gh/Plume-org/Plume/pull/486?src=pr&el=h1) Report > Merging [#486](https://codecov.io/gh/Plume-org/Plume/pull/486?src=pr&el=desc) into [master](https://codecov.io/gh/Plume-org/Plume/commit/c7ee779f51729326567a4c4bdeb416d8882f4b0a?src=pr&el=desc) will **decrease** coverage by `2.26%`. > The diff coverage is `n/a`. ```diff @@ Coverage Diff @@ ## master #486 +/- ## ========================================== - Coverage 26.83% 24.56% -2.27% ========================================== Files 65 65 Lines 9000 7116 -1884 ========================================== - Hits 2415 1748 -667 + Misses 6585 5368 -1217 ```

elegaanz commented

2019-03-16 18:57:16 +00:00

(Migrated from github.com)

@fdb-hiroshima Yes, the first one is already fixed, I'll see for the other. :)

trinity-1686a reviewed 2019-03-19 13:30:11 +00:00

plume-front/src/editor.rs

trinity-1686a commented

2019-03-19 13:29:22 +00:00

Owner

I think basic-editor should be permanent, and there would then be a button to re-enable the "advanced" editor

elegaanz (Migrated from github.com) reviewed 2019-03-19 17:38:56 +00:00

plume-front/src/editor.rs

elegaanz (Migrated from github.com) commented

2019-03-19 17:38:56 +00:00

I don't really know how to name it…

trinity-1686a reviewed 2019-03-19 19:59:15 +00:00

plume-front/src/editor.rs

trinity-1686a commented

2019-03-19 19:59:15 +00:00

Owner

rich text editor?

trinity-1686a reviewed 2019-03-27 08:25:06 +00:00

trinity-1686a left a comment

Owner

It's a bit sad markdown does not work with the rich editor (cmark see some div so it assumes it's only html and does not attempt to parse markdown)

elegaanz commented

2019-03-27 12:28:19 +00:00

(Migrated from github.com)

@fdb-hiroshima This should definitely be fixed before merging this branch I think. I will see what I can do.

trinity-1686a commented

2019-03-27 14:25:46 +00:00

Owner

The only fix I see is, given the following :

<div>some text</div><div>![desc](path/to/picture.png)</div>

Where we are given a single Html("<div>some text</div><div>![desc](path/to/picture.png)</div>"), we could cut it out as ["some text", "![desc](path/to/picture.png)"], call cmark on each of these, and put back the divs

The only fix I see is, given the following : ```html <div>some text</div><div>![desc](path/to/picture.png)</div> ``` Where we are given a single `Html("<div>some text</div><div>![desc](path/to/picture.png)</div>")`, we could cut it out as `["some text", "![desc](path/to/picture.png)"]`, call cmark on each of these, and put back the `div`s

👍 1

elegaanz commented

2019-03-27 15:04:57 +00:00

(Migrated from github.com)

I was more thinking of pre-processing the HTML with the DOM APIs in WASM, because your solution may break footnotes, or links that use this syntax:

my [link]

[link]: https://example.org

I was more thinking of pre-processing the HTML with the DOM APIs in WASM, because your solution may break footnotes, or links that use this syntax: ``` my [link] [link]: https://example.org ```

👍 1

igalic (Migrated from github.com) reviewed 2019-03-27 18:54:23 +00:00

igalic (Migrated from github.com) left a comment

please remove the callgrind output files from the PR

trinity-1686a approved these changes 2019-04-05 13:26:03 +00:00

No reviewers

No milestone

No project

No assignees

2 participants

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Plume/Plume#486

No description provided.

Rows
Columns