Plume/Plume

派生 24

Editor improvements #486

已合并

elegaanz 已将来自 editor-improvements 的 14 提交合并入 master

2019-04-06 13:20:13 +00:00

elegaanz 评论于

2019-03-16 17:18:50 +00:00

(从 github.com 迁移)

Make it possible to insert new paragraphs in the article body
Make it impossible to copy formatted HTML (to make media insertion from markdown code work correctly)

TODO:

make it possible to escape draft mode
display errors from the server
button to go back to the "normal" editor
Avoid publishing placeholders

- Make it possible to insert new paragraphs in the article body - Make it impossible to copy formatted HTML (to make media insertion from markdown code work correctly) TODO: - [x] make it possible to escape draft mode - [x] display errors from the server - [x] button to go back to the "normal" editor - [x] Avoid publishing placeholders

🎉 1

trinity-1686a 评论于

2019-03-16 17:28:52 +00:00

管理员

If I may add to the todo list: https://github.com/Plume-org/Plume/pull/458#issuecomment-473323102

codecov[bot] 评论于

2019-03-16 17:56:13 +00:00

(从 github.com 迁移)

Codecov Report

Merging #486 into master will decrease coverage by 2.26%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #486      +/-   ##
==========================================
- Coverage   26.83%   24.56%   -2.27%     
==========================================
  Files          65       65              
  Lines        9000     7116    -1884     
==========================================
- Hits         2415     1748     -667     
+ Misses       6585     5368    -1217

# [Codecov](https://codecov.io/gh/Plume-org/Plume/pull/486?src=pr&el=h1) Report > Merging [#486](https://codecov.io/gh/Plume-org/Plume/pull/486?src=pr&el=desc) into [master](https://codecov.io/gh/Plume-org/Plume/commit/c7ee779f51729326567a4c4bdeb416d8882f4b0a?src=pr&el=desc) will **decrease** coverage by `2.26%`. > The diff coverage is `n/a`. ```diff @@ Coverage Diff @@ ## master #486 +/- ## ========================================== - Coverage 26.83% 24.56% -2.27% ========================================== Files 65 65 Lines 9000 7116 -1884 ========================================== - Hits 2415 1748 -667 + Misses 6585 5368 -1217 ```

elegaanz 评论于

2019-03-16 18:57:16 +00:00

(从 github.com 迁移)

@fdb-hiroshima Yes, the first one is already fixed, I'll see for the other. :)

trinity-1686a 评审于 2019-03-19 13:30:11 +00:00

plume-front/src/editor.rs

trinity-1686a 评论于

2019-03-19 13:29:22 +00:00

管理员

I think basic-editor should be permanent, and there would then be a button to re-enable the "advanced" editor

elegaanz (从 github.com 迁移) 评审于 2019-03-19 17:38:56 +00:00

plume-front/src/editor.rs

elegaanz (从 github.com 迁移) 评论于

2019-03-19 17:38:56 +00:00

I don't really know how to name it…

trinity-1686a 评审于 2019-03-19 19:59:15 +00:00

plume-front/src/editor.rs

trinity-1686a 评论于

2019-03-19 19:59:15 +00:00

管理员

rich text editor?

trinity-1686a 评审于 2019-03-27 08:25:06 +00:00

trinity-1686a 留下了一条评论

管理员

It's a bit sad markdown does not work with the rich editor (cmark see some div so it assumes it's only html and does not attempt to parse markdown)

elegaanz 评论于

2019-03-27 12:28:19 +00:00

(从 github.com 迁移)

@fdb-hiroshima This should definitely be fixed before merging this branch I think. I will see what I can do.

trinity-1686a 评论于

2019-03-27 14:25:46 +00:00

管理员

The only fix I see is, given the following :

<div>some text</div><div>![desc](path/to/picture.png)</div>

Where we are given a single Html("<div>some text</div><div>![desc](path/to/picture.png)</div>"), we could cut it out as ["some text", "![desc](path/to/picture.png)"], call cmark on each of these, and put back the divs

The only fix I see is, given the following : ```html <div>some text</div><div>![desc](path/to/picture.png)</div> ``` Where we are given a single `Html("<div>some text</div><div>![desc](path/to/picture.png)</div>")`, we could cut it out as `["some text", "![desc](path/to/picture.png)"]`, call cmark on each of these, and put back the `div`s

👍 1

elegaanz 评论于

2019-03-27 15:04:57 +00:00

(从 github.com 迁移)

I was more thinking of pre-processing the HTML with the DOM APIs in WASM, because your solution may break footnotes, or links that use this syntax:

my [link]

[link]: https://example.org

I was more thinking of pre-processing the HTML with the DOM APIs in WASM, because your solution may break footnotes, or links that use this syntax: ``` my [link] [link]: https://example.org ```

👍 1

igalic (从 github.com 迁移) 评审于 2019-03-27 18:54:23 +00:00

igalic (从 github.com 迁移) 留下了一条评论

please remove the callgrind output files from the PR

trinity-1686a 于 2019-04-05 13:26:03 +00:00 批准此合并请求

登录并参与到对话中。

无评审员

未选择里程碑

暂无项目

未指派成员

2 位参与者

通知

到期时间

到期日期无效或超出范围。请使用“yyyy-mm-dd”格式。

未设置到期时间。

依赖工单

没有设置依赖项。

引用：Plume/Plume#486

没有提供说明。

行数
列数