Plume/Plume

Fork 24

Run 'cargo fmt' to format code #489

Merged

Atul9 merged 1 commit from format-using-cargo-fmt into master

2019-03-20 16:56:18 +00:00

Atul9 commented

2019-03-19 17:10:47 +00:00

(Migrated from github.com)

No description provided.

👍 1

codecov[bot] commented

2019-03-19 17:45:35 +00:00

(Migrated from github.com)

Codecov Report

Merging #489 into master will decrease coverage by 0.62%.
The diff coverage is 24.39%.

@@            Coverage Diff             @@
##           master     #489      +/-   ##
==========================================
- Coverage    27.3%   26.67%   -0.63%     
==========================================
  Files          64       64              
  Lines        7582     8713    +1131     
==========================================
+ Hits         2070     2324     +254     
- Misses       5512     6389     +877

# [Codecov](https://codecov.io/gh/Plume-org/Plume/pull/489?src=pr&el=h1) Report > Merging [#489](https://codecov.io/gh/Plume-org/Plume/pull/489?src=pr&el=desc) into [master](https://codecov.io/gh/Plume-org/Plume/commit/732f514da7aa5090f5277d44fbd8feedc4c54e79?src=pr&el=desc) will **decrease** coverage by `0.62%`. > The diff coverage is `24.39%`. ```diff @@ Coverage Diff @@ ## master #489 +/- ## ========================================== - Coverage 27.3% 26.67% -0.63% ========================================== Files 64 64 Lines 7582 8713 +1131 ========================================== + Hits 2070 2324 +254 - Misses 5512 6389 +877 ```

elegaanz (Migrated from github.com) reviewed 2019-03-19 17:47:03 +00:00

elegaanz (Migrated from github.com) left a comment

Hey, thank you! Would you want to try to add it to the CI too? (it's fine if you don't, we can totally do that in another PR)

Atul9 commented

2019-03-19 17:51:38 +00:00

(Migrated from github.com)

Hi @BaptisteGelez I would like to add it. I am new to Plume project. Can you please point me to where in the .travis.yml file can cargo fmt be added?

Hi @BaptisteGelez I would like to add it. I am new to Plume project. Can you please point me to where in the .travis.yml file can `cargo fmt` be added?

👍 1

elegaanz commented

2019-03-19 18:38:36 +00:00

(Migrated from github.com)

You can probably add a new item at the end of the jobs section, in the "test and coverage" stage (I'm not sure if this indication is clear enough, tell me if it is not 😅)

You can probably add a new item at the end of the `jobs` section, in the "test and coverage" stage (I'm not sure if this indication is clear enough, tell me if it is not :sweat_smile:)

igalic commented

2019-03-19 20:17:50 +00:00

(Migrated from github.com)

given that the usual way to run rustfmt is in "check" mode, we can probably run it as first job. and from what i gather, rustfmt doesn't care about features, and just formats all code? or? did it format the test code, too?

given that the usual way to run `rustfmt` is in "check" mode, we can probably run it as first job. and from what i gather, `rustfmt` doesn't care about features, and just formats all code? or? did it format the test code, too?

Atul9 commented

2019-03-20 03:35:23 +00:00

(Migrated from github.com)

If the code isn't formatted ('rustfmt' will exit with 1 if there is an error in formatting - https://github.com/rust-lang/rustfmt#running) then is it still ok to go to the build stage?
Suggestion: We can add a check stage which will run before the build stage.
@BaptisteGelez @igalic What do you think?

If the code isn't formatted ('rustfmt' will exit with 1 if there is an error in formatting - https://github.com/rust-lang/rustfmt#running) then is it still ok to go to the build stage? Suggestion: We can add a `check` stage which will run before the build stage. @BaptisteGelez @igalic What do you think?

👍 2

Atul9 commented

2019-03-20 16:11:39 +00:00

(Migrated from github.com)

@BaptisteGelez @igalic I tried adding cargo fmt but the CI fails for weird reason.

I tried locally but I didn't get this error - https://travis-ci.org/Plume-org/Plume/jobs/508992511#L584 & nor did it fail for the build before adding cargo fmt to travis.yml.

I tried to fix that but the build fails - https://travis-ci.org/Plume-org/Plume/jobs/509005663#L589

The build for this PR had passed before adding cargo fmt to travis build stages - https://travis-ci.org/Plume-org/Plume/builds/508519598

I suggest we can add cargo fmt to CI in another PR.

@BaptisteGelez @igalic I tried adding cargo fmt but the CI fails for weird reason. I tried locally but I didn't get this error - https://travis-ci.org/Plume-org/Plume/jobs/508992511#L584 & nor did it fail for the build before adding `cargo fmt` to travis.yml. I tried to fix that but the build fails - https://travis-ci.org/Plume-org/Plume/jobs/509005663#L589 The build for this PR had passed before adding `cargo fmt` to travis build stages - https://travis-ci.org/Plume-org/Plume/builds/508519598 I suggest we can add `cargo fmt` to CI in another PR.

👍 1

elegaanz commented

2019-03-20 16:33:28 +00:00

(Migrated from github.com)

OK, no problem. I'll merge this as soon as you'll have reverted the changes to .travis.yml. And thank you again for your work. 🙂

OK, no problem. I'll merge this as soon as you'll have reverted the changes to `.travis.yml`. And thank you again for your work. :slightly_smiling_face:

Atul9 commented

2019-03-20 16:51:25 +00:00

(Migrated from github.com)

@BaptisteGelez done. I have updated the PR.

👍 1

elegaanz (Migrated from github.com) approved these changes 2019-03-20 16:55:56 +00:00