Run 'cargo fmt' to format code
#489
Birleştirildi
Atul9
5 yıl önce format-using-cargo-fmt
içindeki 1 işlemeyi master
ile birleştirdi
Gözden Geçirenler
İnceleme iste
Değerlendirici yok
Etiketler
Etiketleri temizle
Related to the REST API
Code running on the server
Stuff related to Federation
Related to the front-end
Translations, and related code
More about project management or code than the project itself
The building, or installation process of Plume
Something isn't working
We need to talk
New feature or request
This is a new feature
Compatibility with different browsers, readers and OS
Related to an external package that Plume uses
UI/UX related issues and PRs
Good for newcomers
Extra attention is needed
Issues affecting only mobile UX
How elements're rendered out for the end user
Something else needs to be fixed first
This issue or pull request already exists
This PR is not complete yet
Issues concern a limited number of instances
This doesn't seem right
Need to be discussed by the community (on Loomio)
This PR is ready to be reviewed
Proposed ideas worth considering
This is issue has been created after a vote on Loomio
This will not be worked on
Etiketleri uygula
A: API
Related to the REST API
A: Backend
Code running on the server
A: Federation
Stuff related to Federation
A: Front-End
Related to the front-end
A: I18N
Translations, and related code
A: Meta
More about project management or code than the project itself
A: Security
Build
The building, or installation process of Plume
C: Bug
Something isn't working
C: Discussion
We need to talk
C: Enhancement
New feature or request
C: Feature
This is a new feature
Compatibility
Compatibility with different browsers, readers and OS
Dependency
Related to an external package that Plume uses
Design
UI/UX related issues and PRs
Documentation
Good first issue
Good for newcomers
Help welcome
Extra attention is needed
Mobile
Issues affecting only mobile UX
Rendering
How elements're rendered out for the end user
S: Blocked
Something else needs to be fixed first
S: Duplicate
This issue or pull request already exists
S: Incomplete
This PR is not complete yet
S: Instance specific
Issues concern a limited number of instances
S: Invalid
This doesn't seem right
S: Needs Voting/Discussion
Need to be discussed by the community (on Loomio)
S: Ready for review
This PR is ready to be reviewed
Suggestion
Proposed ideas worth considering
S: Voted on Loomio
This is issue has been created after a vote on Loomio
S: Wontfix
This will not be worked on
Etiket Yok
A: API
A: Backend
A: Federation
A: Front-End
A: I18N
A: Meta
A: Security
Build
C: Bug
C: Discussion
C: Enhancement
C: Feature
Compatibility
Dependency
Design
Documentation
Good first issue
Help welcome
Mobile
Rendering
S: Blocked
S: Duplicate
S: Incomplete
S: Instance specific
S: Invalid
S: Needs Voting/Discussion
S: Ready for review
Suggestion
S: Voted on Loomio
S: Wontfix
Kilometre Taşı
Kilometre taşı ayarla
Kilometre Taşlarını Temizle
Öge yok
Kilometre Taşı Yok
Atananlar
Kullanıcı ata
Atamaları Temizle
Atanan Kişi Yok
1 Katılımcı
Bildirimler
Bitiş Tarihi
Bitiş tarihi geçersiz veya aralık dışında. Lütfen 'yyyy-aa-gg' biçimini kullanın.
Bitiş tarihi atanmadı.
Bağımlılıklar
Bağımlılık yok.
Referans: Plume/Plume#489
Yeni konuda referans
Henüz bir içerik yok.
'format-using-cargo-fmt' Dalını Sil
Bir dalı silmek kalıcıdır. GERİ ALINAMAZ. Devam edilsin mi?
Hayır
Evet
Codecov Report
Hey, thank you! Would you want to try to add it to the CI too? (it's fine if you don't, we can totally do that in another PR)
Hi @BaptisteGelez I would like to add it. I am new to Plume project. Can you please point me to where in the .travis.yml file can
cargo fmt
be added?You can probably add a new item at the end of the
jobs
section, in the "test and coverage" stage (I'm not sure if this indication is clear enough, tell me if it is not 😅)given that the usual way to run
rustfmt
is in "check" mode, we can probably run it as first job. and from what i gather,rustfmt
doesn't care about features, and just formats all code? or? did it format the test code, too?If the code isn't formatted ('rustfmt' will exit with 1 if there is an error in formatting - https://github.com/rust-lang/rustfmt#running) then is it still ok to go to the build stage?
Suggestion: We can add a
check
stage which will run before the build stage.@BaptisteGelez @igalic What do you think?
@BaptisteGelez @igalic I tried adding cargo fmt but the CI fails for weird reason.
I tried locally but I didn't get this error - https://travis-ci.org/Plume-org/Plume/jobs/508992511#L584 & nor did it fail for the build before adding
cargo fmt
to travis.yml.I tried to fix that but the build fails - https://travis-ci.org/Plume-org/Plume/jobs/509005663#L589
The build for this PR had passed before adding
cargo fmt
to travis build stages - https://travis-ci.org/Plume-org/Plume/builds/508519598I suggest we can add
cargo fmt
to CI in another PR.OK, no problem. I'll merge this as soon as you'll have reverted the changes to
.travis.yml
. And thank you again for your work. 🙂@BaptisteGelez done. I have updated the PR.
Gözden Geçirenler
b945d1f602
olarak birleştirildi.1. Adım:
Proje deponuzdan yeni bir dala göz atın ve değişiklikleri test edin.2. Adım:
Forgejo'daki değişiklikleri ve güncellemeleri birleştirin.