Fix issue with sqlite migrations for comment_seers #503

已合併

vbrandl merged 1 commit from fix/sqlite-migrations into master

2019-03-26 07:57:47 +00:00

vbrandl 評論

2019-03-25 21:07:39 +00:00

(Migrated from github.com)

This fixes the issue in the sqlite migrations for comment_seers.

The temporary workaround was to change the id column from id INTEGER PRIMARY KEY AUTOINCREMENT to id INTEGER NOT NULL PRIMARY KEY AUTOINCREMENT.

This change renames the table, creates a new table with the correct attributes, copies the old table over in the new one and deletes the old one.

This fixes the issue in the sqlite migrations for `comment_seers`. The temporary workaround was to change the `id` column from `id INTEGER PRIMARY KEY AUTOINCREMENT` to `id INTEGER NOT NULL PRIMARY KEY AUTOINCREMENT`. This change renames the table, creates a new table with the correct attributes, copies the old table over in the new one and deletes the old one.

elegaanz (Migrated from github.com) approved these changes 2019-03-26 06:48:02 +00:00

elegaanz (Migrated from github.com) left a comment

Thank you. 👍

Thank you. :+1:

codecov[bot] 評論

2019-03-26 07:14:25 +00:00

(Migrated from github.com)

Codecov Report

Merging #503 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #503   +/-   ##
=======================================
  Coverage   26.89%   26.89%           
=======================================
  Files          65       65           
  Lines        8966     8966           
=======================================
  Hits         2411     2411           
  Misses       6555     6555

# [Codecov](https://codecov.io/gh/Plume-org/Plume/pull/503?src=pr&el=h1) Report > Merging [#503](https://codecov.io/gh/Plume-org/Plume/pull/503?src=pr&el=desc) into [master](https://codecov.io/gh/Plume-org/Plume/commit/21cb0ef43786adee42065cecf053b8e525fe2c3f?src=pr&el=desc) will **not change** coverage. > The diff coverage is `n/a`. ```diff @@ Coverage Diff @@ ## master #503 +/- ## ======================================= Coverage 26.89% 26.89% ======================================= Files 65 65 Lines 8966 8966 ======================================= Hits 2411 2411 Misses 6555 6555 ```

登入才能加入這對話。

No reviewers

elegaanz

未選擇里程碑

No project

No assignees

1 participant

訊息

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Plume/Plume#503

No description provided.

Rows
Columns