#513 Add tests for plume webserver

Merged
Plume_migration_agent merged 9 commits from circleci into master 1 year ago

Tests are done using Firefox (I might try to use Chrome too), Selenium and Python (there is no good crate to use Selenium on Rust, so it seemed like a reasonable choice).
Also add a feature test for routes that will be necessary for some tests, but should not be on a public server (like committing Tantivy’s index on demand instead of every 30 minutes to make possible to test search page)

Tests are done using Firefox (I might try to use Chrome too), [Selenium](https://www.seleniumhq.org/projects/webdriver/) and Python (there is no good crate to use Selenium on Rust, so it seemed like a reasonable choice). Also add a feature `test` for routes that will be necessary for some tests, but should not be on a public server (like committing Tantivy's index on demand instead of every 30 minutes to make possible to test search page)
codecov[bot] commented 1 year ago (Migrated from github.com)
Owner

Codecov Report

Merging #513 into master will increase coverage by 4.84%.
The diff coverage is 80%.

@@            Coverage Diff             @@
##           master     #513      +/-   ##
==========================================
+ Coverage   24.64%   29.49%   +4.84%     
==========================================
  Files          65       66       +1     
  Lines        7120     7114       -6     
==========================================
+ Hits         1755     2098     +343     
+ Misses       5365     5016     -349
# [Codecov](https://codecov.io/gh/Plume-org/Plume/pull/513?src=pr&el=h1) Report > Merging [#513](https://codecov.io/gh/Plume-org/Plume/pull/513?src=pr&el=desc) into [master](https://codecov.io/gh/Plume-org/Plume/commit/723d2c4600d2b8c9aabc9a26562553a02616f65d?src=pr&el=desc) will **increase** coverage by `4.84%`. > The diff coverage is `80%`. ```diff @@ Coverage Diff @@ ## master #513 +/- ## ========================================== + Coverage 24.64% 29.49% +4.84% ========================================== Files 65 66 +1 Lines 7120 7114 -6 ========================================== + Hits 1755 2098 +343 + Misses 5365 5016 -349 ```
elegaanz (Migrated from github.com) reviewed 1 year ago
Plume_migration_agent commented 1 year ago

Isn’t there one of the two lines above that should be removed?

Isn't there one of the two lines above that should be removed?
Plume_migration_agent commented 1 year ago

Maybe you could add a comment telling what these parameters are, to make it easier to edit them in the future.

Maybe you could add a comment telling what these parameters are, to make it easier to edit them in the future.
trinity-1686a reviewed 1 year ago
trinity-1686a commented 1 year ago

gosh my config is so old I had MIGRATION_DIR in it (so I copied it), but I was missing the MIGRATION_DIRECTORY for diesel so I added it, but in fact MIGRATION_DIR is no longer used by us

gosh my config is so old I had MIGRATION_DIR in it (so I copied it), but I was missing the MIGRATION_DIRECTORY for diesel so I added it, but in fact MIGRATION_DIR is no longer used by us
trinity-1686a reviewed 1 year ago
trinity-1686a commented 1 year ago

I think I’ll change this to a copy statement, it will make more sense

I think I'll change this to a copy statement, it will make more sense
elegaanz (Migrated from github.com) reviewed 1 year ago
elegaanz (Migrated from github.com) left a comment

Looks good, excepted from run_browser_test.sh that I don’t understand. 😄

@@ -0,0 +5,4 @@

mkdir -p "target/cov/plume"
mkdir -p "target/cov/plm"
plm='kcov --exclude-pattern=/.cargo,/usr/lib --verify target/cov/plm plm'
Plume_migration_agent commented 1 year ago

I’m not sure to understand what you are doing here… 🤔

I'm not sure to understand what you are doing here… :thinking:
trinity-1686a reviewed 1 year ago
@@ -0,0 +5,4 @@

mkdir -p "target/cov/plume"
mkdir -p "target/cov/plm"
plm='kcov --exclude-pattern=/.cargo,/usr/lib --verify target/cov/plm plm'
trinity-1686a commented 1 year ago

I’m creating a “shortcut” to plm run with kcov because I run it multiple time in the following lines, and it’s rather long. So when I call $plm <something> after, it just mean “run plm <something> with coverage report”

I'm creating a "shortcut" to plm run with kcov because I run it multiple time in the following lines, and it's rather long. So when I call `$plm <something>` after, it just mean "run `plm <something>` with coverage report"
elegaanz (Migrated from github.com) reviewed 1 year ago
@@ -0,0 +5,4 @@

mkdir -p "target/cov/plume"
mkdir -p "target/cov/plm"
plm='kcov --exclude-pattern=/.cargo,/usr/lib --verify target/cov/plm plm'
Plume_migration_agent commented 1 year ago

Oh OK, I get it, it is to get coverage for plm too. Great!

Oh OK, I get it, it is to get coverage for plm too. Great!
elegaanz (Migrated from github.com) approved these changes 1 year ago
elegaanz (Migrated from github.com) left a comment

👍

igalic (Migrated from github.com) approved these changes 1 year ago
igalic (Migrated from github.com) left a comment

👍

Reviewers

Plume_migration_agent approved these changes 1 year ago
The pull request has been merged as eabe73ddc0.
Sign in to join this conversation.
No Milestone
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

Loading…
There is no content yet.