Add tests for plume webserver #513

trinity-1686a · 2019-04-03T06:50:50Z

trinity-1686a commented

2019-04-03 06:50:50 +00:00

Tests are done using Firefox (I might try to use Chrome too), Selenium and Python (there is no good crate to use Selenium on Rust, so it seemed like a reasonable choice).
Also add a feature test for routes that will be necessary for some tests, but should not be on a public server (like committing Tantivy's index on demand instead of every 30 minutes to make possible to test search page)

Tests are done using Firefox (I might try to use Chrome too), [Selenium](https://www.seleniumhq.org/projects/webdriver/) and Python (there is no good crate to use Selenium on Rust, so it seemed like a reasonable choice). Also add a feature `test` for routes that will be necessary for some tests, but should not be on a public server (like committing Tantivy's index on demand instead of every 30 minutes to make possible to test search page)

👍 1 ❤️ 1 🎉 1

codecov[bot] commented

2019-04-03 06:54:41 +00:00

(Migrated from github.com)

Codecov Report

Merging #513 into master will increase coverage by 4.84%.
The diff coverage is 80%.

@@            Coverage Diff             @@
##           master     #513      +/-   ##
==========================================
+ Coverage   24.64%   29.49%   +4.84%     
==========================================
  Files          65       66       +1     
  Lines        7120     7114       -6     
==========================================
+ Hits         1755     2098     +343     
+ Misses       5365     5016     -349

# [Codecov](https://codecov.io/gh/Plume-org/Plume/pull/513?src=pr&el=h1) Report > Merging [#513](https://codecov.io/gh/Plume-org/Plume/pull/513?src=pr&el=desc) into [master](https://codecov.io/gh/Plume-org/Plume/commit/723d2c4600d2b8c9aabc9a26562553a02616f65d?src=pr&el=desc) will **increase** coverage by `4.84%`. > The diff coverage is `80%`. ```diff @@ Coverage Diff @@ ## master #513 +/- ## ========================================== + Coverage 24.64% 29.49% +4.84% ========================================== Files 65 66 +1 Lines 7120 7114 -6 ========================================== + Hits 1755 2098 +343 + Misses 5365 5016 -349 ```

elegaanz (Migrated from github.com) reviewed 2019-04-03 07:11:59 +00:00

.circleci/config.yml

elegaanz (Migrated from github.com) commented

2019-04-03 07:08:29 +00:00

Isn't there one of the two lines above that should be removed?

.circleci/images/plume-buildenv/Dockerfile

elegaanz (Migrated from github.com) commented

2019-04-03 07:10:08 +00:00

Maybe you could add a comment telling what these parameters are, to make it easier to edit them in the future.

trinity-1686a reviewed 2019-04-03 07:17:45 +00:00

.circleci/config.yml

trinity-1686a commented

2019-04-03 07:17:44 +00:00

gosh my config is so old I had MIGRATION_DIR in it (so I copied it), but I was missing the MIGRATION_DIRECTORY for diesel so I added it, but in fact MIGRATION_DIR is no longer used by us

trinity-1686a reviewed 2019-04-03 07:18:36 +00:00

.circleci/images/plume-buildenv/Dockerfile

trinity-1686a commented

2019-04-03 07:18:36 +00:00

I think I'll change this to a copy statement, it will make more sense

elegaanz (Migrated from github.com) reviewed 2019-04-05 20:49:46 +00:00

elegaanz (Migrated from github.com) left a comment

Looks good, excepted from run_browser_test.sh that I don't understand. 😄

Looks good, excepted from `run_browser_test.sh` that I don't understand. :smile:

script/run_browser_test.sh

					
				@ -0,0 +5,4 @@

				mkdir -p "target/cov/plume"

				mkdir -p "target/cov/plm"

				plm='kcov --exclude-pattern=/.cargo,/usr/lib --verify target/cov/plm plm'

elegaanz (Migrated from github.com) commented

2019-04-05 20:47:41 +00:00

I'm not sure to understand what you are doing here… 🤔

I'm not sure to understand what you are doing here… :thinking:

trinity-1686a reviewed 2019-04-05 21:45:52 +00:00

script/run_browser_test.sh

					
				@ -0,0 +5,4 @@

				mkdir -p "target/cov/plume"

				mkdir -p "target/cov/plm"

				plm='kcov --exclude-pattern=/.cargo,/usr/lib --verify target/cov/plm plm'

trinity-1686a commented

2019-04-05 21:45:52 +00:00

I'm creating a "shortcut" to plm run with kcov because I run it multiple time in the following lines, and it's rather long. So when I call $plm <something> after, it just mean "run plm <something> with coverage report"

I'm creating a "shortcut" to plm run with kcov because I run it multiple time in the following lines, and it's rather long. So when I call `$plm <something>` after, it just mean "run `plm <something>` with coverage report"

elegaanz (Migrated from github.com) reviewed 2019-04-06 10:21:03 +00:00

script/run_browser_test.sh

					
				@ -0,0 +5,4 @@

				mkdir -p "target/cov/plume"

				mkdir -p "target/cov/plm"

				plm='kcov --exclude-pattern=/.cargo,/usr/lib --verify target/cov/plm plm'

elegaanz (Migrated from github.com) commented

2019-04-06 10:21:03 +00:00

Oh OK, I get it, it is to get coverage for plm too. Great!

elegaanz (Migrated from github.com) approved these changes 2019-04-06 10:21:28 +00:00

elegaanz (Migrated from github.com) left a comment

👍

:+1:

igalic (Migrated from github.com) approved these changes 2019-04-06 15:43:32 +00:00

igalic (Migrated from github.com) left a comment

👍

Sign in to join this conversation.

No reviewers

elegaanz

igalic

No milestone

No project

No assignees

2 participants

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Plume/Plume#513

Rows
Columns