Plume/Plume
9
18
複製 24
程式碼 問題管理 177 合併請求 8 版本發佈 8 Wiki Activity

Add tests for plume webserver #513

已合併
Plume_migration_agent merged 9 commit from circleci into master 2019-04-06 15:41:58 +00:00
對話內容 1 程式碼提交 9 Files changed 17 +171 -45
trinity-1686a 評論 2019-04-03 06:50:50 +00:00
管理員
Copy link

Tests are done using Firefox (I might try to use Chrome too), Selenium and Python (there is no good crate to use Selenium on Rust, so it seemed like a reasonable choice).
Also add a feature test for routes that will be necessary for some tests, but should not be on a public server (like committing Tantivy's index on demand instead of every 30 minutes to make possible to test search page)

Tests are done using Firefox (I might try to use Chrome too), [Selenium](https://www.seleniumhq.org/projects/webdriver/) and Python (there is no good crate to use Selenium on Rust, so it seemed like a reasonable choice). Also add a feature `test` for routes that will be necessary for some tests, but should not be on a public server (like committing Tantivy's index on demand instead of every 30 minutes to make possible to test search page)
👍 1 ❤️ 1 🎉 1
codecov[bot] 評論 2019-04-03 06:54:41 +00:00 (Migrated from github.com)
Copy link

Codecov Report

Merging #513 into master will increase coverage by 4.84%.
The diff coverage is 80%.

@@            Coverage Diff             @@
##           master     #513      +/-   ##
==========================================
+ Coverage   24.64%   29.49%   +4.84%     
==========================================
  Files          65       66       +1     
  Lines        7120     7114       -6     
==========================================
+ Hits         1755     2098     +343     
+ Misses       5365     5016     -349
# [Codecov](https://codecov.io/gh/Plume-org/Plume/pull/513?src=pr&el=h1) Report > Merging [#513](https://codecov.io/gh/Plume-org/Plume/pull/513?src=pr&el=desc) into [master](https://codecov.io/gh/Plume-org/Plume/commit/723d2c4600d2b8c9aabc9a26562553a02616f65d?src=pr&el=desc) will **increase** coverage by `4.84%`. > The diff coverage is `80%`. ```diff @@ Coverage Diff @@ ## master #513 +/- ## ========================================== + Coverage 24.64% 29.49% +4.84% ========================================== Files 65 66 +1 Lines 7120 7114 -6 ========================================== + Hits 1755 2098 +343 + Misses 5365 5016 -349 ```
elegaanz (Migrated from github.com) reviewed 2019-04-03 07:11:59 +00:00
.circleci/config.yml
elegaanz (Migrated from github.com) 評論 2019-04-03 07:08:29 +00:00
Copy link

Isn't there one of the two lines above that should be removed?

Isn't there one of the two lines above that should be removed?
.circleci/images/plume-buildenv/Dockerfile
elegaanz (Migrated from github.com) 評論 2019-04-03 07:10:08 +00:00
Copy link

Maybe you could add a comment telling what these parameters are, to make it easier to edit them in the future.

Maybe you could add a comment telling what these parameters are, to make it easier to edit them in the future.
trinity-1686a reviewed 2019-04-03 07:17:45 +00:00
.circleci/config.yml
trinity-1686a 評論 2019-04-03 07:17:44 +00:00
Author
管理員
Copy link

gosh my config is so old I had MIGRATION_DIR in it (so I copied it), but I was missing the MIGRATION_DIRECTORY for diesel so I added it, but in fact MIGRATION_DIR is no longer used by us

gosh my config is so old I had MIGRATION_DIR in it (so I copied it), but I was missing the MIGRATION_DIRECTORY for diesel so I added it, but in fact MIGRATION_DIR is no longer used by us
trinity-1686a reviewed 2019-04-03 07:18:36 +00:00
.circleci/images/plume-buildenv/Dockerfile
trinity-1686a 評論 2019-04-03 07:18:36 +00:00
Author
管理員
Copy link

I think I'll change this to a copy statement, it will make more sense

I think I'll change this to a copy statement, it will make more sense
elegaanz (Migrated from github.com) reviewed 2019-04-05 20:49:46 +00:00
elegaanz (Migrated from github.com) left a comment
Copy link

Looks good, excepted from run_browser_test.sh that I don't understand. 😄

Looks good, excepted from `run_browser_test.sh` that I don't understand. :smile:
script/run_browser_test.sh
@ -0,0 +5,4 @@
mkdir -p "target/cov/plume"
mkdir -p "target/cov/plm"
plm='kcov --exclude-pattern=/.cargo,/usr/lib --verify target/cov/plm plm'
elegaanz (Migrated from github.com) 評論 2019-04-05 20:47:41 +00:00
Copy link

I'm not sure to understand what you are doing here… 🤔

I'm not sure to understand what you are doing here… :thinking:
trinity-1686a reviewed 2019-04-05 21:45:52 +00:00
script/run_browser_test.sh
@ -0,0 +5,4 @@
mkdir -p "target/cov/plume"
mkdir -p "target/cov/plm"
plm='kcov --exclude-pattern=/.cargo,/usr/lib --verify target/cov/plm plm'
trinity-1686a 評論 2019-04-05 21:45:52 +00:00
Author
管理員
Copy link

I'm creating a "shortcut" to plm run with kcov because I run it multiple time in the following lines, and it's rather long. So when I call $plm <something> after, it just mean "run plm <something> with coverage report"

I'm creating a "shortcut" to plm run with kcov because I run it multiple time in the following lines, and it's rather long. So when I call `$plm <something>` after, it just mean "run `plm <something>` with coverage report"
elegaanz (Migrated from github.com) reviewed 2019-04-06 10:21:03 +00:00
script/run_browser_test.sh
@ -0,0 +5,4 @@
mkdir -p "target/cov/plume"
mkdir -p "target/cov/plm"
plm='kcov --exclude-pattern=/.cargo,/usr/lib --verify target/cov/plm plm'
elegaanz (Migrated from github.com) 評論 2019-04-06 10:21:03 +00:00
Copy link

Oh OK, I get it, it is to get coverage for plm too. Great!

Oh OK, I get it, it is to get coverage for plm too. Great!
elegaanz (Migrated from github.com) approved these changes 2019-04-06 10:21:28 +00:00
elegaanz (Migrated from github.com) left a comment
Copy link

👍

:+1:
igalic (Migrated from github.com) approved these changes 2019-04-06 15:43:32 +00:00
igalic (Migrated from github.com) left a comment
Copy link

👍

👍
登入 才能加入這對話。
Reviewers
No reviewers
elegaanz
igalic
標籤
清除已選取標籤   
A: API

Related to the REST API

  
A: Backend

Code running on the server

  
A: Federation

Stuff related to Federation

  
A: Front-End

Related to the front-end

  
A: I18N

Translations, and related code

  
A: Meta

More about project management or code than the project itself

  
A: Security

   
Build

The building, or installation process of Plume

  
C: Bug

Something isn't working

  
C: Discussion

We need to talk

  
C: Enhancement

New feature or request

  
C: Feature

This is a new feature

  
Compatibility

Compatibility with different browsers, readers and OS

  
Dependency

Related to an external package that Plume uses

  
Design

UI/UX related issues and PRs

  
Documentation

   
Good first issue

Good for newcomers

  
Help welcome

Extra attention is needed

  
Mobile

Issues affecting only mobile UX

  
Rendering

How elements're rendered out for the end user

  
S: Blocked

Something else needs to be fixed first

  
S: Duplicate

This issue or pull request already exists

  
S: Incomplete

This PR is not complete yet

  
S: Instance specific

Issues concern a limited number of instances

  
S: Invalid

This doesn't seem right

  
S: Needs Voting/Discussion

Need to be discussed by the community (on Loomio)

  
S: Ready for review

This PR is ready to be reviewed

  
Suggestion

Proposed ideas worth considering

  
S: Voted on Loomio

This is issue has been created after a vote on Loomio

  
S: Wontfix

This will not be worked on

未選擇標籤
A: API
A: Backend
A: Federation
A: Front-End
A: I18N
A: Meta
A: Security
Build
C: Bug
C: Discussion
C: Enhancement
C: Feature
Compatibility
Dependency
Design
Documentation
Good first issue
Help welcome
Mobile
Rendering
S: Blocked
S: Duplicate
S: Incomplete
S: Instance specific
S: Invalid
S: Needs Voting/Discussion
S: Ready for review
Suggestion
S: Voted on Loomio
S: Wontfix
里程碑
清除已選取里程碑
No items
未選擇里程碑
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participant
訊息
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Plume/Plume#513
No description provided.
Delete branch "circleci"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?