Plume
/
Plume
7
9
Fork 8
Code Issues 132 Pull Requests 13 Releases 4 Wiki Activity
Labels Milestones
New Pull Request

#513 Add tests for plume webserver

Merged
Plume_migration_agent merged 9 commits from circleci into master 1 year ago
Conversation 1 Commits 9 Files Changed 17
trinity-1686a commented 1 year ago

Tests are done using Firefox (I might try to use Chrome too), Selenium and Python (there is no good crate to use Selenium on Rust, so it seemed like a reasonable choice).
Also add a feature test for routes that will be necessary for some tests, but should not be on a public server (like committing Tantivy’s index on demand instead of every 30 minutes to make possible to test search page)

Tests are done using Firefox (I might try to use Chrome too), [Selenium](https://www.seleniumhq.org/projects/webdriver/) and Python (there is no good crate to use Selenium on Rust, so it seemed like a reasonable choice). Also add a feature `test` for routes that will be necessary for some tests, but should not be on a public server (like committing Tantivy's index on demand instead of every 30 minutes to make possible to test search page)
👍 1 ❤️ 1 🎉 1
codecov[bot] commented 1 year ago (Migrated from github.com)
Owner

Codecov Report

Merging #513 into master will increase coverage by 4.84%.
The diff coverage is 80%.

@@            Coverage Diff             @@
##           master     #513      +/-   ##
==========================================
+ Coverage   24.64%   29.49%   +4.84%     
==========================================
  Files          65       66       +1     
  Lines        7120     7114       -6     
==========================================
+ Hits         1755     2098     +343     
+ Misses       5365     5016     -349
# [Codecov](https://codecov.io/gh/Plume-org/Plume/pull/513?src=pr&el=h1) Report > Merging [#513](https://codecov.io/gh/Plume-org/Plume/pull/513?src=pr&el=desc) into [master](https://codecov.io/gh/Plume-org/Plume/commit/723d2c4600d2b8c9aabc9a26562553a02616f65d?src=pr&el=desc) will **increase** coverage by `4.84%`. > The diff coverage is `80%`. ```diff @@ Coverage Diff @@ ## master #513 +/- ## ========================================== + Coverage 24.64% 29.49% +4.84% ========================================== Files 65 66 +1 Lines 7120 7114 -6 ========================================== + Hits 1755 2098 +343 + Misses 5365 5016 -349 ```
elegaanz (Migrated from github.com) reviewed 1 year ago
.circleci/config.yml
Plume_migration_agent commented 1 year ago

Isn’t there one of the two lines above that should be removed?

Isn't there one of the two lines above that should be removed?
.circleci/images/plume-buildenv/Dockerfile
Plume_migration_agent commented 1 year ago

Maybe you could add a comment telling what these parameters are, to make it easier to edit them in the future.

Maybe you could add a comment telling what these parameters are, to make it easier to edit them in the future.
trinity-1686a reviewed 1 year ago
.circleci/config.yml
trinity-1686a commented 1 year ago

gosh my config is so old I had MIGRATION_DIR in it (so I copied it), but I was missing the MIGRATION_DIRECTORY for diesel so I added it, but in fact MIGRATION_DIR is no longer used by us

gosh my config is so old I had MIGRATION_DIR in it (so I copied it), but I was missing the MIGRATION_DIRECTORY for diesel so I added it, but in fact MIGRATION_DIR is no longer used by us
trinity-1686a reviewed 1 year ago
.circleci/images/plume-buildenv/Dockerfile
trinity-1686a commented 1 year ago

I think I’ll change this to a copy statement, it will make more sense

I think I'll change this to a copy statement, it will make more sense
elegaanz (Migrated from github.com) reviewed 1 year ago
elegaanz (Migrated from github.com) left a comment

Looks good, excepted from run_browser_test.sh that I don’t understand. 😄

script/run_browser_test.sh
@@ -0,0 +5,4 @@

mkdir -p "target/cov/plume"
mkdir -p "target/cov/plm"
plm='kcov --exclude-pattern=/.cargo,/usr/lib --verify target/cov/plm plm'
Plume_migration_agent commented 1 year ago

I’m not sure to understand what you are doing here… 🤔

I'm not sure to understand what you are doing here… :thinking:
trinity-1686a reviewed 1 year ago
script/run_browser_test.sh
@@ -0,0 +5,4 @@

mkdir -p "target/cov/plume"
mkdir -p "target/cov/plm"
plm='kcov --exclude-pattern=/.cargo,/usr/lib --verify target/cov/plm plm'
trinity-1686a commented 1 year ago

I’m creating a “shortcut” to plm run with kcov because I run it multiple time in the following lines, and it’s rather long. So when I call $plm <something> after, it just mean “run plm <something> with coverage report”

I'm creating a "shortcut" to plm run with kcov because I run it multiple time in the following lines, and it's rather long. So when I call `$plm <something>` after, it just mean "run `plm <something>` with coverage report"
elegaanz (Migrated from github.com) reviewed 1 year ago
script/run_browser_test.sh
@@ -0,0 +5,4 @@

mkdir -p "target/cov/plume"
mkdir -p "target/cov/plm"
plm='kcov --exclude-pattern=/.cargo,/usr/lib --verify target/cov/plm plm'
Plume_migration_agent commented 1 year ago

Oh OK, I get it, it is to get coverage for plm too. Great!

Oh OK, I get it, it is to get coverage for plm too. Great!
elegaanz (Migrated from github.com) approved these changes 1 year ago
elegaanz (Migrated from github.com) left a comment

👍

igalic (Migrated from github.com) approved these changes 1 year ago
igalic (Migrated from github.com) left a comment

👍

Reviewers

Plume_migration_agent approved these changes 1 year ago
The pull request has been merged as eabe73ddc0.
Sign in to join this conversation.
Reviewers
Request review
No reviewers
 Plume_migration_agent
Labels
Apply labels
Clear labels
A: API
Related to the REST API A: Backend
Code running on the server A: Federation
Stuff related to Federation A: Front-End
Related to the front-end A: I18N
Translations, and related code A: Meta
More about project management or code than the project itself A: Security Build
The building, or installation process of Plume C: Bug
Something isn't working C: Discussion
We need to talk C: Enhancement
New feature or request C: Feature
This is a new feature Compatibility
Compatibility with different browsers, readers and OS Dependency
Related to an external package that Plume uses Design
UI/UX related issues and PRs Documentation Good first issue
Good for newcomers Help welcome
Extra attention is needed Mobile
Issues affecting only mobile UX Rendering
How elements're rendered out for the end user S: Blocked
Something else needs to be fixed first S: Duplicate
This issue or pull request already exists S: Incomplete
This PR is not complete yet S: Instance specific
Issues concern a limited number of instances S: Invalid
This doesn't seem right S: Needs Voting/Discussion
Need to be discussed by the community (on Loomio) S: Ready for review
This PR is ready to be reviewed Suggestion
Proposed ideas worth considering S: Voted on Loomio
This is issue has been created after a vote on Loomio S: Wontfix
This will not be worked on
No Label
A: API
A: Backend
A: Federation
A: Front-End
A: I18N
A: Meta
A: Security
Build
C: Bug
C: Discussion
C: Enhancement
C: Feature
Compatibility
Dependency
Design
Documentation
Good first issue
Help welcome
Mobile
Rendering
S: Blocked
S: Duplicate
S: Incomplete
S: Instance specific
S: Invalid
S: Needs Voting/Discussion
S: Ready for review
Suggestion
S: Voted on Loomio
S: Wontfix
Milestone
Set milestone
Clear milestone
No items
No Milestone
Assignees
Assign users
Clear assignees
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'circleci'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes