#528 try to build release plume&plm on ci

Merged
Plume_migration_agent merged 4 commits from artifact into master 1 year ago

ref Plume-org/docs#27
I should archive the artifacts before uploading

ref Plume-org/docs#27 I should archive the artifacts before uploading
igalic (Migrated from github.com) reviewed 1 year ago
igalic (Migrated from github.com) left a comment

👍

codecov[bot] commented 1 year ago (Migrated from github.com)
Owner

Codecov Report

Merging #528 into master will increase coverage by 1.56%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #528      +/-   ##
==========================================
+ Coverage   40.92%   42.48%   +1.56%     
==========================================
  Files          68       68              
  Lines        9823     9314     -509     
==========================================
- Hits         4020     3957      -63     
+ Misses       5803     5357     -446
# [Codecov](https://codecov.io/gh/Plume-org/Plume/pull/528?src=pr&el=h1) Report > Merging [#528](https://codecov.io/gh/Plume-org/Plume/pull/528?src=pr&el=desc) into [master](https://codecov.io/gh/Plume-org/Plume/commit/0d708e163930779d149a8cb94766d8f4decbf080?src=pr&el=desc) will **increase** coverage by `1.56%`. > The diff coverage is `n/a`. ```diff @@ Coverage Diff @@ ## master #528 +/- ## ========================================== + Coverage 40.92% 42.48% +1.56% ========================================== Files 68 68 Lines 9823 9314 -509 ========================================== - Hits 4020 3957 -63 + Misses 5803 5357 -446 ```
elegaanz (Migrated from github.com) reviewed 1 year ago
elegaanz (Migrated from github.com) left a comment

Would it be possible to bundle the diesel CLI too, please?

elegaanz commented 1 year ago (Migrated from github.com)
Owner

And also the migration files?

And also the migration files?
trinity-1686a commented 1 year ago
Owner

Shoulf I include both migrations, only the one of interest as migrations/$db_name or only the one of interest as migrations/ (maybe not the latest as it will not be compatible with our documentation?)

Shoulf I include both migrations, only the one of interest as `migrations/$db_name` or only the one of interest as `migrations/` (maybe not the latest as it will not be compatible with our documentation?)
igalic commented 1 year ago (Migrated from github.com)
Owner

I’m not sure i’ve asked this before, but, how hard would it be to support both databases? at the same time?

I'm not sure i've asked this before, but, how hard would it be to support both databases? at the same time?
trinity-1686a commented 1 year ago
Owner

I see 2 ways of doing so :

  • using Box<Connection> everywhere
  • creating an enum whose variants are the different backend we support, which implement Connection (and some others Diesel traits) by calling the function on it’s inner type
    But I don’t know how any of those would play with r2d2 (the connection manager)
I see 2 ways of doing so : - using `Box<Connection>` everywhere - creating an enum whose variants are the different backend we support, which implement Connection (and some others Diesel traits) by calling the function on it's inner type But I don't know how any of those would play with r2d2 (the connection manager)
elegaanz commented 1 year ago (Migrated from github.com)
Owner

Couldn’t it be possible to make all our models generic over the connection type that is used? (but that’s probably more work than what you proposed)

And for the migrations, the best is to have only the relevant one in migrations/$db to make the archive smaller and keep compatibility with our current docs.

Couldn't it be possible to make all our models generic over the connection type that is used? (but that's probably more work than what you proposed) And for the migrations, the best is to have only the relevant one in `migrations/$db` to make the archive smaller and keep compatibility with our current docs.
elegaanz (Migrated from github.com) reviewed 1 year ago
elegaanz (Migrated from github.com) left a comment

Thank you!

elegaanz (Migrated from github.com) approved these changes 1 year ago
elegaanz (Migrated from github.com) left a comment

(I wanted to approve this PR)

Reviewers

Plume_migration_agent approved these changes 1 year ago
The pull request has been merged as 3d82265b85.
Sign in to join this conversation.
No Milestone
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

Loading…
There is no content yet.