Plume/Plume

Fork 24

try to build release plume&plm on ci #528

Merge aplicado

Plume_migration_agent mesclou 4 commits de artifact em master

2019-04-19 10:36:46 +00:00

trinity-1686a comentou

2019-04-18 18:59:37 +00:00

Proprietário(a)

ref Plume-org/docs#27
I should archive the artifacts before uploading

ref Plume-org/docs#27 I should archive the artifacts before uploading

igalic (Migrado de github.com) revisou 2019-04-18 20:43:45 +00:00

igalic (Migrado de github.com) deixou um comentário

👍

codecov[bot] comentou

2019-04-18 21:20:55 +00:00

(Migrado de github.com)

Codecov Report

Merging #528 into master will increase coverage by 1.56%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #528      +/-   ##
==========================================
+ Coverage   40.92%   42.48%   +1.56%     
==========================================
  Files          68       68              
  Lines        9823     9314     -509     
==========================================
- Hits         4020     3957      -63     
+ Misses       5803     5357     -446

# [Codecov](https://codecov.io/gh/Plume-org/Plume/pull/528?src=pr&el=h1) Report > Merging [#528](https://codecov.io/gh/Plume-org/Plume/pull/528?src=pr&el=desc) into [master](https://codecov.io/gh/Plume-org/Plume/commit/0d708e163930779d149a8cb94766d8f4decbf080?src=pr&el=desc) will **increase** coverage by `1.56%`. > The diff coverage is `n/a`. ```diff @@ Coverage Diff @@ ## master #528 +/- ## ========================================== + Coverage 40.92% 42.48% +1.56% ========================================== Files 68 68 Lines 9823 9314 -509 ========================================== - Hits 4020 3957 -63 + Misses 5803 5357 -446 ```

elegaanz (Migrado de github.com) revisou 2019-04-18 23:35:00 +00:00

elegaanz (Migrado de github.com) deixou um comentário

Would it be possible to bundle the diesel CLI too, please?

elegaanz comentou

2019-04-19 00:11:26 +00:00

(Migrado de github.com)

And also the migration files?

trinity-1686a comentou

2019-04-19 08:28:46 +00:00

Autor

Proprietário(a)

Shoulf I include both migrations, only the one of interest as migrations/$db_name or only the one of interest as migrations/ (maybe not the latest as it will not be compatible with our documentation?)

Shoulf I include both migrations, only the one of interest as `migrations/$db_name` or only the one of interest as `migrations/` (maybe not the latest as it will not be compatible with our documentation?)

igalic comentou

2019-04-19 09:42:11 +00:00

(Migrado de github.com)

I'm not sure i've asked this before, but, how hard would it be to support both databases? at the same time?

trinity-1686a comentou

2019-04-19 10:02:02 +00:00

Autor

Proprietário(a)

I see 2 ways of doing so :

using Box<Connection> everywhere
creating an enum whose variants are the different backend we support, which implement Connection (and some others Diesel traits) by calling the function on it's inner type
But I don't know how any of those would play with r2d2 (the connection manager)

I see 2 ways of doing so : - using `Box<Connection>` everywhere - creating an enum whose variants are the different backend we support, which implement Connection (and some others Diesel traits) by calling the function on it's inner type But I don't know how any of those would play with r2d2 (the connection manager)

elegaanz comentou

2019-04-19 10:11:02 +00:00

(Migrado de github.com)

Couldn't it be possible to make all our models generic over the connection type that is used? (but that's probably more work than what you proposed)

And for the migrations, the best is to have only the relevant one in migrations/$db to make the archive smaller and keep compatibility with our current docs.

Couldn't it be possible to make all our models generic over the connection type that is used? (but that's probably more work than what you proposed) And for the migrations, the best is to have only the relevant one in `migrations/$db` to make the archive smaller and keep compatibility with our current docs.

elegaanz (Migrado de github.com) revisou 2019-04-19 10:36:16 +00:00

elegaanz (Migrado de github.com) deixou um comentário

Thank you!

elegaanz (Migrado de github.com) aprovou estas alterações 2019-04-19 10:36:34 +00:00

elegaanz (Migrado de github.com) deixou um comentário

(I wanted to approve this PR)

Inicie a sessão para participar desta conversa.

Sem revisor

elegaanz

Sem marco

Sem projeto

Sem responsáveis

2 participantes

Notificações

Data limite

A data limite é inválida ou está fora do intervalo permitido. Por favor, use o formato "yyyy-mm-dd".

Não há data limite definida.

Dependências

Não há dependências definidas.

Referência: Plume/Plume#528

Nenhuma descrição fornecida.

Linhas
Colunas