Plume/Plume

Atzarojums 24

try to build release plume&plm on ci #528

Apvienots

Plume_migration_agent Iekļāva 4 iesūtījumus no artifact zarā master

2019-04-19 10:36:46 +00:00

trinity-1686a pievienoja piebildi

2019-04-18 18:59:37 +00:00

Īpašnieks

ref Plume-org/docs#27
I should archive the artifacts before uploading

ref Plume-org/docs#27 I should archive the artifacts before uploading

igalic (Pārcelta no github.com) izskatīja 2019-04-18 20:43:45 +00:00

igalic (Pārcelta no github.com) pievienoja piebildi

👍

codecov[bot] pievienoja piebildi

2019-04-18 21:20:55 +00:00

(Pārcelta no github.com)

Codecov Report

Merging #528 into master will increase coverage by 1.56%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #528      +/-   ##
==========================================
+ Coverage   40.92%   42.48%   +1.56%     
==========================================
  Files          68       68              
  Lines        9823     9314     -509     
==========================================
- Hits         4020     3957      -63     
+ Misses       5803     5357     -446

# [Codecov](https://codecov.io/gh/Plume-org/Plume/pull/528?src=pr&el=h1) Report > Merging [#528](https://codecov.io/gh/Plume-org/Plume/pull/528?src=pr&el=desc) into [master](https://codecov.io/gh/Plume-org/Plume/commit/0d708e163930779d149a8cb94766d8f4decbf080?src=pr&el=desc) will **increase** coverage by `1.56%`. > The diff coverage is `n/a`. ```diff @@ Coverage Diff @@ ## master #528 +/- ## ========================================== + Coverage 40.92% 42.48% +1.56% ========================================== Files 68 68 Lines 9823 9314 -509 ========================================== - Hits 4020 3957 -63 + Misses 5803 5357 -446 ```

elegaanz (Pārcelta no github.com) izskatīja 2019-04-18 23:35:00 +00:00

elegaanz (Pārcelta no github.com) pievienoja piebildi

Would it be possible to bundle the diesel CLI too, please?

elegaanz pievienoja piebildi

2019-04-19 00:11:26 +00:00

(Pārcelta no github.com)

And also the migration files?

trinity-1686a pievienoja piebildi

2019-04-19 08:28:46 +00:00

Autors

Īpašnieks

Shoulf I include both migrations, only the one of interest as migrations/$db_name or only the one of interest as migrations/ (maybe not the latest as it will not be compatible with our documentation?)

Shoulf I include both migrations, only the one of interest as `migrations/$db_name` or only the one of interest as `migrations/` (maybe not the latest as it will not be compatible with our documentation?)

igalic pievienoja piebildi

2019-04-19 09:42:11 +00:00

(Pārcelta no github.com)

I'm not sure i've asked this before, but, how hard would it be to support both databases? at the same time?

trinity-1686a pievienoja piebildi

2019-04-19 10:02:02 +00:00

Autors

Īpašnieks

I see 2 ways of doing so :

using Box<Connection> everywhere
creating an enum whose variants are the different backend we support, which implement Connection (and some others Diesel traits) by calling the function on it's inner type
But I don't know how any of those would play with r2d2 (the connection manager)

I see 2 ways of doing so : - using `Box<Connection>` everywhere - creating an enum whose variants are the different backend we support, which implement Connection (and some others Diesel traits) by calling the function on it's inner type But I don't know how any of those would play with r2d2 (the connection manager)

elegaanz pievienoja piebildi

2019-04-19 10:11:02 +00:00

(Pārcelta no github.com)

Couldn't it be possible to make all our models generic over the connection type that is used? (but that's probably more work than what you proposed)

And for the migrations, the best is to have only the relevant one in migrations/$db to make the archive smaller and keep compatibility with our current docs.

Couldn't it be possible to make all our models generic over the connection type that is used? (but that's probably more work than what you proposed) And for the migrations, the best is to have only the relevant one in `migrations/$db` to make the archive smaller and keep compatibility with our current docs.

elegaanz (Pārcelta no github.com) izskatīja 2019-04-19 10:36:16 +00:00

elegaanz (Pārcelta no github.com) pievienoja piebildi

Thank you!

elegaanz (Pārcelta no github.com) apstiprināja šīs izmaiņas 2019-04-19 10:36:34 +00:00

elegaanz (Pārcelta no github.com) pievienoja piebildi

(I wanted to approve this PR)

Nepieciešams pieteikties, lai pievienotos šai sarunai.

Nav izskatītāju

elegaanz

Nav atskaites punkta

Nav projektu

Nav atbildīgo

2 dalībnieki

Paziņojumi

Izpildes datums

Izpildes datums nav derīgs vai tas ir ārpus datumu apgabala. Lūgums izmantot pierakstu "gggg-mm-dd".

Nav uzstādīts izpildes datums.

Atkarības

Nav atkarību.

Atsauce: Plume/Plume#528

Nav sniegts apraksts.

Rindas
Ailes