try to build release plume&plm on ci #528

Sapludināts

Plume_migration_agent sapludināja 4 revīzijas no artifact uz master

trinity-1686a " komentēja "

Īpašnieks

ref Plume-org/docs#27
I should archive the artifacts before uploading

ref Plume-org/docs#27 I should archive the artifacts before uploading

igalic (Migrēts no github.com) recenzēja

igalic (Migrēts no github.com) atstāja komentāru

👍

codecov[bot] " komentēja " (Migrēts no github.com)

Codecov Report

Merging #528 into master will increase coverage by 1.56%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #528      +/-   ##
==========================================
+ Coverage   40.92%   42.48%   +1.56%     
==========================================
  Files          68       68              
  Lines        9823     9314     -509     
==========================================
- Hits         4020     3957      -63     
+ Misses       5803     5357     -446

# [Codecov](https://codecov.io/gh/Plume-org/Plume/pull/528?src=pr&el=h1) Report > Merging [#528](https://codecov.io/gh/Plume-org/Plume/pull/528?src=pr&el=desc) into [master](https://codecov.io/gh/Plume-org/Plume/commit/0d708e163930779d149a8cb94766d8f4decbf080?src=pr&el=desc) will **increase** coverage by `1.56%`. > The diff coverage is `n/a`. ```diff @@ Coverage Diff @@ ## master #528 +/- ## ========================================== + Coverage 40.92% 42.48% +1.56% ========================================== Files 68 68 Lines 9823 9314 -509 ========================================== - Hits 4020 3957 -63 + Misses 5803 5357 -446 ```

elegaanz (Migrēts no github.com) recenzēja

elegaanz (Migrēts no github.com) atstāja komentāru

Would it be possible to bundle the diesel CLI too, please?

elegaanz " komentēja " (Migrēts no github.com)

And also the migration files?

trinity-1686a " komentēja "

Autors

Īpašnieks

Shoulf I include both migrations, only the one of interest as migrations/$db_name or only the one of interest as migrations/ (maybe not the latest as it will not be compatible with our documentation?)

Shoulf I include both migrations, only the one of interest as `migrations/$db_name` or only the one of interest as `migrations/` (maybe not the latest as it will not be compatible with our documentation?)

igalic " komentēja " (Migrēts no github.com)

I'm not sure i've asked this before, but, how hard would it be to support both databases? at the same time?

trinity-1686a " komentēja "

Autors

Īpašnieks

I see 2 ways of doing so :

using Box<Connection> everywhere
creating an enum whose variants are the different backend we support, which implement Connection (and some others Diesel traits) by calling the function on it's inner type
But I don't know how any of those would play with r2d2 (the connection manager)

I see 2 ways of doing so : - using `Box<Connection>` everywhere - creating an enum whose variants are the different backend we support, which implement Connection (and some others Diesel traits) by calling the function on it's inner type But I don't know how any of those would play with r2d2 (the connection manager)

elegaanz " komentēja " (Migrēts no github.com)

Couldn't it be possible to make all our models generic over the connection type that is used? (but that's probably more work than what you proposed)

And for the migrations, the best is to have only the relevant one in migrations/$db to make the archive smaller and keep compatibility with our current docs.

Couldn't it be possible to make all our models generic over the connection type that is used? (but that's probably more work than what you proposed) And for the migrations, the best is to have only the relevant one in `migrations/$db` to make the archive smaller and keep compatibility with our current docs.

elegaanz (Migrēts no github.com) recenzēja

elegaanz (Migrēts no github.com) atstāja komentāru

Thank you!

elegaanz (Migrēts no github.com) apstiprināja izmaiņas

elegaanz (Migrēts no github.com) atstāja komentāru

(I wanted to approve this PR)

Recenzenti

Izmaiņu pieprasījums tika sapludināts ar revīziju 3d82265b85.

Varat aplūkot arī komandrindas instrukcijas.

Solis 1:

Projekta repozitorijā izveidojiet jaunu jaunu atzaru un pārbaudiet savas izmaiņas.

git checkout -b artifact master

git pull origin artifact

Solis 2:

Sapludināt izmaiņas un atjaunot tās Forgejo.

git checkout master

git merge --no-ff artifact

git push origin master

Pierakstieties, lai pievienotos šai sarunai.

Nav recenzentu

Nav atskaites punktu

Nav atbildīgo

2 dalībnieki

Paziņojumi

Izpildes termiņš

Datums līdz nav korekts. Izmantojiet formātu 'gggg-mm-dd'.

Izpildes termiņš nav uzstādīts.

Atkarības

Nav atkarību.

Notiek ielāde…

Vēl nav satura.

Etiķetes Atskaites punkti

try to build release plume&plm on ci #528

Codecov Report

Recenzenti

Solis 1:

Solis 2: