Plume/Plume

Fork 24

Remove Canapi #540

Merged

elegaanz merged 4 commits from bye-canapi into master

2019-04-28 21:17:22 +00:00

elegaanz commented

2019-04-21 08:49:10 +00:00

(Migrated from github.com)

It added more complexity than it helped.

I will eventually rewrite it as a proc-macro that generates types for an API from an OpenAPI spec, so maybe it will be re-introduced at some point (but it will be totally different).

Also I added an endpoint to delete posts, the function was here before, but not exposed.

It added more complexity than it helped. I will eventually rewrite it as a proc-macro that generates types for an API from an OpenAPI spec, so maybe it will be re-introduced at some point (but it will be totally different). Also I added an endpoint to delete posts, the function was here before, but not exposed.

codecov[bot] commented

2019-04-21 08:59:51 +00:00

(Migrated from github.com)

Codecov Report

Merging #540 into master will increase coverage by 0.3%.
The diff coverage is 0%.

@@            Coverage Diff            @@
##           master     #540     +/-   ##
=========================================
+ Coverage   43.97%   44.28%   +0.3%     
=========================================
  Files          68       68             
  Lines        7890     7835     -55     
=========================================
  Hits         3470     3470             
+ Misses       4420     4365     -55

# [Codecov](https://codecov.io/gh/Plume-org/Plume/pull/540?src=pr&el=h1) Report > Merging [#540](https://codecov.io/gh/Plume-org/Plume/pull/540?src=pr&el=desc) into [master](https://codecov.io/gh/Plume-org/Plume/commit/a20d2df50aaf39ab7e40a76c074449fac44be617?src=pr&el=desc) will **increase** coverage by `0.3%`. > The diff coverage is `0%`. ```diff @@ Coverage Diff @@ ## master #540 +/- ## ========================================= + Coverage 43.97% 44.28% +0.3% ========================================= Files 68 68 Lines 7890 7835 -55 ========================================= Hits 3470 3470 + Misses 4420 4365 -55 ```

trinity-1686a reviewed 2019-04-28 16:34:43 +00:00

trinity-1686a left a comment

Owner

small comment but not a real problem as it was already that way before

plume-api/src/posts.rs

trinity-1686a commented

2019-04-28 16:26:26 +00:00

Owner

I think it should be chosen automatically only if the user has only one blog, so to be clearly deterministic (currently it's choosing the first found, which was already the old behavior)

trinity-1686a reviewed 2019-04-28 17:23:59 +00:00

trinity-1686a left a comment

Owner

👍

:+1:

trinity-1686a approved these changes 2019-04-28 17:51:41 +00:00

trinity-1686a left a comment

Owner

👍

:+1:

No reviewers

No milestone

No project

No assignees

2 participants

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Plume/Plume#540

No description provided.

Rows
Columns